-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] [Styles] Fix filter button styles of Inventory and height Evolution
card with no data
#3733
Merged
Desvelao
merged 7 commits into
4.3-7.10---RC1
from
fix/3720-styles-inventory-add-filter-buton-evolution-agents-no-data-card
Dec 17, 2021
Merged
[FIX] [Styles] Fix filter button styles of Inventory and height Evolution
card with no data
#3733
Desvelao
merged 7 commits into
4.3-7.10---RC1
from
fix/3720-styles-inventory-add-filter-buton-evolution-agents-no-data-card
Dec 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etails flyout for `Modules/Integrity monitoring/Inventory` and `Modules/Vulnerabilities/Inventory` - Styles: - Use position:absolute to ignore the element flow and move others elements - Added a background color (light and dark theme) to the button to contrast with the text when the button is overlapping to the text. - Behavior: - Fixed the filter button wasn't displayed for any properties
…s no data to match the height of another cards in the same row
gabiwassan
approved these changes
Dec 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: ✅
Test: ✅
…er-buton-evolution-agents-no-data-card
CR: ✔️ |
eze9252
approved these changes
Dec 16, 2021
Desvelao
deleted the
fix/3720-styles-inventory-add-filter-buton-evolution-agents-no-data-card
branch
December 17, 2021 10:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes:
Modules/Integrity monitoring/Inventory
andModules/Vulnerabilities/Inventory
displayed in the details flyoutModules/Integrity monitoring/Inventory
andModules/Vulnerabilities/Inventory
displayed in the details flyout is not displayed for any properties when hoveringEvolution
card when there is no data for the selected time rangeTests
Modules/Integrity monitoring/Inventory
Modules/Vulnerabilities/Inventory
For each, check:
hover by the value of properties, a button should appear to add a filter to the searching
when the filter button is displayed, it should not move the other HTML elements
if the property value is so long, the button could be overlaped to the text, the button should be visible without problems. Check for:
Go to
Agents
and check the height ofEvolution
card to match with the height of others cards in the same row when the time range has no data.Closes #3720