Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] [Styles] Fix filter button styles of Inventory and height Evolution card with no data #3733

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Dec 16, 2021

Description

This PR fixes:

  • Styles of the button to filter in Modules/Integrity monitoring/Inventory and Modules/Vulnerabilities/Inventory displayed in the details flyout
  • The button to filter in Modules/Integrity monitoring/Inventory and Modules/Vulnerabilities/Inventory displayed in the details flyout is not displayed for any properties when hovering
  • Height of Evolution card when there is no data for the selected time range
    image

Tests

  • Go to the details flyout of:
    • Modules/Integrity monitoring/Inventory
    • Modules/Vulnerabilities/Inventory

For each, check:

  • hover by the value of properties, a button should appear to add a filter to the searching

  • when the filter button is displayed, it should not move the other HTML elements

  • if the property value is so long, the button could be overlaped to the text, the button should be visible without problems. Check for:

    • Light theme
    • Dark theme
  • Go to Agents and check the height of Evolution card to match with the height of others cards in the same row when the time range has no data.

Closes #3720

…etails flyout for `Modules/Integrity monitoring/Inventory` and `Modules/Vulnerabilities/Inventory`

  - Styles:
    - Use position:absolute to ignore the element flow and move others
      elements
    - Added a background color (light and dark theme) to the button to contrast with the text
      when the button is overlapping to the text.
  - Behavior:
    - Fixed the filter button wasn't displayed for any properties
…s no data to match the height of another cards in the same row
@Desvelao Desvelao added the type/bug Bug issue label Dec 16, 2021
@Desvelao Desvelao requested a review from a team December 16, 2021 10:24
@Desvelao Desvelao self-assigned this Dec 16, 2021
@Desvelao Desvelao linked an issue Dec 16, 2021 that may be closed by this pull request
Copy link
Contributor

@gabiwassan gabiwassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

@eze9252
Copy link
Contributor

eze9252 commented Dec 16, 2021

CR: ✔️
Test: ✔️

@eze9252 eze9252 added the 4.3 label Dec 17, 2021
@Desvelao Desvelao merged commit 92ef336 into 4.3-7.10---RC1 Dec 17, 2021
@Desvelao Desvelao deleted the fix/3720-styles-inventory-add-filter-buton-evolution-agents-no-data-card branch December 17, 2021 10:26
@ghost
Copy link

ghost commented Jan 3, 2022

The height of the Evolution card is not the same height as the status and details cards.

Kibana Version: 7.16.1
Wazuh -Kibana-App Version: 4.3 RC2

Screenshot from 2022-01-03 15-27-37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Bug issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style issues: Agent evolution histogram and inventory flyout
3 participants