Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboards PDF report error when switching pinned agent #3748

Merged
merged 2 commits into from Jan 11, 2022
Merged

Dashboards PDF report error when switching pinned agent #3748

merged 2 commits into from Jan 11, 2022

Conversation

asteriscos
Copy link
Member

Hi team,

this PR fixes once a PDF report is generated, when an agent is pinned or unpinned and a NEW report is generated it fails.

Closes #3746

To test it:

  1. Navigate to any Dashboard
  2. Click on Generate Report
  3. Pin an agent
  4. Generate a new report
  5. Check both reports were properly created

Peek 2021-12-23 11-00

@asteriscos asteriscos self-assigned this Dec 23, 2021
@asteriscos asteriscos added the 4.3 label Dec 23, 2021
Desvelao
Desvelao approved these changes Dec 23, 2021
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review
Code ✅

@asteriscos asteriscos changed the base branch from 4.3-7.10-RC2 to 4.3-7.10 December 23, 2021 10:18
@asteriscos asteriscos changed the base branch from 4.3-7.10 to 4.3-7.10-RC2 December 23, 2021 10:28
eze9252
eze9252 approved these changes Dec 23, 2021
View reviewed changes
Copy link
Contributor

@eze9252 eze9252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

matiasmoreno876
matiasmoreno876 approved these changes Dec 23, 2021
View reviewed changes
Copy link
Contributor

@matiasmoreno876 matiasmoreno876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR LGTM ✅

@Desvelao Desvelao added the type/bug Bug issue label Dec 28, 2021
@Desvelao Desvelao linked an issue Dec 28, 2021 that may be closed by this pull request
Dashboard PDF report error when switching pinned agent state #3746
Closed
@yenienserrano
Copy link
Member

LGTM ✔️

@Desvelao Desvelao mentioned this pull request Jan 3, 2022
Closed
@yenienserrano yenienserrano self-requested a review January 11, 2022 14:29
@Desvelao Desvelao merged commit 92c2462 into 4.3-7.10-RC2 Jan 11, 2022
@Desvelao Desvelao deleted the fix/report-error-when-switching-pinned-agent-3746 branch January 11, 2022 16:17
@Mayons Mayons mentioned this pull request Jan 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao approved these changes

@eze9252 eze9252 eze9252 approved these changes

@matiasmoreno876 matiasmoreno876 matiasmoreno876 approved these changes

@yenienserrano yenienserrano yenienserrano approved these changes

Assignees

@asteriscos asteriscos

Labels
type/bug Bug issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dashboard PDF report error when switching pinned agent state
5 participants
@asteriscos @yenienserrano @Desvelao @eze9252 @matiasmoreno876