Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] [API Console] Styles of action buttons overlaying the request text #3772

Merged
merged 3 commits into from Jan 11, 2022
Merged

[FIX] [API Console] Styles of action buttons overlaying the request text #3772

merged 3 commits into from Jan 11, 2022

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Jan 3, 2022 •
edited

Description

This PR adds styles to contrast the request text of the action buttons.

Changes

  • Added a background color to the buttons of same color or highlighted request line
    Light theme:
    image
    Dark theme:
    image

Tests

  • In Tools/API Console, add a request with long text or reduce the request panel to overlay the action buttons to the request text. The button should have more contrast and should be visible in a better way.

Closes #3770

@Desvelao
fix: API Console buttons overlays to request text.
2925b4f 
  - Added a background color to the buttons of same color or highlighted request line
@Desvelao Desvelao added the type/enhancement Enhancement issue label Jan 3, 2022
@Desvelao Desvelao requested a review from a team January 3, 2022 08:16
@Desvelao Desvelao self-assigned this Jan 3, 2022
@Desvelao Desvelao linked an issue Jan 3, 2022 that may be closed by this pull request
Text overlaps the console play button on Devtools API console #3770
Closed
asteriscos
asteriscos approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️
LGMT

image

@Desvelao Desvelao merged commit 0f50a05 into 4.3-7.10-RC2 Jan 11, 2022
@Desvelao Desvelao deleted the fix/3770-api-console-sytle-buttons-overlay-request-text branch January 11, 2022 16:19
@Mayons Mayons mentioned this pull request Jan 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteriscos asteriscos asteriscos approved these changes

Assignees

@Desvelao Desvelao

Labels
type/enhancement Enhancement issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Text overlaps the console play button on Devtools API console
2 participants
@Desvelao @asteriscos