Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] [Modules] [Panel] Update aggregation data when the time filter is changed #3790

Merged

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Jan 7, 2022

Description

This PR fixes the aggregation tables in Modules/<Module>/Panel are not updated when the time filter is changed

Changes

  • Added the timeFilter as dependency to update the data

Tests

  • With alerts data about the module, go to Modules/<Module>/Panel (currently only the Office 365 and GitHub modules have this tab) and change the time filter, the displayed data should change according to the time range selected.

Closes #3789

… section

  - Added the `timeFilter` as dependency to update the data
@Desvelao Desvelao added type/bug Bug issue 4.3 labels Jan 7, 2022
@Desvelao Desvelao requested a review from a team January 7, 2022 12:00
@Desvelao Desvelao self-assigned this Jan 7, 2022
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test: ✔️
CR: ✔️
LGTM!

@yenienserrano
Copy link
Member

Test: ✅
CR: ✅
LGTM!

@yenienserrano yenienserrano self-requested a review January 10, 2022 20:44
@Desvelao Desvelao merged commit 287abf2 into 4.3-7.10-RC2 Jan 11, 2022
@Desvelao Desvelao deleted the fix/3789-update-panel-tables-changing-time-filter branch January 11, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Bug issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Modules] [Panel] The aggregation sumary tables are not updated when the time filter is changed
3 participants