[FIX] [GROUPS] Fixes creating a new group with invalid name and no display the remove button in the agents table for the default group
#3804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when the group name is the `default` group
Desvelao
force-pushed
the
fix/3802-3803-fixes-management-groups
branch
from
d35fb2a
to
9b64fce
Compare
Desvelao
changed the title
default group
Desvelao
changed the title
default groupdefault group
This was
linked to
issues
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the next things:
Management/Groupsdefaultgroup:Test
Management/Groups. Click on theAdd new groupbutton and write an invalid name. Click on theSave new groupbutton and a toast message should be displayed with the error.Management/Groups. Click on thedefaultgroup and see the remove button is not displayed for the agent's table. Create a custom group, add some agents and review the agent's table for the group and should have the remove button.Closes #3802 #3803