Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix internal xpack user request forbidden #3831

Merged
merged 4 commits into from Feb 9, 2022

Conversation

asteriscos
Copy link
Member

Hi team,

this PR fixes a rejected request to know if x-pack is active. Now it tolerates the internal user not having the resource permission and contemplates this error.

Closes #3829

To test it

  • Setup an internal user in kibana.yml which causes a 403 error in a GET /_security/user request
  • Make sure you login without errors
  • Go to Wazuh menu -> Security -> Role mapping and create a new role mapping without errors
  • Go to Wazuh menu -> Modules -> Security events and create a PDF report
  • Check the PDF report was properly created

@asteriscos asteriscos self-assigned this Feb 9, 2022
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review:
Code review ✅
Testing ✅

@Desvelao Desvelao added the 4.3 label Feb 9, 2022
@Desvelao Desvelao linked an issue Feb 9, 2022 that may be closed by this pull request
@Desvelao Desvelao merged commit 4d5dfd3 into 4.3-7.16 Feb 9, 2022
@Desvelao Desvelao deleted the fix/interal-xpack-user-request-forbidden-3829 branch February 9, 2022 11:52
Desvelao added a commit that referenced this pull request Feb 9, 2022
* bump: Bump the Kibana version to 7.16.3

* 403 error is now accepted as a valid request

* Added changelog

Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getInternalUser function is not been called on Roles Mapping
2 participants