Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed agents details card style #3845

Merged
merged 2 commits into from Feb 22, 2022
Merged

Fixed agents details card style #3845

merged 2 commits into from Feb 22, 2022

Conversation

Machi3mfl
Copy link
Member

@Machi3mfl Machi3mfl commented Feb 14, 2022 •
edited

Hi Team,
This PR resolves a wrong width from the agent's details card.
Because of that, In some resolutions, the agent's evolution visualization is off the screen.

Closes #3837

@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 4.04% ( 1474 / 36470 )
Branches 1.61% ( 459 / 28457 )
Functions 2.96% ( 264 / 8904 )
Lines 4.09% ( 1426 / 34866 )

yenienserrano
yenienserrano approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test: ✔️
CR: ✔️

@Machi3mfl Machi3mfl added the 4.3 label Feb 22, 2022
@Machi3mfl Machi3mfl self-assigned this Feb 22, 2022
matiasmoreno876
matiasmoreno876 approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@matiasmoreno876 matiasmoreno876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR OK ✅
TEST OK ✅

image

@Desvelao Desvelao merged commit 830ac00 into 4.3-7.10 Feb 22, 2022
@Desvelao Desvelao deleted the bugfix/3837-fixed-agents-details-card-styles branch February 22, 2022 15:51
@Mayons
Copy link

Mayons commented Feb 22, 2022

Test OK
image
image

@Desvelao Desvelao mentioned this pull request Feb 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matiasmoreno876 matiasmoreno876 matiasmoreno876 approved these changes

@yenienserrano yenienserrano yenienserrano approved these changes

Assignees

@Machi3mfl Machi3mfl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Machi3mfl @Mayons @matiasmoreno876 @yenienserrano @Desvelao