Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Agents and Configuration checksum sorting #3857

Merged

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Feb 23, 2022

Description

Hi team,

this PR disables the sorting of Agents and Configuration checksum in the table of Management/Groups as it lacks the feature to be sorted.

Screenshots

image

Closes #3819

@asteriscos asteriscos added the 4.3 label Feb 23, 2022
@asteriscos asteriscos self-assigned this Feb 23, 2022
CHANGELOG.md Outdated
@@ -129,6 +129,7 @@ All notable changes to the Wazuh app project will be documented in this file.
- Removed the button to remove an agent for a group in the agents' table when it is the default group [#3804](https://github.com/wazuh/wazuh-kibana-app/pull/3804)
- Fixed internal user no longer needs permission to make x-pack detection request [#3831](https://github.com/wazuh/wazuh-kibana-app/pull/3831)
- Fixed agents details card style [#3845](https://github.com/wazuh/wazuh-kibana-app/pull/3845)
- Disable configuration checksum sorting in groups management table [#3857](https://github.com/wazuh/wazuh-kibana-app/pull/3857)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thougth: Probably, the change in the changelog should be moved to another version/revision depending on the version this will be released.

@Desvelao
Copy link
Member

Desvelao commented Mar 7, 2022

review
Code review - Pending changelog
Testing ✅

… in the table of `Management/Groups` due to this is not supported by the API
@Desvelao
Copy link
Member

Desvelao commented Apr 6, 2022

Changes

  • Disabled the sorting by the Agents due to do it, causes the view breaks
    image

Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test: ✔️
CR: ✔️

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

Jest Test Coverage % values
Statements 4.04% ( 1476 / 36559 )
Branches 1.61% ( 459 / 28480 )
Functions 2.98% ( 266 / 8934 )
Lines 4.09% ( 1428 / 34951 )

@asteriscos
Copy link
Member Author

Changes

  • Disabled the sorting by the Agents due to do it, causes the view breaks
    image

This was to be implemented when the agents sorting feature in Wazuh API was available. Until then agents sorting will be disabled.

@Desvelao Desvelao changed the title Disable configuration checksum sorting Disable Agents and Configuration checksum sorting Apr 6, 2022
@Desvelao Desvelao merged commit 937cffc into 4.3-7.10 Apr 6, 2022
@Desvelao Desvelao deleted the fix/disable-config-checksum-sort-in-groups-table-3819 branch April 6, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid sorting by 'Agents' and 'Configuration checksum' fields in the Groups menu.
3 participants