Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added parenthesis to search bar query in PDF report #3861

Merged
merged 3 commits into from Apr 20, 2022
Merged

Added parenthesis to search bar query in PDF report #3861

merged 3 commits into from Apr 20, 2022

Conversation

asteriscos
Copy link
Member

Hi team,

this PR fixes the PDF reports search bar query by encapsulating the query. It prevents issues when using queries with OR operators.

Closes #3853

To test it:

  • Go to a dashboard with 2 o more agents
  • Filter a query in the search bar with OR operators which would result in 1 agent per condition
    like: agent.name : *W* OR agent.name : *180*
  • Generate a PDF report and check the amount of agents in the table are the same as in the dashboard

@asteriscos asteriscos self-assigned this Feb 23, 2022
AlexRuiz7
AlexRuiz7 approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@AlexRuiz7 AlexRuiz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

@AlexRuiz7 AlexRuiz7 linked an issue Mar 1, 2022 that may be closed by this pull request
Report false result when using logical operator #3853
Closed
Desvelao
Desvelao approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review

Code review ✅
Testing ✅

@Desvelao
Copy link
Member

Desvelao commented Mar 8, 2022

nitpick: The change in the changelog should be set in the correct plugin version/revision.

@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 4.04% ( 1476 / 36557 )
Branches 1.61% ( 459 / 28477 )
Functions 2.98% ( 266 / 8935 )
Lines 4.09% ( 1428 / 34948 )

@AlexRuiz7 AlexRuiz7 merged commit db04017 into 4.3-7.10 Apr 20, 2022
@AlexRuiz7 AlexRuiz7 deleted the fix/add-parenthesis-to-search-bar-query-3853 branch April 20, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexRuiz7 AlexRuiz7 AlexRuiz7 approved these changes

@Desvelao Desvelao Desvelao approved these changes

Assignees

@asteriscos asteriscos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Report false result when using logical operator
3 participants
@asteriscos @Desvelao @AlexRuiz7