-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added agents windows events config tab #3905
Conversation
|
Why is the Commands section missing now? There was more in there than just misplaced Windows event channel references. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: ✔️
Test: ✔️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: There are a few suggestions to improve code readability.
...lers/management/components/management/configuration/util-components/configuration-setting.js
Outdated
Show resolved
Hide resolved
...anagement/components/management/configuration/log-collection/log-collection-windowsevents.js
Outdated
Show resolved
Hide resolved
...anagement/components/management/configuration/log-collection/log-collection-windowsevents.js
Outdated
Show resolved
Hide resolved
...lers/management/components/management/configuration/log-collection/log-collection-sockets.js
Outdated
Show resolved
Hide resolved
...rollers/management/components/management/configuration/log-collection/log-collection-logs.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TR ✔️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✔️
Good job!
* Added custom renderLabel functionality * Added Windows Events tab in agent configuration * Updated CHANGELOG * Added log collection tests for command and windows event tabs * Updated some test description * Removed unused code and redefine some conditions * Conditionals improves code readability Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit ca1781c)
* Added custom renderLabel functionality * Added Windows Events tab in agent configuration * Updated CHANGELOG * Added log collection tests for command and windows event tabs * Updated some test description * Removed unused code and redefine some conditions * Conditionals improves code readability Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit ca1781c)
Added agents windows events config tab (#3905) * Added custom renderLabel functionality * Added Windows Events tab in agent configuration * Updated CHANGELOG * Added log collection tests for command and windows event tabs * Updated some test description * Removed unused code and redefine some conditions * Conditionals improves code readability Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit ca1781c) Co-authored-by: Maximiliano Ibarra <maximilianoaibarra@gmail.com>
Added agents windows events config tab (#3905) * Added custom renderLabel functionality * Added Windows Events tab in agent configuration * Updated CHANGELOG * Added log collection tests for command and windows event tabs * Updated some test description * Removed unused code and redefine some conditions * Conditionals improves code readability Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit ca1781c) Co-authored-by: Maximiliano Ibarra <maximilianoaibarra@gmail.com>
Hi Team,
This PR added the Windows Event section in Agent > Configuration
#3646