Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added agents windows events config tab #3905

Merged
merged 9 commits into from
Sep 6, 2022

Conversation

Machi3mfl
Copy link
Member

Hi Team,
This PR added the Windows Event section in Agent > Configuration

#3646

@Machi3mfl Machi3mfl requested a review from a team March 18, 2022 17:51
@Machi3mfl Machi3mfl self-assigned this Mar 18, 2022
@Machi3mfl Machi3mfl added the 4.4 label Mar 21, 2022
@Machi3mfl Machi3mfl linked an issue Apr 20, 2022 that may be closed by this pull request
@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 4.04% ( 1478 / 36552 )
Branches 1.62% ( 462 / 28536 )
Functions 2.99% ( 267 / 8937 )
Lines 4.09% ( 1430 / 34946 )

@Mayons95 Mayons95 self-requested a review May 27, 2022 18:35
@Mayons95
Copy link
Contributor

Testing in progress:
Screen for agent 4.2.6
image
image
image

Screen for agent 4.3

@Mayons95
Copy link
Contributor

Screenshot for 4.3
image
image
image

TEST OK

@branchnetconsulting
Copy link

Why is the Commands section missing now? There was more in there than just misplaced Windows event channel references.

@Desvelao Desvelao changed the base branch from 4.3-7.10 to 4.4-7.10 June 24, 2022 08:53
@chantal-kelm chantal-kelm self-requested a review July 8, 2022 10:37
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️
Screenshot from 2022-07-08 07-37-07

Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: There are a few suggestions to improve code readability.

@Mayons95
Copy link
Contributor

Mayons95 commented Sep 6, 2022

TR ✔️

Screenshot from 2022-09-06 10-20-17
Screenshot from 2022-09-06 10-19-50
Screenshot from 2022-09-06 10-19-23

Copy link
Contributor

@Mayons95 Mayons95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TR ✔️

Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️
Good job!

@Machi3mfl Machi3mfl merged commit ca1781c into 4.4-7.10 Sep 6, 2022
@Machi3mfl Machi3mfl deleted the feature/3646-agents-windows-events-config branch September 6, 2022 14:09
github-actions bot pushed a commit that referenced this pull request Sep 6, 2022
* Added custom renderLabel functionality

* Added Windows Events tab in agent configuration

* Updated CHANGELOG

* Added log collection tests for command and windows event tabs

* Updated some test description

* Removed unused code and redefine some conditions

* Conditionals improves code readability

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit ca1781c)
github-actions bot pushed a commit that referenced this pull request Sep 6, 2022
* Added custom renderLabel functionality

* Added Windows Events tab in agent configuration

* Updated CHANGELOG

* Added log collection tests for command and windows event tabs

* Updated some test description

* Removed unused code and redefine some conditions

* Conditionals improves code readability

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit ca1781c)
Machi3mfl added a commit that referenced this pull request Sep 7, 2022
Added agents windows events config tab (#3905)

* Added custom renderLabel functionality

* Added Windows Events tab in agent configuration

* Updated CHANGELOG

* Added log collection tests for command and windows event tabs

* Updated some test description

* Removed unused code and redefine some conditions

* Conditionals improves code readability

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit ca1781c)

Co-authored-by: Maximiliano Ibarra <maximilianoaibarra@gmail.com>
Machi3mfl added a commit that referenced this pull request Sep 7, 2022
Added agents windows events config tab (#3905)

* Added custom renderLabel functionality

* Added Windows Events tab in agent configuration

* Updated CHANGELOG

* Added log collection tests for command and windows event tabs

* Updated some test description

* Removed unused code and redefine some conditions

* Conditionals improves code readability

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit ca1781c)

Co-authored-by: Maximiliano Ibarra <maximilianoaibarra@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong visualization for EventChannel localfiles
8 participants