Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export a valid json #3909

Merged
merged 3 commits into from Apr 6, 2022
Merged

Export a valid json #3909

merged 3 commits into from Apr 6, 2022

Conversation

yenienserrano
Copy link
Member

Description:

Removed backslash replacement to display the same answer on the page

Issues Resolved:

Backslash breaks the exported JSON result #3902

Test:

  1. Navigate to '"API Console'
  2. Retrieve results for SCA win policy GET /sca/004/checks/sca_win_audit?result=failed
  3. Export it
  4. Copy the exported into a json validator

Screenshot:
image
image

@yenienserrano yenienserrano self-assigned this Mar 22, 2022
@yenienserrano yenienserrano mentioned this pull request Mar 22, 2022
Closed
@yenienserrano yenienserrano requested a review from a team March 22, 2022 14:40
@AlexRuiz7 AlexRuiz7 linked an issue Mar 23, 2022 that may be closed by this pull request
Backslash breaks the exported JSON result #3902
Closed
Desvelao
Desvelao requested changes Mar 31, 2022
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review: Add an entry to the changelog with the change. We should discuss for what version we want to add the fix.

@yenienserrano yenienserrano marked this pull request as ready for review April 4, 2022 13:58
@yenienserrano yenienserrano requested a review from a team April 5, 2022 10:00
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2022

Jest Test Coverage % values
Statements 4.04% ( 1476 / 36556 )
Branches 1.61% ( 459 / 28480 )
Functions 2.98% ( 266 / 8934 )
Lines 4.09% ( 1428 / 34948 )

@yenienserrano yenienserrano added 4.3 and removed 4.4 labels Apr 5, 2022
asteriscos
asteriscos approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test: ✔️
CR: ✔️

Desvelao
Desvelao approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review:
Code review ✔️
Test ✔️

@Desvelao Desvelao merged commit 2af995c into 4.3-7.10 Apr 6, 2022
@Desvelao Desvelao deleted the fix/3902-export-a-valid-JSON branch April 6, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteriscos asteriscos asteriscos approved these changes

@Desvelao Desvelao Desvelao approved these changes

Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backslash breaks the exported JSON result
3 participants
@yenienserrano @asteriscos @Desvelao