Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change logout path #3957

Merged
merged 4 commits into from Apr 8, 2022
Merged

Change logout path #3957

merged 4 commits into from Apr 8, 2022

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Apr 7, 2022 •
edited

Description:

The basePath was changed to take the kibana subpath

Issues Resolved:

Logout doesn't work with yarn start command #3953

Test:

  1. Start kibana with the yarn start command
  2. Navigate to wazuh
  3. Click on logout
  4. See that logout works
  5. Start kibana with the yarn start --no-base-path command
  6. Navigate to wazuh
  7. Click on logout
  8. See that logout works

Screenshot:

image

@yenienserrano yenienserrano requested a review from a team April 7, 2022 14:12
@yenienserrano yenienserrano self-assigned this Apr 7, 2022
@yenienserrano yenienserrano mentioned this pull request Apr 7, 2022
Closed
@yenienserrano yenienserrano marked this pull request as ready for review April 7, 2022 14:17
@yenienserrano yenienserrano linked an issue Apr 7, 2022 that may be closed by this pull request
Logout doesn't work with yarn start command #3953
Closed
@Desvelao Desvelao added 4.3 and removed 4.4 labels Apr 8, 2022
Desvelao
Desvelao approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review
Code review ✔️
Test ✔️

@Desvelao Desvelao merged commit 06350f8 into 4.3-7.10 Apr 8, 2022
@Desvelao Desvelao deleted the fix/3953-logout-doesnt-work-yarn-start branch April 8, 2022 07:39
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2022

Jest Test Coverage % values
Statements 4.04% ( 1476 / 36555 )
Branches 1.61% ( 459 / 28476 )
Functions 2.98% ( 266 / 8934 )
Lines 4.09% ( 1428 / 34947 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao approved these changes

Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logout doesn't work with yarn start command
2 participants
@yenienserrano @Desvelao