Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can remove custom filter #4112

Merged
merged 4 commits into from Apr 28, 2022
Merged

Can remove custom filter #4112

merged 4 commits into from Apr 28, 2022

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Apr 28, 2022 •
edited by asteriscos

Description:

Changes in the function where it checks if the filter is from the modules view or if it is an added filter, since currently the filters that can be added, such as the negation of the filters of each module, cannot be removed, and ideally they are have to be able to remove all custom filters.

issue:

Test:

You should always be able to remove the filter

  1. Navigate to any module, for example, Security Events
  2. Add filter NOT cluster.name: wazuh
  3. Pin filter
  4. Unpin filter

Screenshot:

Filtros

@yenienserrano yenienserrano requested a review from a team April 28, 2022 09:01
@yenienserrano yenienserrano linked an issue Apr 28, 2022 that may be closed by this pull request
Can't remove cluster filters #4045
Closed
AlexRuiz7
AlexRuiz7 approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@AlexRuiz7 AlexRuiz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Code review: ✔️
  • Test: ✔️

@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 4.03% ( 1474 / 36533 )
Branches 1.61% ( 459 / 28469 )
Functions 2.98% ( 266 / 8929 )
Lines 4.08% ( 1426 / 34928 )

@yenienserrano yenienserrano mentioned this pull request Apr 28, 2022
Closed
matiasmoreno876
matiasmoreno876 approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@matiasmoreno876 matiasmoreno876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR OK ✅
TEST OK ✅

@matiasmoreno876 matiasmoreno876 merged commit 42ee78c into 4.3-7.10 Apr 28, 2022
@matiasmoreno876 matiasmoreno876 deleted the fix/4045-cant-remove-filter branch April 28, 2022 19:14
@mauceballos mauceballos self-requested a review April 28, 2022 19:21
@mauceballos
Copy link
Contributor

Testing on kibana v7.10.2 OK

4112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexRuiz7 AlexRuiz7 AlexRuiz7 approved these changes

@matiasmoreno876 matiasmoreno876 matiasmoreno876 approved these changes

@mauceballos mauceballos Awaiting requested review from mauceballos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't remove cluster filters
4 participants
@yenienserrano @mauceballos @AlexRuiz7 @matiasmoreno876