Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when selecting date range in discover #4115

Merged
merged 3 commits into from Apr 29, 2022

Conversation

matiasmoreno876
Copy link
Contributor

Hi team, in this PR we were able to solve the problem reported in the following issue #4052 In it we have performed a dataParse() on the selection date.

Many thanks to @asteriscos and @yenienserrano for participating in the solution of the problem.

Closes #4052

@matiasmoreno876 matiasmoreno876 changed the title fixed issue when selecting a time range Fix error when selecting date range in discover Apr 28, 2022
@Mayons Mayons self-requested a review April 28, 2022 18:08
@Mayons
Copy link

Mayons commented Apr 28, 2022

Test OK ! The Behaviour is the expected.
The chart refresh it's low.

Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review:
Code review ✔️
Test ✔️

@Desvelao
Copy link
Member

The dataParse was removed in a previous PR: https://github.com/wazuh/wazuh-kibana-app/pull/3947/files#diff-fc361d7db6d22daa49b23e2bd557e85135066d6de37fb7bcc14cea20f2066414L393-L394

Changes

I moved the PR entry in the changelog to the same fix as the PR that introduced the bug.

@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 4.03% ( 1474 / 36533 )
Branches 1.61% ( 459 / 28469 )
Functions 2.98% ( 266 / 8929 )
Lines 4.08% ( 1426 / 34928 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security Events cannot be accessed after selecting a time range
5 participants