Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Visualizations are not built due a Types was not set error in a production package #4200

Merged
merged 2 commits into from
Jun 6, 2022

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Jun 3, 2022

Description

This PR fixes an error that appears in the production package when building the visualizations. The problem doesn't appear in development mode, as they are rendered correctly.

Changes

  • Revert how the visualization is built
  • Add logic to apply the params and uiStateJSON properties of the visualization that due to a bug in Kibana 7.10.2 these are not working.

Screenshots

image

Test

  • The visualizations should be visible in development mode and in a production package without the mentioned error.
  • Moreover, the visualizations should renders as expected related to the UI properties.
    • Use case: with data related to the monitoring job of the plugin (agent status), review that the Evolution visualization of Agents section is displayed with the expected colors for the status labels.
  • Review each visualization is visible without problems to see if there is not any problem with the new logic to set some properties of the visualization

Closes #4199

…in a production package

- fix `Types was not set` error appearing in production package
More information in: #4199 (comment)
@Desvelao Desvelao self-assigned this Jun 3, 2022
@Desvelao Desvelao changed the base branch from master to 4.3-7.10 June 3, 2022 13:25
@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2022

Jest Test Coverage % values
Statements 4.09% ( 1489 / 36382 )
Branches 1.68% ( 473 / 28238 )
Functions 3.06% ( 272 / 8897 )
Lines 4.14% ( 1440 / 34800 )

Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️
image

Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✅
Test ✅

Copy link
Member

@AlexRuiz7 AlexRuiz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlexRuiz7 AlexRuiz7 merged commit e8c4815 into 4.3-7.10 Jun 6, 2022
@AlexRuiz7 AlexRuiz7 deleted the fix/4199-visualization-types-was-not-set-error branch June 6, 2022 11:15
github-actions bot pushed a commit that referenced this pull request Jun 6, 2022
… production package (#4200)

* fix: fix an error that avoids the visualizations are built correctly in a production package

- fix `Types was not set` error appearing in production package
More information in: #4199 (comment)

* changelog: add PR entry

(cherry picked from commit e8c4815)
github-actions bot pushed a commit that referenced this pull request Jun 6, 2022
… production package (#4200)

* fix: fix an error that avoids the visualizations are built correctly in a production package

- fix `Types was not set` error appearing in production package
More information in: #4199 (comment)

* changelog: add PR entry

(cherry picked from commit e8c4815)
github-actions bot pushed a commit that referenced this pull request Jun 6, 2022
… production package (#4200)

* fix: fix an error that avoids the visualizations are built correctly in a production package

- fix `Types was not set` error appearing in production package
More information in: #4199 (comment)

* changelog: add PR entry

(cherry picked from commit e8c4815)
Desvelao added a commit that referenced this pull request Jun 7, 2022
… was not set error in a production package (#4213)

[FIX] Visualizations are not built due a Types was not set error in a production package (#4200)

* fix: fix an error that avoids the visualizations are built correctly in a production package

- fix `Types was not set` error appearing in production package
More information in: #4199 (comment)

* changelog: add PR entry

(cherry picked from commit e8c4815)

Co-authored-by: Antonio <34042064+Desvelao@users.noreply.github.com>
Desvelao added a commit that referenced this pull request Jun 7, 2022
…pes was not set error in a production package (#4214)

[FIX] Visualizations are not built due a Types was not set error in a production package (#4200)

* fix: fix an error that avoids the visualizations are built correctly in a production package

- fix `Types was not set` error appearing in production package
More information in: #4199 (comment)

* changelog: add PR entry

(cherry picked from commit e8c4815)

Co-authored-by: Antonio <34042064+Desvelao@users.noreply.github.com>
Desvelao added a commit that referenced this pull request Jun 7, 2022
… not built due a Types was not set error in a production package (#4215)

[FIX] Visualizations are not built due a Types was not set error in a production package (#4200)

* fix: fix an error that avoids the visualizations are built correctly in a production package

- fix `Types was not set` error appearing in production package
More information in: #4199 (comment)

* changelog: add PR entry

(cherry picked from commit e8c4815)

Co-authored-by: Antonio <34042064+Desvelao@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants