Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix creating PDF reports in x-pack without authentication context #4358

Merged
merged 3 commits into from Aug 4, 2022
Merged

Fix creating PDF reports in x-pack without authentication context #4358

merged 3 commits into from Aug 4, 2022

Conversation

asteriscos
Copy link
Member

Description

This PR fixes when x-pack is detected with no authContext available and no hashUsername is provided. Therefore in this kind of context, creating PDF reports fails.

@asteriscos asteriscos self-assigned this Jul 25, 2022
Desvelao
Desvelao approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review
Code ✔️
Test ✔️

@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 6.67% ( 2432 / 36464 )
Branches 2.67% ( 754 / 28251 )
Functions 4.46% ( 398 / 8917 )
Lines 6.75% ( 2353 / 34879 )

Machi3mfl
Machi3mfl approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✅
Test ✅

@Desvelao Desvelao merged commit 72af12c into 4.3-7.10 Aug 4, 2022
@Desvelao Desvelao deleted the fix/set-hashUsername-in-xpack-without-authcontext branch August 4, 2022 13:18
github-actions bot pushed a commit that referenced this pull request Aug 4, 2022
@asteriscos @github-actions
Fix creating PDF reports in x-pack without authentication context (#4358
59ed124 
)

* Added default hashUsername to xpack without authContext

* changelog: add PR entry

Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com>
Co-authored-by: Antonio <34042064+Desvelao@users.noreply.github.com>
(cherry picked from commit 72af12c)
@github-actions github-actions bot mentioned this pull request Aug 4, 2022
Merged
Desvelao pushed a commit that referenced this pull request Aug 4, 2022
@github-actions @asteriscos
[Backport 4.3-7.16] Fix creating PDF reports in x-pack without authen…
4725831 
…tication context (#4379)

Fix creating PDF reports in x-pack without authentication context  (#4358)

* Added default hashUsername to xpack without authContext

* changelog: add PR entry

Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com>
Co-authored-by: Antonio <34042064+Desvelao@users.noreply.github.com>
(cherry picked from commit 72af12c)

Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com>
@Mayons95 Mayons95 mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Machi3mfl Machi3mfl Machi3mfl approved these changes

@Desvelao Desvelao Desvelao approved these changes

Assignees

@asteriscos asteriscos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asteriscos @Machi3mfl @Desvelao