Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Managing errors in a better way plus some improvements #439

Merged
merged 20 commits into from May 7, 2018
Merged

Managing errors in a better way plus some improvements #439

merged 20 commits into from May 7, 2018

Conversation

jesusgn90
Copy link
Contributor

@jesusgn90 jesusgn90 commented May 4, 2018 •
edited

Hello team, this pull request solves #432 among other minor things but useful.

Brief summary:

  • Standarized error output from server side
  • Drastically reduced error management logic on client side
  • Progressively applying the facade pattern when importing/exporting modules
  • Deleted unused/deprecated/useless methods both server side and client side as well
  • Optimized minor variable type usages

Best regards,
Jesús

Jesús Ángel González added 18 commits April 30, 2018 15:27
Removed unused route and its own function
8f2c371
Added new generic error response
796572b
Sanitized error responses from wazuh-api-elastic routes
31f4720
Removed unused route and its own function
6c07969
Sanitized wazuh-api error responses
c6404a0
Deleted deprecated methods
925e555
Sanitized error responses
f3fb763
Removed useless visualizations initialization
2335cb8
Deleted ruleset visualizations
42ffa7e
Not exporting ruleset visualizations any more
ebe0342
Removed useless logic for rules vis since they are no longer avalaible
7c1e209
Removed prep-error module since it's no longer needed
282a851
Optimizing error management
ed25eb7
Improve new generic error response constructor (in progress)
a9e765d
Fix typo
1aa5b60
Continue managing errors in a better way (in progress)
7c2bb41
Applying facade pattern
f046955
Modularized functions being called on resolves from each route
93ddb30
@jesusgn90 jesusgn90 added backend type/enhancement Enhancement issue labels May 4, 2018
@jesusgn90 jesusgn90 self-assigned this May 4, 2018
@jesusgn90 jesusgn90 mentioned this pull request May 4, 2018
Closed
@havidarou
Copy link
Member

LGTM! Much needed!

@havidarou havidarou merged commit 8bcf8b2 into 3.2 May 7, 2018
@havidarou havidarou deleted the 3.2-error-hardening branch May 7, 2018 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jesusgn90 jesusgn90

Labels
type/enhancement Enhancement issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jesusgn90 @havidarou