Add validation to the plugin settings #4503

Desvelao · 2022-09-13T08:31:05Z

Description

This PR:

Add:
- Plugin setting validations:
  - Create reusable methods to compose the validation of each setting
  - Frontend Settings/Configuration form:
    - Display the validation error
    - Highlight the setting with invalid input
    - Display the count of settings with an invalid value
    - Disable the save button when there is some invalid value in some setting changed
  - Backend:
    - PUT /utils/configuration
      - All settings are validated.
Test:
- useForm hook. Validate values.
- InputFrom component renders the validation errors. Generic.
- validate the value for each setting when updating from API endpoint PUT /utils/configuration

Closes #4446

Screenshots

Input's validation, invalid settings highlight, error count display, and disabled of the save button.
Warning icon added to the invalid settings, reason displayed on mouseover.

Tests

Manual tests

Scenario: Set an invalid value for the setting in Settings/Configuration form
When the user changes the input value to something invalid. This depends on each setting validation.
Then an error should appear below the input form.
And the setting should be red colored and highlighted as invalid.
And the bottom bar should display the count settings with invalid values.
And the save button should be disabled.

Scenario: Set 2 or more invalid values for the settings in Settings/Configuration form
When the user changes the input value of 2 or more settings to invalid values. This depends on each setting validation.
Then an error should appear below the input form for each setting.
And the settings should be red colored and highlighted as invalid.
And the bottom bar should display the count settings with invalid values.
And the save button should be disabled.

Scenario: Set a valid value for the setting in Settings/Configuration form
When the user changes the input value to a valid value. This depends on each setting validation.
Then it should not appear as a validation error below the input.

Scenario: Send invalid values to update the plugin configuration through the plugin API endpoint
When the user sends (using any rest client) a request to PUT /utils/configuration with one or more settings, where at least one of them has an invalid value.
Then it should reply with a bad request displaying the validation error.

Automatic tests

server/routes/wazuh-utils/wazuh-utils.test.ts
public/components/common/form/hooks.test.tsx
public/components/common/form/index.test.tsx
common/plugin-settings.test.ts

Run all PR tests

yarn test:jest server/routes/wazuh-utils/wazuh-utils.test.ts public/components/common/form/hooks.test.tsx public/components/common/form/index.test.tsx common/plugin-settings.test.ts

Create the plugin setting schema Define the current plugin settings Remove refactored code

…onstants

Use dynamically the definition of the plugin settings

Add new hooks to manage when a input value or form has changed Add new inputs components

Refactor Header, BottomBar, Configuration components Remove deprecated files

Changed the endpoint that updating the plugin setting to support multiple settings at the same time Refactor the getConfiguration service. Split the logic to: - Read the file and transform to JSON - Obfuscate the password key of the host configuration

Create services to validate Add the validation to the plugin settings

endpoint

`Settings/Configuration`

…wazuh/wazuh-kibana-app into feat/settings-validation

…n` to control the global state of the form

…wazuh/wazuh-kibana-app into feat/settings-validation

…s changed

…wazuh/wazuh-kibana-app into feat/settings-validation

Desvelao · 2022-09-19T13:38:45Z

Fixed some settings validation errors
Updated the development branch with the last changes of the base branch

AlexRuiz7

LGTM

yenienserrano

LGTM

Mayons95 · 2022-10-26T13:06:40Z

TR: ✔️

Screencast.from.26-10-22.10.02.57.webm

Screencast.from.26-10-22.09.37.23.webm

Mayons95

LGTM

github-actions · 2022-10-26T14:54:18Z

Code coverage (Jest)	%	values
Statements	7.93%	( 2897 / 36516 )
Branches	3.57%	( 1005 / 28112 )
Functions	6.8%	( 615 / 9038 )
Lines	7.99%	( 2792 / 34947 )

Mayons95

TR: ✔️
LGTM

yenienserrano

LGTM

github-actions · 2022-10-27T07:12:39Z

The backport to 4.4-2.3-wzd failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-2.3-wzd 4.4-2.3-wzd
# Navigate to the new working tree
cd .worktrees/backport-4.4-2.3-wzd
# Create a new branch
git switch --create backport-4503-to-4.4-2.3-wzd
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5c0c413f7357afe7388af748007fec62c25dd9a0
# Push it to GitHub
git push --set-upstream origin backport-4503-to-4.4-2.3-wzd
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-2.3-wzd

Then, create a pull request where the base branch is 4.4-2.3-wzd and the compare/head branch is backport-4503-to-4.4-2.3-wzd.

* feat(settings): centralize the plugin settings Create the plugin setting schema Define the current plugin settings Remove refactored code * feat(settings): add setting services and replaced the references to constants * feat(settings): refactor the content of the default configuration file Use dynamically the definition of the plugin settings * feat(inputs): create new inputs components Add new hooks to manage when a input value or form has changed Add new inputs components * feat(configuration): refactor the form of Settings/Configuration Refactor Header, BottomBar, Configuration components Remove deprecated files * feat(settings): support updating multiple setting at the same time Changed the endpoint that updating the plugin setting to support multiple settings at the same time Refactor the getConfiguration service. Split the logic to: - Read the file and transform to JSON - Obfuscate the password key of the host configuration * feat: add validation to the plugin settings Create services to validate Add the validation to the plugin settings * feat(validation): add validation to the `PUT /utils/configuration` endpoint * feat(validation): add validation to the configuration form in `Settings/Configuration` * feat(validatio): remove no used import * clean: remove not used code * fix: fixed category name in `Settings/Configuration` * fix(settings): Fix accessing to `validate` of undefined error * fix(settings): fixed error due to missing service * fix(settings): refactor the form and inputs of `Settings/Configuration` to control the global state of the form * fix: add value transformation for the form inputs and output of fields changed * fix: Fixed some settings validation * fix(settings): fixed validation of literals * fix(settings): removed unused import * fix(settings): renamed properties related to transform the value of the input * feat(settings): add description to the plugin setting definition properties * fix(settings): fix getConfiguration service when the configuration file has no `hosts` entry * fix(settings): Fixed error when do changes of the `useForm` hook an rename methods of this * tests(settings): add test related to the plugin settings and its configuration from the UI * feat(settings): rename plugin setting options of type select to match its type * feat(settings): add plugin settings services and enhance the description of the plugin settings in default configuration file and UI * tests(input-form): update tests of InputForm component * test(configuration-file): add tests of the default configuration file * feat(settings): remove `extensions.mitre` plugin setting * test(settings): add test to validate the plugin setting when updating it through PUT /utils/configuration fix some plugin settings validation * feat(settings): add documentation to some setting services and test some of them * fix: fixed documentation of setting service * doc(settings): move the documentation of the plugin setting properties * fix(settings): rename some plugin setting properties because of request changes - Rename plugin setting properties: - `default` to `defaultValue` - `defaultHidden` to `defaultValueIfNotSet` - `configurableFile` to `isConfigurableFromFile` - configurableUI` to `isConfigurableFromUI` - `requireHealthCheck` to `requiresRunningHealthCheck` - `requireReload` to `requiresReloadingBrowserTab` - `requireRestart` to `requiresRestartingPluginPlatform` - Fix tests * tests: fix tests of InputForm component * fix: response properties when saving the configuration * fix(settings): fix validation plugin settings value in the UI * fix(settings): fix validation of numbers * fix(settings): fix validation of numbers * test(settings): Add tests related to validation for the `useForm` hook and the `InputForm` component * fix(settings): fix displaying toast to run the healthcheck when saving the configuration * Added category sorting + description + docs link * Added settings sorting within their category * Fixed constant types definition * Checks if localCompare exists validation * fix(settings): fixed plugin setting description doesn't display the minimum number value when it is falsy (0) * fix(settings): fix setting type of `wazuh.monitoring.replicas` and limit the valid number for the number input * feat(settins): add plugin settings category description * fix(settings): fix a problem comparing the initial and current value for the plugin settings of the `number` type * fix(settings): fix typo in setting description * feat(settings): enhance the validation of plugin settings related to indices or index patterns taking in account the supported characters * feat(settings): add validation of setting values in the inputs * fix(tests): format tables of the tests * Fix small typo * fix(settings): fix a typo in a toast related to modify the plugin settings from UI * Changed Custom Branding documentation link * Merge centralize plugin settings PR * Delete unused imports * fix(settings): fix a problem with the useForm hook * fix(settings): refactor the settings validation function to a class and rename the file * feat(settings): add check for integer numbers and adapt the affected settings * Fix semi-colon error * changelog: add entries to changelog * Change validation error for inputs that don't allow whitespaces Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com> Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 5c0c413)

Add validation to the plugin settings (#4503) * feat(settings): centralize the plugin settings Create the plugin setting schema Define the current plugin settings Remove refactored code * feat(settings): add setting services and replaced the references to constants * feat(settings): refactor the content of the default configuration file Use dynamically the definition of the plugin settings * feat(inputs): create new inputs components Add new hooks to manage when a input value or form has changed Add new inputs components * feat(configuration): refactor the form of Settings/Configuration Refactor Header, BottomBar, Configuration components Remove deprecated files * feat(settings): support updating multiple setting at the same time Changed the endpoint that updating the plugin setting to support multiple settings at the same time Refactor the getConfiguration service. Split the logic to: - Read the file and transform to JSON - Obfuscate the password key of the host configuration * feat: add validation to the plugin settings Create services to validate Add the validation to the plugin settings * feat(validation): add validation to the `PUT /utils/configuration` endpoint * feat(validation): add validation to the configuration form in `Settings/Configuration` * feat(validatio): remove no used import * clean: remove not used code * fix: fixed category name in `Settings/Configuration` * fix(settings): Fix accessing to `validate` of undefined error * fix(settings): fixed error due to missing service * fix(settings): refactor the form and inputs of `Settings/Configuration` to control the global state of the form * fix: add value transformation for the form inputs and output of fields changed * fix: Fixed some settings validation * fix(settings): fixed validation of literals * fix(settings): removed unused import * fix(settings): renamed properties related to transform the value of the input * feat(settings): add description to the plugin setting definition properties * fix(settings): fix getConfiguration service when the configuration file has no `hosts` entry * fix(settings): Fixed error when do changes of the `useForm` hook an rename methods of this * tests(settings): add test related to the plugin settings and its configuration from the UI * feat(settings): rename plugin setting options of type select to match its type * feat(settings): add plugin settings services and enhance the description of the plugin settings in default configuration file and UI * tests(input-form): update tests of InputForm component * test(configuration-file): add tests of the default configuration file * feat(settings): remove `extensions.mitre` plugin setting * test(settings): add test to validate the plugin setting when updating it through PUT /utils/configuration fix some plugin settings validation * feat(settings): add documentation to some setting services and test some of them * fix: fixed documentation of setting service * doc(settings): move the documentation of the plugin setting properties * fix(settings): rename some plugin setting properties because of request changes - Rename plugin setting properties: - `default` to `defaultValue` - `defaultHidden` to `defaultValueIfNotSet` - `configurableFile` to `isConfigurableFromFile` - configurableUI` to `isConfigurableFromUI` - `requireHealthCheck` to `requiresRunningHealthCheck` - `requireReload` to `requiresReloadingBrowserTab` - `requireRestart` to `requiresRestartingPluginPlatform` - Fix tests * tests: fix tests of InputForm component * fix: response properties when saving the configuration * fix(settings): fix validation plugin settings value in the UI * fix(settings): fix validation of numbers * fix(settings): fix validation of numbers * test(settings): Add tests related to validation for the `useForm` hook and the `InputForm` component * fix(settings): fix displaying toast to run the healthcheck when saving the configuration * Added category sorting + description + docs link * Added settings sorting within their category * Fixed constant types definition * Checks if localCompare exists validation * fix(settings): fixed plugin setting description doesn't display the minimum number value when it is falsy (0) * fix(settings): fix setting type of `wazuh.monitoring.replicas` and limit the valid number for the number input * feat(settins): add plugin settings category description * fix(settings): fix a problem comparing the initial and current value for the plugin settings of the `number` type * fix(settings): fix typo in setting description * feat(settings): enhance the validation of plugin settings related to indices or index patterns taking in account the supported characters * feat(settings): add validation of setting values in the inputs * fix(tests): format tables of the tests * Fix small typo * fix(settings): fix a typo in a toast related to modify the plugin settings from UI * Changed Custom Branding documentation link * Merge centralize plugin settings PR * Delete unused imports * fix(settings): fix a problem with the useForm hook * fix(settings): refactor the settings validation function to a class and rename the file * feat(settings): add check for integer numbers and adapt the affected settings * Fix semi-colon error * changelog: add entries to changelog * Change validation error for inputs that don't allow whitespaces Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com> Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 5c0c413) Co-authored-by: Antonio <34042064+Desvelao@users.noreply.github.com>

* feat(settings): centralize the plugin settings Create the plugin setting schema Define the current plugin settings Remove refactored code * feat(settings): add setting services and replaced the references to constants * feat(settings): refactor the content of the default configuration file Use dynamically the definition of the plugin settings * feat(inputs): create new inputs components Add new hooks to manage when a input value or form has changed Add new inputs components * feat(configuration): refactor the form of Settings/Configuration Refactor Header, BottomBar, Configuration components Remove deprecated files * feat(settings): support updating multiple setting at the same time Changed the endpoint that updating the plugin setting to support multiple settings at the same time Refactor the getConfiguration service. Split the logic to: - Read the file and transform to JSON - Obfuscate the password key of the host configuration * feat: add validation to the plugin settings Create services to validate Add the validation to the plugin settings * feat(validation): add validation to the `PUT /utils/configuration` endpoint * feat(validation): add validation to the configuration form in `Settings/Configuration` * feat(validatio): remove no used import * clean: remove not used code * fix: fixed category name in `Settings/Configuration` * fix(settings): Fix accessing to `validate` of undefined error * fix(settings): fixed error due to missing service * fix(settings): refactor the form and inputs of `Settings/Configuration` to control the global state of the form * fix: add value transformation for the form inputs and output of fields changed * fix: Fixed some settings validation * fix(settings): fixed validation of literals * fix(settings): removed unused import * fix(settings): renamed properties related to transform the value of the input * feat(settings): add description to the plugin setting definition properties * fix(settings): fix getConfiguration service when the configuration file has no `hosts` entry * fix(settings): Fixed error when do changes of the `useForm` hook an rename methods of this * tests(settings): add test related to the plugin settings and its configuration from the UI * feat(settings): rename plugin setting options of type select to match its type * feat(settings): add plugin settings services and enhance the description of the plugin settings in default configuration file and UI * tests(input-form): update tests of InputForm component * test(configuration-file): add tests of the default configuration file * feat(settings): remove `extensions.mitre` plugin setting * test(settings): add test to validate the plugin setting when updating it through PUT /utils/configuration fix some plugin settings validation * feat(settings): add documentation to some setting services and test some of them * fix: fixed documentation of setting service * doc(settings): move the documentation of the plugin setting properties * fix(settings): rename some plugin setting properties because of request changes - Rename plugin setting properties: - `default` to `defaultValue` - `defaultHidden` to `defaultValueIfNotSet` - `configurableFile` to `isConfigurableFromFile` - configurableUI` to `isConfigurableFromUI` - `requireHealthCheck` to `requiresRunningHealthCheck` - `requireReload` to `requiresReloadingBrowserTab` - `requireRestart` to `requiresRestartingPluginPlatform` - Fix tests * tests: fix tests of InputForm component * fix: response properties when saving the configuration * fix(settings): fix validation plugin settings value in the UI * fix(settings): fix validation of numbers * fix(settings): fix validation of numbers * test(settings): Add tests related to validation for the `useForm` hook and the `InputForm` component * fix(settings): fix displaying toast to run the healthcheck when saving the configuration * Added category sorting + description + docs link * Added settings sorting within their category * Fixed constant types definition * Checks if localCompare exists validation * fix(settings): fixed plugin setting description doesn't display the minimum number value when it is falsy (0) * fix(settings): fix setting type of `wazuh.monitoring.replicas` and limit the valid number for the number input * feat(settins): add plugin settings category description * fix(settings): fix a problem comparing the initial and current value for the plugin settings of the `number` type * fix(settings): fix typo in setting description * feat(settings): enhance the validation of plugin settings related to indices or index patterns taking in account the supported characters * feat(settings): add validation of setting values in the inputs * fix(tests): format tables of the tests * Fix small typo * fix(settings): fix a typo in a toast related to modify the plugin settings from UI * Changed Custom Branding documentation link * Merge centralize plugin settings PR * Delete unused imports * fix(settings): fix a problem with the useForm hook * fix(settings): refactor the settings validation function to a class and rename the file * feat(settings): add check for integer numbers and adapt the affected settings * Fix semi-colon error * changelog: add entries to changelog * Change validation error for inputs that don't allow whitespaces Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com> Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 5c0c413)

Add validation to the plugin settings (#4503) * feat(settings): centralize the plugin settings Create the plugin setting schema Define the current plugin settings Remove refactored code * feat(settings): add setting services and replaced the references to constants * feat(settings): refactor the content of the default configuration file Use dynamically the definition of the plugin settings * feat(inputs): create new inputs components Add new hooks to manage when a input value or form has changed Add new inputs components * feat(configuration): refactor the form of Settings/Configuration Refactor Header, BottomBar, Configuration components Remove deprecated files * feat(settings): support updating multiple setting at the same time Changed the endpoint that updating the plugin setting to support multiple settings at the same time Refactor the getConfiguration service. Split the logic to: - Read the file and transform to JSON - Obfuscate the password key of the host configuration * feat: add validation to the plugin settings Create services to validate Add the validation to the plugin settings * feat(validation): add validation to the `PUT /utils/configuration` endpoint * feat(validation): add validation to the configuration form in `Settings/Configuration` * feat(validatio): remove no used import * clean: remove not used code * fix: fixed category name in `Settings/Configuration` * fix(settings): Fix accessing to `validate` of undefined error * fix(settings): fixed error due to missing service * fix(settings): refactor the form and inputs of `Settings/Configuration` to control the global state of the form * fix: add value transformation for the form inputs and output of fields changed * fix: Fixed some settings validation * fix(settings): fixed validation of literals * fix(settings): removed unused import * fix(settings): renamed properties related to transform the value of the input * feat(settings): add description to the plugin setting definition properties * fix(settings): fix getConfiguration service when the configuration file has no `hosts` entry * fix(settings): Fixed error when do changes of the `useForm` hook an rename methods of this * tests(settings): add test related to the plugin settings and its configuration from the UI * feat(settings): rename plugin setting options of type select to match its type * feat(settings): add plugin settings services and enhance the description of the plugin settings in default configuration file and UI * tests(input-form): update tests of InputForm component * test(configuration-file): add tests of the default configuration file * feat(settings): remove `extensions.mitre` plugin setting * test(settings): add test to validate the plugin setting when updating it through PUT /utils/configuration fix some plugin settings validation * feat(settings): add documentation to some setting services and test some of them * fix: fixed documentation of setting service * doc(settings): move the documentation of the plugin setting properties * fix(settings): rename some plugin setting properties because of request changes - Rename plugin setting properties: - `default` to `defaultValue` - `defaultHidden` to `defaultValueIfNotSet` - `configurableFile` to `isConfigurableFromFile` - configurableUI` to `isConfigurableFromUI` - `requireHealthCheck` to `requiresRunningHealthCheck` - `requireReload` to `requiresReloadingBrowserTab` - `requireRestart` to `requiresRestartingPluginPlatform` - Fix tests * tests: fix tests of InputForm component * fix: response properties when saving the configuration * fix(settings): fix validation plugin settings value in the UI * fix(settings): fix validation of numbers * fix(settings): fix validation of numbers * test(settings): Add tests related to validation for the `useForm` hook and the `InputForm` component * fix(settings): fix displaying toast to run the healthcheck when saving the configuration * Added category sorting + description + docs link * Added settings sorting within their category * Fixed constant types definition * Checks if localCompare exists validation * fix(settings): fixed plugin setting description doesn't display the minimum number value when it is falsy (0) * fix(settings): fix setting type of `wazuh.monitoring.replicas` and limit the valid number for the number input * feat(settins): add plugin settings category description * fix(settings): fix a problem comparing the initial and current value for the plugin settings of the `number` type * fix(settings): fix typo in setting description * feat(settings): enhance the validation of plugin settings related to indices or index patterns taking in account the supported characters * feat(settings): add validation of setting values in the inputs * fix(tests): format tables of the tests * Fix small typo * fix(settings): fix a typo in a toast related to modify the plugin settings from UI * Changed Custom Branding documentation link * Merge centralize plugin settings PR * Delete unused imports * fix(settings): fix a problem with the useForm hook * fix(settings): refactor the settings validation function to a class and rename the file * feat(settings): add check for integer numbers and adapt the affected settings * Fix semi-colon error * changelog: add entries to changelog * Change validation error for inputs that don't allow whitespaces Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com> Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 5c0c413)

Desvelao added 9 commits September 13, 2022 08:08

feat(settings): centralize the plugin settings

918418f

Create the plugin setting schema Define the current plugin settings Remove refactored code

feat(settings): add setting services and replaced the references to c…

de48a49

…onstants

feat(settings): refactor the content of the default configuration file

c25a1a0

Use dynamically the definition of the plugin settings

feat(inputs): create new inputs components

ffdb2d7

Add new hooks to manage when a input value or form has changed Add new inputs components

feat(configuration): refactor the form of Settings/Configuration

e7cd9b0

Refactor Header, BottomBar, Configuration components Remove deprecated files

feat: add validation to the plugin settings

9a2b9ba

Create services to validate Add the validation to the plugin settings

feat(validation): add validation to the PUT /utils/configuration

f530d7a

endpoint

feat(validation): add validation to the configuration form in

b6a7220

`Settings/Configuration`

Desvelao self-assigned this Sep 13, 2022

Desvelao linked an issue Sep 13, 2022 that may be closed by this pull request

Custom branding: add validation to the plugin's settings #4446

Closed

11 tasks

Desvelao added the type/enhancement Enhancement issue label Sep 13, 2022

Desvelao added 8 commits September 13, 2022 10:34

feat(validatio): remove no used import

134ffd8

clean: remove not used code

9b977e6

Merge branch 'feat/centralize-plugin-settings' of https://github.com/…

a984a7c

…wazuh/wazuh-kibana-app into feat/settings-validation

fix: fixed category name in Settings/Configuration

17ad2e8

fix(settings): Fix accessing to validate of undefined error

ce4652e

Merge branch 'feat/centralize-plugin-settings' of https://github.com/…

23b925d

…wazuh/wazuh-kibana-app into feat/settings-validation

fix(settings): fixed error due to missing service

a454dd8

Merge branch 'feat/centralize-plugin-settings' of https://github.com/…

a56e9d1

…wazuh/wazuh-kibana-app into feat/settings-validation

Desvelao marked this pull request as draft September 13, 2022 12:03

Desvelao mentioned this pull request Sep 13, 2022

Define the plugin settings schema, add customization of reports #4461

Closed

Desvelao added 7 commits September 16, 2022 14:16

fix(settings): refactor the form and inputs of `Settings/Configuratio…

5d68615

…n` to control the global state of the form

Merge branch 'feat/centralize-plugin-settings' of https://github.com/…

ef8d6ad

…wazuh/wazuh-kibana-app into feat/settings-validation

fix: add value transformation for the form inputs and output of field…

cf15ef8

…s changed

Merge branch 'feat/centralize-plugin-settings' of https://github.com/…

2597cf6

…wazuh/wazuh-kibana-app into feat/settings-validation

fix: Fixed some settings validation

951812e

fix(settings): fixed validation of literals

e0a057e

fix(settings): removed unused import

9699336

AlexRuiz7 previously approved these changes Oct 25, 2022

View reviewed changes

yenienserrano previously approved these changes Oct 25, 2022

View reviewed changes

Merge branch '4.4-7.10' into feat/settings-validation

beb02b5

AlexRuiz7 requested a review from Mayons95 October 26, 2022 10:33

Mayons95 previously approved these changes Oct 26, 2022

View reviewed changes

Change validation error for inputs that don't allow whitespaces

77fcd93

AlexRuiz7 dismissed stale reviews from Mayons95, yenienserrano, and themself via 77fcd93 October 26, 2022 14:48

Merge branch '4.4-7.10' into feat/settings-validation

460deec

AlexRuiz7 approved these changes Oct 26, 2022

View reviewed changes

Mayons95 self-requested a review October 26, 2022 15:16

Mayons95 approved these changes Oct 26, 2022

View reviewed changes

yenienserrano approved these changes Oct 26, 2022

View reviewed changes

Desvelao merged commit 5c0c413 into 4.4-7.10 Oct 27, 2022

Desvelao deleted the feat/settings-validation branch October 27, 2022 07:12

github-actions bot mentioned this pull request Oct 27, 2022

[Backport 4.4-7.16] Add validation to the plugin settings #4768

Merged

Desvelao mentioned this pull request Oct 27, 2022

[Backport 4.4-2.3-wzd] Add validation to the plugin settings #4769

Merged

This was referenced Nov 3, 2022

Custom branding: 7.17 - QA test #4801

Closed

Custom branding: WzD - QA test #4802

Closed

Mayons95 mentioned this pull request Nov 21, 2022

Release 4.4.0 - Alpha 1 - Kibana UI regression testing #4895

Closed

7 tasks

Mayons95 mentioned this pull request Dec 7, 2022

Test the plugin in Wazuh Dashboard #4740

Closed

1 task

Desvelao mentioned this pull request Dec 20, 2022

Fix vulnerabilities in dependencies #5014

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add validation to the plugin settings #4503

Add validation to the plugin settings #4503

Desvelao commented Sep 13, 2022 •

edited

Loading

Desvelao commented Sep 19, 2022 •

edited by AlexRuiz7

Loading

AlexRuiz7 left a comment

yenienserrano left a comment

Mayons95 commented Oct 26, 2022

Mayons95 left a comment

github-actions bot commented Oct 26, 2022

Mayons95 left a comment

yenienserrano left a comment

github-actions bot commented Oct 27, 2022

Add validation to the plugin settings #4503

Add validation to the plugin settings #4503

Conversation

Desvelao commented Sep 13, 2022 • edited Loading

Description

Screenshots

Tests

Manual tests

Automatic tests

Desvelao commented Sep 19, 2022 • edited by AlexRuiz7 Loading

AlexRuiz7 left a comment

Choose a reason for hiding this comment

yenienserrano left a comment

Choose a reason for hiding this comment

Mayons95 commented Oct 26, 2022

Mayons95 left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 26, 2022

Mayons95 left a comment

Choose a reason for hiding this comment

yenienserrano left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 27, 2022

Desvelao commented Sep 13, 2022 •

edited

Loading

Desvelao commented Sep 19, 2022 •

edited by AlexRuiz7

Loading