Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello team, this pull request fix an inconsistency situation whenever we add a new extension to the App which is enabled by default.
The problem comes for old App packages, whose already have
.wazuh
documents created without the new extension. If the new extension is enabled on theconfig.yml
file the App thinks it is disabled.With this pull request we are ensuring we have all the .wazuh documents with the proper extensions updated. If the document already had a extension, it is ignored, otherwise we update it adding the new extension using the default value.
To check the extensions the function reads the
config.yml
and compares it withdefault-ext.js
extensions. If it's not found conconfig.yml
, looks for it ondefault-ext.js
. Finally looks if the current.wazuh
document being analyzed has that extension, if it hasn't got it, the extension is added to its extensions with the default value, otherwise that extension is skipped for that.wazuh
document.From now and onwards we need to explicitly add any new extension to
default-ext.js
with its default value.This PR fixes #455
Regards,
Jesús