Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix discover to panels preserve extra filters on filter-bar #459

Merged
merged 1 commit into from
May 16, 2018

Conversation

jesusgn90
Copy link
Contributor

Hello team, this pull request fix a little non-desired behaviour whenever a user has a custom non-pinned filter on any overview/agent tab and goes to Discover sub tab then come back to Panels sub tab.

The trick here was to add a boolean variable to check if I'm on the same tab but come from Discover or if indeed I'm new for this tab. If localChange is true it means we are on that situation, otherwise it'll be false.

Finally, and using localChange, we can decide what to do on the right way:

$state.filters = localChange ? $state.filters : [];

Best regards,
Jesús

@jesusgn90 jesusgn90 self-assigned this May 16, 2018
@havidarou
Copy link
Member

LGTM!

@havidarou havidarou merged commit 848ec59 into 3.2 May 16, 2018
@havidarou havidarou deleted the 3.2-fix-disc-to-panels branch May 16, 2018 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants