Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the rows limit in the textarea input #4798

Merged
merged 1 commit into from Nov 3, 2022
Merged

Fix the rows limit in the textarea input #4798

merged 1 commit into from Nov 3, 2022

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Nov 3, 2022 •
edited by AlexRuiz7

Description

This PR fixes the rows limit of the textarea input

Issues Resolved

#4426

Evidence

image

Test

Check that the text areas' height is limited.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Desvelao Desvelao requested a review from a team as a code owner November 3, 2022 08:42
@Desvelao Desvelao self-assigned this Nov 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

Code coverage (Jest) % values
Statements 8.31% ( 3044 / 36650 )
Branches 3.9% ( 1102 / 28226 )
Functions 7.29% ( 662 / 9084 )
Lines 8.36% ( 2933 / 35080 )

@AlexRuiz7 AlexRuiz7 merged commit 8163554 into 4.4-7.10 Nov 3, 2022
@AlexRuiz7 AlexRuiz7 deleted the fix/settings-input-textarea-rows branch November 3, 2022 09:31
github-actions bot pushed a commit that referenced this pull request Nov 3, 2022
@Desvelao @github-actions
Fix the rows limit in the textarea input (#4798)
c03b726 
fix: limit the rows of the textarea input
(cherry picked from commit 8163554)
This was referenced Nov 3, 2022
Merged
Merged
github-actions bot pushed a commit that referenced this pull request Nov 3, 2022
@Desvelao @github-actions
Fix the rows limit in the textarea input (#4798)
fa7a1f2 
fix: limit the rows of the textarea input
(cherry picked from commit 8163554)
AlexRuiz7 pushed a commit that referenced this pull request Nov 3, 2022
@github-actions @Desvelao
[Backport 4.4-7.16] Fix the rows limit in the textarea input (#4799)
fef7524 
Fix the rows limit in the textarea input (#4798)

fix: limit the rows of the textarea input
(cherry picked from commit 8163554)

Co-authored-by: Antonio <34042064+Desvelao@users.noreply.github.com>
AlexRuiz7 pushed a commit that referenced this pull request Nov 3, 2022
@github-actions @Desvelao
[Backport 4.4-2.3-wzd] Fix the rows limit in the textarea input (#4800)
2d9e1c9 
Fix the rows limit in the textarea input (#4798)

fix: limit the rows of the textarea input
(cherry picked from commit 8163554)

Co-authored-by: Antonio <34042064+Desvelao@users.noreply.github.com>
@Desvelao Desvelao mentioned this pull request Dec 20, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexRuiz7 AlexRuiz7 AlexRuiz7 approved these changes

Assignees

@Desvelao Desvelao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Desvelao @AlexRuiz7