Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added data-test-subj create policy #4873

Merged
merged 2 commits into from
Nov 16, 2022

Conversation

Machi3mfl
Copy link
Member

@Machi3mfl Machi3mfl commented Nov 16, 2022

Description

Added new data-test-subj in Create policy section

Closes #4872

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Machi3mfl Machi3mfl requested a review from a team as a code owner November 16, 2022 16:25
Copy link
Contributor

@Mayons95 Mayons95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Machi3mfl Machi3mfl linked an issue Nov 16, 2022 that may be closed by this pull request
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.69% ( 3209 / 36947 )
Branches 4.43% ( 1271 / 28675 )
Functions 7.59% ( 696 / 9165 )
Lines 8.75% ( 3096 / 35367 )

@Machi3mfl Machi3mfl merged commit b9c4645 into 4.4-7.10 Nov 16, 2022
@Machi3mfl Machi3mfl deleted the feature/4872-added-datatestsubj-automation branch November 16, 2022 16:34
@github-actions
Copy link
Contributor

The backport to 4.4-7.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-7.16 4.4-7.16
# Navigate to the new working tree
cd .worktrees/backport-4.4-7.16
# Create a new branch
git switch --create backport-4873-to-4.4-7.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b9c464565a2273fce38743a36b7c652680419efc
# Push it to GitHub
git push --set-upstream origin backport-4873-to-4.4-7.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-7.16

Then, create a pull request where the base branch is 4.4-7.16 and the compare/head branch is backport-4873-to-4.4-7.16.

@github-actions
Copy link
Contributor

The backport to 4.4-2.3-wzd failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-2.3-wzd 4.4-2.3-wzd
# Navigate to the new working tree
cd .worktrees/backport-4.4-2.3-wzd
# Create a new branch
git switch --create backport-4873-to-4.4-2.3-wzd
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b9c464565a2273fce38743a36b7c652680419efc
# Push it to GitHub
git push --set-upstream origin backport-4873-to-4.4-2.3-wzd
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-2.3-wzd

Then, create a pull request where the base branch is 4.4-2.3-wzd and the compare/head branch is backport-4873-to-4.4-2.3-wzd.

Machi3mfl added a commit that referenced this pull request Nov 16, 2022
* Added data-test-subj create policy

* Updated CHANGELOG

(cherry picked from commit b9c4645)
Machi3mfl added a commit that referenced this pull request Nov 16, 2022
* Added data-test-subj create policy

* Updated CHANGELOG

(cherry picked from commit b9c4645)
Machi3mfl added a commit that referenced this pull request Nov 16, 2022
* Added data-test-subj create policy

* Updated CHANGELOG

(cherry picked from commit b9c4645)
Machi3mfl added a commit that referenced this pull request Nov 16, 2022
)

Added data-test-subj create policy (#4873)

* Added data-test-subj create policy

* Updated CHANGELOG

(cherry picked from commit b9c4645)
Machi3mfl added a commit that referenced this pull request Nov 16, 2022
Added data-test-subj create policy (#4873)

* Added data-test-subj create policy

* Updated CHANGELOG

(cherry picked from commit b9c4645)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding data-test-subj for Automation
2 participants