Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deploy new agent section #4933

Merged
merged 38 commits into from Dec 22, 2022
Merged

Conversation

chantal-kelm
Copy link
Member

@chantal-kelm chantal-kelm commented Nov 29, 2022

Description

  • Fixed the way macOS versions and architectures were displayed.
  • Fixed the way agents were displayed.
  • Fixed the way Ubuntu versions were displayed.
  • Added extra steps message and new command for Windows XP and Windows Server 2008
  • Added Alpine agent with all its steps.
  • Windows command fixed
  • CI/CD has updated all installation commands, we have also updated them in our code.

Issues Resolved

#4931

Evidence

Grabacion.de.pantalla.2022-11-30.a.la.s.10.46.16.mov

Steps to test

  • Click on agents
  • Click on deploy new agent
  • Check that the information shown is correct.
  • Check that the information shown for the windows agent is the one shown in this comment
  • Check that the information shown for the alpine agent is the same as the one shown in this comment

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@chantal-kelm chantal-kelm self-assigned this Nov 29, 2022
@chantal-kelm chantal-kelm linked an issue Nov 29, 2022 that may be closed by this pull request
@chantal-kelm chantal-kelm marked this pull request as ready for review November 30, 2022 13:33
@chantal-kelm chantal-kelm requested a review from a team as a code owner November 30, 2022 13:33
@Tostti Tostti mentioned this pull request Nov 30, 2022
6 tasks
@Tostti Tostti linked an issue Nov 30, 2022 that may be closed by this pull request
@AlexRuiz7 AlexRuiz7 changed the title 4931 fix section deploy new agent Fix deploy new agent section Nov 30, 2022
@chantal-kelm
Copy link
Member Author

4.4-2.3-wzd
4.4-7.16

@chantal-kelm chantal-kelm marked this pull request as ready for review December 21, 2022 12:40
@chantal-kelm chantal-kelm marked this pull request as draft December 21, 2022 12:43
@chantal-kelm chantal-kelm marked this pull request as ready for review December 22, 2022 11:40
Tostti
Tostti previously approved these changes Dec 22, 2022
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
TEST: ✔️

image

LGTM

@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.74% ( 3234 / 37003 )
Branches 4.57% ( 1314 / 28746 )
Functions 7.59% ( 696 / 9166 )
Lines 8.81% ( 3121 / 35430 )

Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

image

@chantal-kelm chantal-kelm merged commit 549edd0 into 4.4-7.10 Dec 22, 2022
@chantal-kelm chantal-kelm deleted the 4931-fix-section-deploy-new-agent branch December 22, 2022 13:06
@github-actions
Copy link
Contributor

The backport to 4.4-7.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-7.16 4.4-7.16
# Navigate to the new working tree
cd .worktrees/backport-4.4-7.16
# Create a new branch
git switch --create backport-4933-to-4.4-7.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 549edd0e1cc989c8f97056aff2185a9485108658
# Push it to GitHub
git push --set-upstream origin backport-4933-to-4.4-7.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-7.16

Then, create a pull request where the base branch is 4.4-7.16 and the compare/head branch is backport-4933-to-4.4-7.16.

@github-actions
Copy link
Contributor

The backport to 4.4-2.4-wzd failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-2.4-wzd 4.4-2.4-wzd
# Navigate to the new working tree
cd .worktrees/backport-4.4-2.4-wzd
# Create a new branch
git switch --create backport-4933-to-4.4-2.4-wzd
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 549edd0e1cc989c8f97056aff2185a9485108658
# Push it to GitHub
git push --set-upstream origin backport-4933-to-4.4-2.4-wzd
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-2.4-wzd

Then, create a pull request where the base branch is 4.4-2.4-wzd and the compare/head branch is backport-4933-to-4.4-2.4-wzd.

chantal-kelm added a commit that referenced this pull request Dec 22, 2022
* accordion and alpine os

* changes

* changes

* changes

* changes

* alpine versions commands

* commands for alpine and architecture macos

* message install and start alpine

* CHANGELOG

* command debian

* command raspbian

* Added link for additional steps to alpine os and changelog

* clear code

* clean code

* fixed windows command

* deploy new agent section: command fixed for solaris

* Fix the agent installation command for macOS (#4968)

* Fixed the agent installation command for macOS

* CHANGELOG

* Update CHANGELOG.md

* Fix agent deployment instructions for HP-UX and Solaris (#4943)

* removing auto-deploy variables in hp and solaris

* hide wazuh server address sections, assign group and assign name to agent when os is hp or solaris

* update hp command

* removing auto-deploy variables in alpine

* move message additional installation steps

* links and messages os

* changelog

* red hat, centos and windows commands fixed

* Deploy new agent section: change the commands for all os

* Deploy new agent section: change commands for all os

* clean code

* update commands

* Deploy new agents: Update commands

* Deploy new agents: Update commands

* comand windows

* oracleLinux command

* warningcOMAND

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit 549edd0)
chantal-kelm added a commit that referenced this pull request Dec 22, 2022
* Fix deploy new agent section (#4933)

* accordion and alpine os

* changes

* changes

* changes

* changes

* alpine versions commands

* commands for alpine and architecture macos

* message install and start alpine

* CHANGELOG

* command debian

* command raspbian

* Added link for additional steps to alpine os and changelog

* clear code

* clean code

* fixed windows command

* deploy new agent section: command fixed for solaris

* Fix the agent installation command for macOS (#4968)

* Fixed the agent installation command for macOS

* CHANGELOG

* Update CHANGELOG.md

* Fix agent deployment instructions for HP-UX and Solaris (#4943)

* removing auto-deploy variables in hp and solaris

* hide wazuh server address sections, assign group and assign name to agent when os is hp or solaris

* update hp command

* removing auto-deploy variables in alpine

* move message additional installation steps

* links and messages os

* changelog

* red hat, centos and windows commands fixed

* Deploy new agent section: change the commands for all os

* Deploy new agent section: change commands for all os

* clean code

* update commands

* Deploy new agents: Update commands

* Deploy new agents: Update commands

* comand windows

* oracleLinux command

* warningcOMAND

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit 549edd0)

* styles

* hp command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix section deploy new agent, add alpine agent
6 participants