Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix commands in the deploy new agent section #4962

Merged
merged 6 commits into from Dec 19, 2022
Merged

Fix commands in the deploy new agent section #4962

merged 6 commits into from Dec 19, 2022

Conversation

chantal-kelm
Copy link
Member

@chantal-kelm chantal-kelm commented Dec 6, 2022 •
edited

Description

Fixed commands in the deploy new agent section (most of the commands are missing '-1').

Issues Resolved

#4958

Manual Backports

4.4-2.3-wzd
4.4-7.16

Evidence

image

Steps to test

  1. Click on Agents
  2. Click on Deploy new agent
  3. See installation commands (all commands have the '-1).

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@chantal-kelm chantal-kelm requested a review from a team as a code owner December 6, 2022 11:57
@chantal-kelm chantal-kelm self-assigned this Dec 6, 2022
@chantal-kelm chantal-kelm linked an issue Dec 6, 2022 that may be closed by this pull request
Fix commands in the deploy new agent section (missing -1). #4958
Closed
@chantal-kelm chantal-kelm mentioned this pull request Dec 6, 2022
Closed
@chantal-kelm chantal-kelm mentioned this pull request Dec 13, 2022
Merged
@chantal-kelm chantal-kelm changed the title fix-commands-in-the-deploy-new-agent-section Fix-commands-in-the-deploy-new-agent-section Dec 13, 2022
@chantal-kelm chantal-kelm mentioned this pull request Dec 13, 2022
Merged
@chantal-kelm chantal-kelm changed the title Fix-commands-in-the-deploy-new-agent-section Fixed-commands-in-the-deploy-new-agent-section Dec 14, 2022
@chantal-kelm chantal-kelm mentioned this pull request Dec 14, 2022
Closed
@AlexRuiz7 AlexRuiz7 changed the title Fixed-commands-in-the-deploy-new-agent-section Fix commands in the deploy new agent section Dec 14, 2022
Mayons95
Mayons95 previously approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@Mayons95 Mayons95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TR: ✔️
Screencast from 14-12-22 15:52:58.webm

@Mayons95 Mayons95 self-requested a review December 16, 2022 18:17
Mayons95
Mayons95 previously approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@Mayons95 Mayons95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yenienserrano
yenienserrano previously approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.69% ( 3212 / 36968 )
Branches 4.43% ( 1271 / 28692 )
Functions 7.59% ( 696 / 9168 )
Lines 8.76% ( 3099 / 35396 )

@Mayons95 Mayons95 self-requested a review December 19, 2022 16:19
@chantal-kelm chantal-kelm merged commit 61283ed into 4.4-7.10 Dec 19, 2022
@chantal-kelm chantal-kelm deleted the 4958-fix-commands-in--deploy-new-agent-section branch December 19, 2022 17:12
@Desvelao Desvelao mentioned this pull request Dec 20, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano approved these changes

@Mayons95 Mayons95 Mayons95 approved these changes

Assignees

@chantal-kelm chantal-kelm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix commands in the deploy new agent section (missing -1).
4 participants
@chantal-kelm @yenienserrano @Mayons95 @AlexRuiz7