New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vulnerabilities in dependencies #4985
Conversation
|
Changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: ✅
Test: ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-7.16 4.4-7.16
# Navigate to the new working tree
cd .worktrees/backport-4.4-7.16
# Create a new branch
git switch --create backport-4985-to-4.4-7.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a33ba7e7c7cd0ad1446171c0e9b7ddb6cd72e394
# Push it to GitHub
git push --set-upstream origin backport-4985-to-4.4-7.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-7.16 Then, create a pull request where the |
* remove angular-chart * winston dependency update (3.5.1) * changelog: add PR entries * dependency: upgrade dependency pdfmake to 0.2.6 * changelog: add the pull request entry * test: updated test of reporting Co-authored-by: yenienserrano <ian.serrano@wazuh.com> Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit a33ba7e)
Fix vulnerabilities in dependencies (#4985) * remove angular-chart * winston dependency update (3.5.1) * changelog: add PR entries * dependency: upgrade dependency pdfmake to 0.2.6 * changelog: add the pull request entry * test: updated test of reporting Co-authored-by: yenienserrano <ian.serrano@wazuh.com> Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit a33ba7e)
Description
This pull request fixes some problems related to dependency vulnerabilities:
angular-chart.js
dependency and unused codewinston
to3.5.1
pdfmake
to0.2.6
Issues Resolved
Closes #4956
Evidence
[Provide screenshots or videos to prove this PR solves the issues]
Test
Scenario Plugin logs should be generated without problems
Given a new environment without plugin logs stored in the filesystem
When the plugin starts
Then it should exist the plugin logs files with some logs
Scenario The PDF reports can be generated correctly - Modules without selected agent
When the user exports to PDF a Dashboard. For example,
Security events
and no agent is selectedThen the PDF should be generated correctly.
And the logo should appear
And the default header should appear
And the default footer should appear
And the visualizations and summary table should appear
Scenario The PDF reports can be generated correctly - Modules with selected agent
When the user exports to PDF a Dashboard. For example,
Security events
and any agent is selectedThen the PDF should be generated correctly.
And the logo should appear
And the default header should appear
And the default footer should appear
And the visualizations and summary table should appear
Scenario The PDF reports can be generated correctly - Agent configuration
When the user exports to PDF an agent configuration
Then the PDF should be generated correctly.
And the logo should appear
And the default header should appear
And the default footer should appear
And the data should appear
Scenario The PDF reports can be generated correctly - Agent inventory
When the user exports to PDF an agent configuration
Then the PDF should be generated correctly.
And the logo should appear
And the default header should appear
And the default footer should appear
And the data should appear
Scenario The PDF reports can be generated correctly - Group configuration
When the user exports to PDF an agent configuration
Then the PDF should be generated correctly.
And the logo should appear
And the default header should appear
And the default footer should appear
And the data should appear
Check List
yarn test:jest