Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checking total RAM #502

Merged
merged 5 commits into from May 31, 2018
Merged

Checking total RAM #502

merged 5 commits into from May 31, 2018

Conversation

jesusgn90
Copy link
Contributor

Hello team, this pull request fixes #498

Brief summary:

  • Added new route to get the RAM from server side.
  • Checking its value at first line of settings-wizard
  • Showing warning if totalRAM < 3072 && totalRAM > 2048
  • Showing error if totalRAM <= 2048 or an error occurred

Regards,
Jesús

@jesusgn90 jesusgn90 added 3.2 type/enhancement Enhancement issue labels May 28, 2018
@jesusgn90 jesusgn90 self-assigned this May 28, 2018
@jesusgn90 jesusgn90 mentioned this pull request May 28, 2018
Closed
@jesusgn90 jesusgn90 added this to To do in Revision 395 via automation May 28, 2018
@havidarou
Copy link
Member

LGTM!

@havidarou havidarou merged commit 6a8d9fd into 3.2 May 31, 2018
Revision 395 automation moved this from To do to Testing May 31, 2018
@havidarou havidarou deleted the 3.2-issue-498 branch May 31, 2018 19:20
@jesusgn90 jesusgn90 moved this from Testing to Done in Revision 395 Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jesusgn90 jesusgn90

Labels
type/enhancement Enhancement issue
Projects
No open projects
Revision 395
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jesusgn90 @havidarou