Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pug files #5089

Merged
merged 5 commits into from Jan 10, 2023
Merged

Remove pug files #5089

merged 5 commits into from Jan 10, 2023

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Jan 9, 2023 •
edited

Description

unused files are removed, after removing the pug-loader dependency

Issues Resolved

Test

Test the application and make sure it works as expected

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano requested a review from a team as a code owner January 9, 2023 15:58
@yenienserrano yenienserrano changed the base branch from master to 4.4-2.4-wzd January 9, 2023 16:02
@yenienserrano yenienserrano linked an issue Jan 9, 2023 that may be closed by this pull request
Update plugin dependencies #5059
Closed
Desvelao
Desvelao reviewed Jan 10, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@Desvelao
Copy link
Member

Changes

Moved the deletion of pug-loader dependency to the Removed section in the changelog

Desvelao
Desvelao approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review:

🟢 code
🟢 test

@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.74% ( 3231 / 36951 )
Branches 4.55% ( 1306 / 28679 )
Functions 7.62% ( 698 / 9160 )
Lines 8.8% ( 3116 / 35382 )

asteriscos
asteriscos approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

@asteriscos asteriscos merged commit 69635ac into 4.4-2.4-wzd Jan 10, 2023
@asteriscos asteriscos deleted the remove-pug-files branch January 10, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteriscos asteriscos asteriscos approved these changes

@Desvelao Desvelao Desvelao approved these changes

Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update plugin dependencies
3 participants
@yenienserrano @Desvelao @asteriscos