Disable synced by default #5143

asteriscos · 2023-01-19T16:55:43Z

Description

Hi team,

This PR:

Disables by default the Synced - Registration Date - Last Keep Alive fields of the Agents table and removes the metric on the top of the view. Even though it is disabled, it still can be enabled by checking the field in the table settings.
It also changes the text IP and the text OS to IP address and to Operating system throughout the app.
Improves the Agents table dynamic layout
Fixes Windows and MacOs operating system icons in the agents table

Issues Resolved

Closes #5141

Evidence

Tests

Synced field - Registration Date - Last Keep Alive

Register agents in the manager
Go to Agents overview
Check the table does not include the synced field
Check the top metrics don't include the Synced percentage
Check the synced field can be enabled in the Agents table

Replace `OS` to `Operating system` and `IP` to `IP address`

Agents table

Agents Inventory PDF report

Go to an Agent inventory data
Generate PDF report

Groups agents table

Go to Management -> Groups
Select a group

Agent overview

Go to Agents
Select an agent

Management cluster

Go to Management -> Cluster
Click on Nodes link

Office365 Panel

Go to Office365 -> Panel
Click on any Top Client IP Address table row to drill-down

Global Configuration Remote

Go to Management -> Configuration
Click on the Global configuration row
Click on the Remote tab

Explore Agent modal

Go to Security Events
Click on Explore Agent button

Redistribute Agents Table column widths automatically

Go to Agents Overview
Add and remove all available columns to force different widths in the columns
Check they adjust properly

Verify all main agents operating system have the proper icon in the table

Register Linux, Windows and MacOS agents
Check they have the corresponding icon in the Agents Overview Table

Important
To test it properly, delete the preview local storage table configuration

Check List

All tests pass
- yarn test:jest
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

Tostti

According to the Issue, the Registration date and Last keep alive fields should also be disabled by default

public/components/management/cluster/node-list.tsx

Desvelao

nitpick: There are more files that contain references to IP and OS that we could be interested to change too.

Some of them:

common/csv-key-equivalence.ts
public/components/overview/office-panel/config/main-view-config.tsx
public/components/visualize/visualizations.js (IP by Users)
public/controllers/management/components/management/configuration/global-configuration/global-configuration-remote.js
public/templates/management/management.html
server/controllers/wazuh-reporting.ts
server/integration-files/visualizations/overview/overview-hipaa.ts
server/integration-files/visualizations/overview/overview-office.ts
common/csv-key-equivalence.ts Review where it is affecting to
common/compliance-requirements/pci-requirements.ts Not sure if this we could change it or should not changed.
public/controllers/agent/components/agents-table.js
public/controllers/management/components/management/configuration/vulnerabilities/vulnerabilities-providers.js
public/controllers/overview/components/overview-actions/agents-selection-table.js
server/lib/reporting/agent-configuration.ts
server/lib/reporting/extended-information.ts
public/controllers/management/components/management/groups/group-agents-table.js

Fix:

public/components/management/cluster/node-list.tsx
public/controllers/management/components/management/status/status-agent-info.js

asteriscos · 2023-01-24T11:17:32Z

nitpick: There are more files that contain references to IP and OS that we could be interested to change too.

Some of them:

common/csv-key-equivalence.ts

public/components/overview/office-panel/config/main-view-config.tsx

public/components/visualize/visualizations.js (IP by Users)

public/controllers/management/components/management/configuration/global-configuration/global-configuration-remote.js

public/templates/management/management.html

server/controllers/wazuh-reporting.ts

server/integration-files/visualizations/overview/overview-hipaa.ts

None found

server/integration-files/visualizations/overview/overview-office.ts

None found

common/csv-key-equivalence.ts Review where it is affecting to

common/compliance-requirements/pci-requirements.ts Not sure if this we could change it or should not changed.

public/controllers/agent/components/agents-table.js

public/controllers/management/components/management/configuration/vulnerabilities/vulnerabilities-providers.js

The space is too small and reducing "Operating system" to "OS" is worthwhile

public/controllers/overview/components/overview-actions/agents-selection-table.js

server/lib/reporting/agent-configuration.ts

server/lib/reporting/extended-information.ts

The "OS" in line 84 is justified to optimize the table space, as the manager name or agent name can be quite lengthy.

public/controllers/management/components/management/groups/group-agents-table.js

Fix:

public/components/management/cluster/node-list.tsx

public/controllers/management/components/management/status/status-agent-info.js

Thanks for the suggestions.

Tostti

TEST:✔️
CR:✔️
PREVIOUS REVIEW CHANGES REQUESTED: ✔️

Evidence:

LGTM

AlexRuiz7

LGTM

…efault-5141

asteriscos · 2023-01-24T17:57:36Z

Table design

The proposal to optimize the agents table is to make use of the euiBasicTable property table-layout="auto" and remove the fixed widths. Setting the table layout to auto make much better use of the blank spaced in columns in favor of lengthy column values.

side effect

The table-layout="auto" prop doesn't support truncating text when the table width is limited by the viewport. To avoid overflowing the table it wraps the lines of the values.

…efault-5141

Tostti

TEST:✔️
CR:✔️

LGTM

chantal-kelm · 2023-01-25T13:57:50Z

Replace OS to Operating system and IP to IP address

Agents table 🟢

Chrome 🟢

Firefox 🟢

Safari 🟢

Agents Inventory PDF report 🟢

Chrome 🟢

Firefox 🟢

Safari 🟢

Groups agents table 🟢

Chrome 🟢

Firefox 🟢

Safari 🟢

Agent overview 🟢

Chrome 🟢

Firefox 🟢

Safari 🟢

Management cluster 🟢

Chrome 🟢

Firefox 🟢

Safari 🟢

Office365 Panel 🟢

Chrome 🟢

Firefox 🟢

Safari 🟢

Global Configuration Remote 🟢

Chrome 🟢

Firefox 🟢

Safari 🟢

Explore Agent modal 🟢

Chrome 🟢

Firefox 🟢

Safari 🟢

Redistribute Agents Table column widths automatically 🔴

Chrome 🔴

Firefox 🔴

Safari 🔴

asteriscos · 2023-01-25T15:37:59Z

Thanks for reporting this. I allowed the Registration date, IP address and version columns to wrap the line to prevent the table overflow.

chantal-kelm · 2023-01-25T18:34:04Z

Thanks for reporting this. I allowed the Registration date, IP address and version columns to wrap the line to prevent the table overflow.

Chrome

The table with all columns added looks good from 864px width onwards

Firefox

The table with all columns added looks good from 854px width onwards

Safari

The table with all columns added looks good from 854px width onwards

chantal-kelm

CR: ✅
TEST: ✅

Chrome

The table with all columns added looks good from 864px width onwards

Firefox

The table with all columns added looks good from 854px width onwards

Safari

The table with all columns added looks good from 854px width onwards

Tostti

Chrome

The table looks good in all the resolutions. When the is smaller than the width, it enables lateral scroll.

Firefox

The table looks good in all the resolutions. When the is smaller than the width, it enables lateral scroll.

TEST:✔️
CR:✔️

LGTM

…efault-5141

github-actions · 2023-01-26T11:55:19Z

Code coverage (Jest)	%	values
Statements	8.76%	( 3237 / 36910 )
Branches	4.5%	( 1291 / 28659 )
Functions	7.63%	( 698 / 9142 )
Lines	8.83%	( 3122 / 35344 )

This reverts commit 311622a.

github-actions · 2023-01-26T13:46:14Z

The backport to 4.4-7.10 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-7.10 4.4-7.10
# Navigate to the new working tree
cd .worktrees/backport-4.4-7.10
# Create a new branch
git switch --create backport-5143-to-4.4-7.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 311622afdc953d61bd594795b684436c914b3760
# Push it to GitHub
git push --set-upstream origin backport-5143-to-4.4-7.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-7.10

Then, create a pull request where the base branch is 4.4-7.10 and the compare/head branch is backport-5143-to-4.4-7.10.

* Disable synced by default * Fix column default properties * Add changelog * Remove synced KPI from management status * Fix typos, agent table width style and os.platform * Replace OS to operating system and IP to IP address * Change OS to operating system * Fix agent table layout * Change IP to IP address in cluster overview * Fix extendedInformation * Fix style columnsSelectedCheckboxs * Remove truncate property of columns * Add table overflow auto * Change OS version to flexItem * Change OS version gutter size (cherry picked from commit 311622a)

Disable synced by default (#5143) * Disable synced by default * Fix column default properties * Add changelog * Remove synced KPI from management status * Fix typos, agent table width style and os.platform * Replace OS to operating system and IP to IP address * Change OS to operating system * Fix agent table layout * Change IP to IP address in cluster overview * Fix extendedInformation * Fix style columnsSelectedCheckboxs * Remove truncate property of columns * Add table overflow auto * Change OS version to flexItem * Change OS version gutter size (cherry picked from commit 311622a) Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com> Co-authored-by: Antonio <34042064+Desvelao@users.noreply.github.com>

* Disable synced by default (#5143) * Disable synced by default * Fix column default properties * Add changelog * Remove synced KPI from management status * Fix typos, agent table width style and os.platform * Replace OS to operating system and IP to IP address * Change OS to operating system * Fix agent table layout * Change IP to IP address in cluster overview * Fix extendedInformation * Fix style columnsSelectedCheckboxs * Remove truncate property of columns * Add table overflow auto * Change OS version to flexItem * Change OS version gutter size (cherry picked from commit 311622a) * fix: fix renamed os to operating system Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com>

Disable synced by default

2aeddcb

asteriscos requested a review from a team as a code owner January 19, 2023 16:55

asteriscos self-assigned this Jan 19, 2023

asteriscos added 2 commits January 19, 2023 18:05

Fix column default properties

1ca5458

Add changelog

4847f57

Tostti requested changes Jan 19, 2023

View reviewed changes

asteriscos added 2 commits January 20, 2023 11:10

Remove synced KPI from management status

300e05d

Fix typos, agent table width style and os.platform

13cab13

Desvelao reviewed Jan 24, 2023

View reviewed changes

public/components/management/cluster/node-list.tsx Outdated Show resolved Hide resolved

Desvelao linked an issue Jan 24, 2023 that may be closed by this pull request

Disable sync information in agent table by default #5141

Closed

Desvelao requested changes Jan 24, 2023

View reviewed changes

asteriscos requested a review from Tostti January 24, 2023 09:58

asteriscos requested a review from Desvelao January 24, 2023 11:17

Replace OS to operating system and IP to IP address

675e30b

Tostti previously approved these changes Jan 24, 2023

View reviewed changes

AlexRuiz7 previously approved these changes Jan 24, 2023

View reviewed changes

Change OS to operating system

f474cf7

asteriscos dismissed stale reviews from AlexRuiz7 and Tostti via f474cf7 January 24, 2023 13:52

asteriscos added 2 commits January 24, 2023 18:33

Fix agent table layout

5b53274

Merge branch '4.4-2.4-wzd' into feature/disable-sync-information-by-d…

9fef451

…efault-5141

asteriscos added 4 commits January 25, 2023 10:07

Merge branch '4.4-2.4-wzd' into feature/disable-sync-information-by-d…

b3ed5be

…efault-5141

Change IP to IP address in cluster overview

34d0329

Fix extendedInformation

17a3940

Fix style columnsSelectedCheckboxs

34247ed

Tostti previously approved these changes Jan 25, 2023

View reviewed changes

chantal-kelm self-requested a review January 25, 2023 11:48

Remove truncate property of columns

3d8b9da

asteriscos dismissed Tostti’s stale review via 3d8b9da January 25, 2023 15:35

asteriscos added 3 commits January 25, 2023 17:56

Add table overflow auto

a0daa0d

Change OS version to flexItem

ed786f2

Change OS version gutter size

7817bcd

chantal-kelm approved these changes Jan 25, 2023

View reviewed changes

Tostti approved these changes Jan 25, 2023

View reviewed changes

Merge branch '4.4-2.4-wzd' into feature/disable-sync-information-by-d…

0e2010d

…efault-5141

Desvelao approved these changes Jan 26, 2023

View reviewed changes

asteriscos merged commit 311622a into 4.4-2.4-wzd Jan 26, 2023

asteriscos deleted the feature/disable-sync-information-by-default-5141 branch January 26, 2023 13:30

asteriscos added a commit that referenced this pull request Jan 26, 2023

Revert "Disable synced by default (#5143)"

711c644

This reverts commit 311622a.

asteriscos added backport 4.4-7.16 labels Jan 26, 2023

github-actions bot mentioned this pull request Jan 26, 2023

[Backport 4.4-7.16] Disable synced by default #5169

Merged

asteriscos mentioned this pull request Jan 26, 2023

[Backport 4.4 7.10] Disable synced by default #5170

Merged

Desvelao mentioned this pull request May 25, 2023

IPv6 addresses display errors #5464

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable synced by default #5143

Disable synced by default #5143

asteriscos commented Jan 19, 2023 •

edited

Loading

Tostti left a comment

Desvelao left a comment

asteriscos commented Jan 24, 2023

Tostti left a comment

AlexRuiz7 left a comment

asteriscos commented Jan 24, 2023

Tostti left a comment

chantal-kelm commented Jan 25, 2023 •

edited

Loading

asteriscos commented Jan 25, 2023

chantal-kelm commented Jan 25, 2023

chantal-kelm left a comment

Tostti left a comment

github-actions bot commented Jan 26, 2023

github-actions bot commented Jan 26, 2023

Disable synced by default #5143

Disable synced by default #5143

Conversation

asteriscos commented Jan 19, 2023 • edited Loading

Description

Issues Resolved

Evidence

Tests

Synced field - Registration Date - Last Keep Alive

Replace OS to Operating system and IP to IP address

Agents table

Agents Inventory PDF report

Groups agents table

Agent overview

Management cluster

Office365 Panel

Global Configuration Remote

Explore Agent modal

Redistribute Agents Table column widths automatically

Verify all main agents operating system have the proper icon in the table

Check List

Tostti left a comment

Choose a reason for hiding this comment

Desvelao left a comment

Choose a reason for hiding this comment

asteriscos commented Jan 24, 2023

Tostti left a comment

Choose a reason for hiding this comment

AlexRuiz7 left a comment

Choose a reason for hiding this comment

asteriscos commented Jan 24, 2023

Table design

side effect

Tostti left a comment

Choose a reason for hiding this comment

chantal-kelm commented Jan 25, 2023 • edited Loading

asteriscos commented Jan 25, 2023

chantal-kelm commented Jan 25, 2023

chantal-kelm left a comment

Choose a reason for hiding this comment

Tostti left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 26, 2023

github-actions bot commented Jan 26, 2023

asteriscos commented Jan 19, 2023 •

edited

Loading

Replace `OS` to `Operating system` and `IP` to `IP address`

chantal-kelm commented Jan 25, 2023 •

edited

Loading