Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change link to Malware detection documentation #5329

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Mar 28, 2023

Description

Anomaly and malware detection link changed to malware detection link. Due to documentation changes in this PR

Issues Resolved

Evidence

image

Test

  1. Navigate to management/configuration/policy monitoring/system audit
  2. Click on image image
  3. The button is now called Malware detection and the href has to be user-manual/capabilities/malware-detection/index.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

CHANGELOG.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.77% ( 3240 / 36922 )
Branches 4.49% ( 1287 / 28638 )
Functions 7.63% ( 698 / 9144 )
Lines 8.83% ( 3125 / 35357 )

@Desvelao
Copy link
Member

Wazuh dashboard

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox
The link with the title Malware detection of Management/Configuration/Policy monitoring should open a working page 🟢 🟢
The link with the title Malware detection of Agents/{agent}/Configuration/Policy monitoring should open a working page 🟢 🟢

Details

🟢 The link with the title Malware detection of Management/Configuration/Policy monitoring should open a working page

Chrome - 🟢
image

Firefox - 🟢
image

🟢 The link with the title Malware detection of Agents/{agent}/Configuration/Policy monitoring should open a working page

Chrome - 🟢
image

Firefox - 🟢
image

Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review

🟢 code
🟢 test #5329 (comment)

@yenienserrano yenienserrano merged commit ed9e44e into 4.4-2.4-wzd Mar 30, 2023
3 checks passed
@yenienserrano yenienserrano deleted the fix-5318-a-link-in-managementconfigurationpolicy-monitoringsystem-audit-view-redirects-to-a-404 branch March 30, 2023 09:45
@github-actions
Copy link
Contributor

The backport to 4.4-7.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-7.16 4.4-7.16
# Navigate to the new working tree
cd .worktrees/backport-4.4-7.16
# Create a new branch
git switch --create backport-5329-to-4.4-7.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ed9e44e87f092b2965b46ce988aa00d92d701b43
# Push it to GitHub
git push --set-upstream origin backport-5329-to-4.4-7.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-7.16

Then, create a pull request where the base branch is 4.4-7.16 and the compare/head branch is backport-5329-to-4.4-7.16.

@github-actions
Copy link
Contributor

The backport to 4.4-7.10 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-7.10 4.4-7.10
# Navigate to the new working tree
cd .worktrees/backport-4.4-7.10
# Create a new branch
git switch --create backport-5329-to-4.4-7.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ed9e44e87f092b2965b46ce988aa00d92d701b43
# Push it to GitHub
git push --set-upstream origin backport-5329-to-4.4-7.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-7.10

Then, create a pull request where the base branch is 4.4-7.10 and the compare/head branch is backport-5329-to-4.4-7.10.

yenienserrano added a commit that referenced this pull request Mar 30, 2023
* Change link to Malware detection documentation

* Add changelog

* Update CHANGELOG.md

(cherry picked from commit ed9e44e)
yenienserrano added a commit that referenced this pull request Mar 30, 2023
* Change link to Malware detection documentation

* Add changelog

* Update CHANGELOG.md

(cherry picked from commit ed9e44e)
yenienserrano added a commit that referenced this pull request Mar 30, 2023
Change link to Malware detection documentation (#5329)

* Change link to Malware detection documentation

* Add changelog

* Update CHANGELOG.md

(cherry picked from commit ed9e44e)
yenienserrano added a commit that referenced this pull request Mar 30, 2023
Change link to Malware detection documentation (#5329)

* Change link to Malware detection documentation

* Add changelog

* Update CHANGELOG.md

(cherry picked from commit ed9e44e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A link in management/configuration/policy monitoring/system audit view redirects to a 404
3 participants