Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change height to table top 5 users in fim::dashboard #5334

Merged
merged 4 commits into from Mar 30, 2023
Merged

Change height to table top 5 users in fim::dashboard #5334

merged 4 commits into from Mar 30, 2023

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Mar 29, 2023 •
edited

Description

As the display of the table has been changed, the table now needs a little more space, so the height of the cards has been changed from 300 to 350.

Issues Resolved

Evidence

image

Test

  1. You must have sample data enabled
  2. Navigate to FIM without selected agents
  3. Look at the Top 5 agents table

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano requested a review from a team as a code owner March 29, 2023 12:43
@yenienserrano yenienserrano changed the title Change height to table top 5 users in fim::dashboard overflows Change height to table top 5 users in fim::dashboard Mar 29, 2023
@yenienserrano yenienserrano self-assigned this Mar 29, 2023
@yenienserrano yenienserrano linked an issue Mar 29, 2023 that may be closed by this pull request
Table Top 5 users in FIM::Dashboard overflows #5317
Closed
@Desvelao
Copy link
Member

Wazuh dashboard

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox
The Top 5 users visualization in Modules/Integrity monitoring/Dashboard should not overflow of the panel 🟢 🟢

Details

🟢 The Top 5 users visualization in Modules/Integrity monitoring/Dashboard should not overflow of the panel

Chrome - 🟢
image
image

Firefox - 🟢
image
image

Desvelao
Desvelao previously approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review

🟢 code
🟢 test #5334 (comment)

AlexRuiz7
AlexRuiz7 previously approved these changes Mar 30, 2023
View reviewed changes
@yenienserrano yenienserrano dismissed stale reviews from AlexRuiz7 and Desvelao via f0bd052 March 30, 2023 09:47
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.77% ( 3240 / 36922 )
Branches 4.49% ( 1287 / 28638 )
Functions 7.63% ( 698 / 9144 )
Lines 8.83% ( 3125 / 35357 )

@yenienserrano yenienserrano merged commit 7d3e2e7 into 4.4-2.4-wzd Mar 30, 2023
3 checks passed
@yenienserrano yenienserrano deleted the fix-5317-table-top-5-users-in-fimdashboard-overflows branch March 30, 2023 15:04
This was referenced Mar 30, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao approved these changes

@AlexRuiz7 AlexRuiz7 AlexRuiz7 left review comments

Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Table Top 5 users in FIM::Dashboard overflows
3 participants
@yenienserrano @Desvelao @AlexRuiz7