Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 4.5-7.16] Make checks inside Pattern check services #5387

Merged
merged 1 commit into from
Apr 19, 2023
Merged

[Backport 4.5-7.16] Make checks inside Pattern check services #5387

merged 1 commit into from
Apr 19, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Backport 41d9a3f from #5384.

@asteriscos @github-actions
Make checks inside Pattern check services (#5384)
48c39e5 
* Make checks inside Pattern check services

* Add changelog

* refactor checkPluginPlatformSettings and code cleaning

(cherry picked from commit 41d9a3f)
@github-actions github-actions bot requested a review from a team as a code owner April 18, 2023 18:01
@Desvelao Desvelao linked an issue Apr 19, 2023 that may be closed by this pull request
Move settings checks to alerts index check on health check page #5310
Closed
2 tasks
@Desvelao
Copy link
Member

Desvelao commented Apr 19, 2023 •
edited

Kibana 7.17.6

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome
With the checks.pattern enabled, enable the checks.maxBuckets, checks.metaFields and checks.timeFilter, the platform setting checks should run and update the change if needed 🟢
With the checks.pattern disabled, enable the checks.maxBuckets, checks.metaFields and checks.timeFilter, the platform setting checks should run and update the change if needed 🟢
With the checks.pattern disabled, disable the checks.maxBuckets, checks.metaFields and checks.timeFilter, the platform setting checks should not run 🟢

Details

🟢 With the `checks.pattern` enabled, enable the `checks.maxBuckets`, `checks.metaFields` and `checks.timeFilter`, the platform setting checks should run and update the change if needed

Chrome - 🟢
image
image

🟢 With the `checks.pattern` disabled, enable the `checks.maxBuckets`, `checks.metaFields` and `checks.timeFilter`, the platform setting checks should run and update the change if needed

Chrome - 🟢
image
image

🟢 With the `checks.pattern` disabled, disable the `checks.maxBuckets`, `checks.metaFields` and `checks.timeFilter`, the platform setting checks should not run

Chrome - 🟢
image
image

Desvelao
Desvelao approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review

🟢 code
🟢 tests #5387 (comment)

@asteriscos asteriscos merged commit eff17ef into 4.5-7.16 Apr 19, 2023
@asteriscos asteriscos deleted the backport-5384-to-4.5-7.16 branch April 19, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move settings checks to alerts index check on health check page
2 participants
@Desvelao @asteriscos