Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Most active agent button in the Agents section #5409

Merged
merged 3 commits into from
Apr 27, 2023
Merged

Fix Most active agent button in the Agents section #5409

merged 3 commits into from
Apr 27, 2023

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Apr 27, 2023 •
edited by AlexRuiz7
Loading

Description

This pull request fixes a problem in the Most active agent button in the Agents section due to a not defined method.

Issues Resolved

[List any issues this PR will resolve]

Evidence

[Provide screenshots or videos to prove this PR solves the issues]

Test

[Provide instructions to test this PR]

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Desvelao Desvelao requested a review from a team as a code owner April 27, 2023 10:38
@Desvelao Desvelao self-assigned this Apr 27, 2023
@Machi3mfl Machi3mfl self-requested a review April 27, 2023 10:44
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 9.45% ( 3502 / 37037 )
Branches 5% ( 1436 / 28712 )
Functions 8.13% ( 747 / 9178 )
Lines 9.53% ( 3382 / 35471 )

AlexRuiz7
AlexRuiz7 suggested changes Apr 27, 2023
View reviewed changes
Copy link
Member

@AlexRuiz7 AlexRuiz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but needs an issue and the fields in the PR description filled

yenienserrano
yenienserrano approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
TEST: ✔️

Screenshots

image

image

@Desvelao Desvelao linked an issue Apr 27, 2023 that may be closed by this pull request
Error this.showEuiLinkgent is not a function in the Agents section #5410
Closed
@AlexRuiz7 AlexRuiz7 merged commit 37b24de into 4.5 Apr 27, 2023
3 checks passed
@AlexRuiz7 AlexRuiz7 deleted the fix/5038-most-active-agent-button branch April 27, 2023 11:12
@github-actions github-actions bot mentioned this pull request Apr 27, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Apr 27, 2023
@Desvelao @github-actions
Fix Most active agent button in the Agents section (#5409)
0885cfc 
* fix(agents): fix undefined method when clicking in the most active agent button of Agents section

* changelog: add entry

(cherry picked from commit 37b24de)
@github-actions github-actions bot mentioned this pull request Apr 27, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Apr 27, 2023
@Desvelao @github-actions
Fix Most active agent button in the Agents section (#5409)
0948bbc 
* fix(agents): fix undefined method when clicking in the most active agent button of Agents section

* changelog: add entry

(cherry picked from commit 37b24de)
AlexRuiz7 pushed a commit that referenced this pull request Apr 27, 2023
@github-actions @Desvelao
[Backport 4.5-7.16] Fix Most active agent button in the Agents section (
cca341f 
#5412)

Fix Most active agent button in the Agents section (#5409)

* fix(agents): fix undefined method when clicking in the most active agent button of Agents section

* changelog: add entry

(cherry picked from commit 37b24de)

Co-authored-by: Antonio <34042064+Desvelao@users.noreply.github.com>
AlexRuiz7 pushed a commit that referenced this pull request Apr 27, 2023
@github-actions @Desvelao
[Backport 4.5-7.10] Fix Most active agent button in the Agents section (
7679a46 
#5411)

Fix Most active agent button in the Agents section (#5409)

* fix(agents): fix undefined method when clicking in the most active agent button of Agents section

* changelog: add entry

(cherry picked from commit 37b24de)

Co-authored-by: Antonio <34042064+Desvelao@users.noreply.github.com>
Machi3mfl
Machi3mfl reviewed Apr 27, 2023
View reviewed changes
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test: ✔️
CR: ✔️

image

image

P.D: I was late for a few seconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Machi3mfl Machi3mfl Machi3mfl left review comments

@AlexRuiz7 AlexRuiz7 AlexRuiz7 approved these changes

@yenienserrano yenienserrano yenienserrano approved these changes

Assignees

@Desvelao Desvelao

Labels
backport 4.5-7.10 backport 4.5-7.16
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error this.showEuiLinkgent is not a function in the Agents section
4 participants
@Desvelao @Machi3mfl @AlexRuiz7 @yenienserrano