Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code #5451

Merged
merged 5 commits into from
May 29, 2023
Merged

Remove deprecated code #5451

merged 5 commits into from
May 29, 2023

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented May 16, 2023

Description

We want to remove a request that is unnecessary and after some research we found that there is a lot of obsolete code, so we are removing related obsolete code.

Issues Resolved

Evidence

Screenshot

image

image

image

image

Test

an agent's display should continue to function as expected and should not make the request to /groups

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano self-assigned this May 16, 2023
@yenienserrano yenienserrano linked an issue May 16, 2023 that may be closed by this pull request
@yenienserrano yenienserrano marked this pull request as ready for review May 17, 2023 08:53
@yenienserrano yenienserrano requested a review from a team as a code owner May 17, 2023 08:53
asteriscos
asteriscos previously approved these changes May 17, 2023
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

image

AlexRuiz7
AlexRuiz7 previously approved these changes May 22, 2023
Copy link
Member

@AlexRuiz7 AlexRuiz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 9.5% ( 3506 / 36885 )
Branches 5.01% ( 1434 / 28605 )
Functions 8.17% ( 747 / 9143 )
Lines 9.58% ( 3386 / 35327 )

@AlexRuiz7 AlexRuiz7 merged commit 522d3cd into 4.5 May 29, 2023
3 checks passed
@AlexRuiz7 AlexRuiz7 deleted the 5236-remove-deprecated-code branch May 29, 2023 12:19
@github-actions
Copy link
Contributor

The backport to 4.5-7.10 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.5-7.10 4.5-7.10
# Navigate to the new working tree
cd .worktrees/backport-4.5-7.10
# Create a new branch
git switch --create backport-5451-to-4.5-7.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 522d3cdfbc81cb6a50ed423ba93f9f081d06e43f
# Push it to GitHub
git push --set-upstream origin backport-5451-to-4.5-7.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.5-7.10

Then, create a pull request where the base branch is 4.5-7.10 and the compare/head branch is backport-5451-to-4.5-7.10.

@github-actions
Copy link
Contributor

The backport to 4.5-7.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.5-7.16 4.5-7.16
# Navigate to the new working tree
cd .worktrees/backport-4.5-7.16
# Create a new branch
git switch --create backport-5451-to-4.5-7.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 522d3cdfbc81cb6a50ed423ba93f9f081d06e43f
# Push it to GitHub
git push --set-upstream origin backport-5451-to-4.5-7.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.5-7.16

Then, create a pull request where the base branch is 4.5-7.16 and the compare/head branch is backport-5451-to-4.5-7.16.

yenienserrano added a commit that referenced this pull request May 29, 2023
* Remove deprecated code

* Remove deprecated code

* Add changelog

(cherry picked from commit 522d3cd)
yenienserrano added a commit that referenced this pull request May 29, 2023
* Remove deprecated code

* Remove deprecated code

* Add changelog

(cherry picked from commit 522d3cd)
AlexRuiz7 pushed a commit that referenced this pull request May 29, 2023
Remove deprecated code (#5451)

* Remove deprecated code

* Remove deprecated code

* Add changelog

(cherry picked from commit 522d3cd)
AlexRuiz7 pushed a commit that referenced this pull request May 29, 2023
Remove deprecated code (#5451)

* Remove deprecated code

* Remove deprecated code

* Add changelog

(cherry picked from commit 522d3cd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wazuh API usage - Agent summary
3 participants