Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the search bar to the one that does not make the request on rendering #5476

Merged
merged 5 commits into from May 29, 2023

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented May 22, 2023

Description

The search bar has been changed to the one used in the rest of the app. The search bar that was being used has been removed since it was the only place where this bar was used, and it also had the bug of the request when rendering.

Issues Resolved

Evidence

Screenshot

image

image

image

image

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
When navigating to management/logs there has to be only 1 request to /cluster/{node}/logs
When searching, the request must be made after a period of time without typing
When clearing the whole search, you have to make the request without search

Details

⚫ When navigating to management/logs there has to be only 1 request to /cluster/{node}/logs

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ When searching, the request must be made after a period of time without typing

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ When clearing the whole search, you have to make the request without search

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano requested a review from a team as a code owner May 22, 2023 10:39
@yenienserrano yenienserrano linked an issue May 22, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 9.46% ( 3504 / 37021 )
Branches 5% ( 1436 / 28677 )
Functions 8.14% ( 747 / 9172 )
Lines 9.54% ( 3384 / 35458 )

@Desvelao
Copy link
Member

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
When navigating to management/logs there has to be only 1 request to /cluster/{node}/logs 🟢 🟢
When searching, the request must be made after a period of time without typing 🟢 🟢
When clearing the whole search, you have to make the request without search 🟢 🟢

Details

🟢 When navigating to management/logs there has to be only 1 request to /cluster/{node}/logs

Chrome - 🟢
image

Firefox - 🟢
image

Safari - ⚫

🟢 When searching, the request must be made after a period of time without typing

Chrome - 🟢
image

Firefox - 🟢
image

Safari - ⚫

🟢 When clearing the whole search, you have to make the request without search

Chrome - 🟢
image

Firefox - 🟢
image

Safari - ⚫

Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review:

code 🟢
test 🟢 #5476 (comment)

@AlexRuiz7 AlexRuiz7 merged commit c2944dc into 4.5 May 29, 2023
5 checks passed
@AlexRuiz7 AlexRuiz7 deleted the 5244-wazuh-api-usage-managementlogs branch May 29, 2023 12:28
@github-actions
Copy link
Contributor

The backport to 4.5-7.10 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.5-7.10 4.5-7.10
# Navigate to the new working tree
cd .worktrees/backport-4.5-7.10
# Create a new branch
git switch --create backport-5476-to-4.5-7.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c2944dc2cf36dae5f71f6620d52c42ad63a117fd
# Push it to GitHub
git push --set-upstream origin backport-5476-to-4.5-7.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.5-7.10

Then, create a pull request where the base branch is 4.5-7.10 and the compare/head branch is backport-5476-to-4.5-7.10.

@github-actions
Copy link
Contributor

The backport to 4.5-7.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.5-7.16 4.5-7.16
# Navigate to the new working tree
cd .worktrees/backport-4.5-7.16
# Create a new branch
git switch --create backport-5476-to-4.5-7.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c2944dc2cf36dae5f71f6620d52c42ad63a117fd
# Push it to GitHub
git push --set-upstream origin backport-5476-to-4.5-7.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.5-7.16

Then, create a pull request where the base branch is 4.5-7.16 and the compare/head branch is backport-5476-to-4.5-7.16.

yenienserrano added a commit that referenced this pull request May 29, 2023
…ndering (#5476)

* Add state confirm search

* Change search bar

* Remove unused search bar

* Add changelog

(cherry picked from commit c2944dc)
yenienserrano added a commit that referenced this pull request May 29, 2023
…ndering (#5476)

* Add state confirm search

* Change search bar

* Remove unused search bar

* Add changelog

(cherry picked from commit c2944dc)
AlexRuiz7 pushed a commit that referenced this pull request May 29, 2023
…e the request on rendering (#5506)

* Change the search bar to the one that does not make the request on rendering (#5476)

* Add state confirm search

* Change search bar

* Remove unused search bar

* Add changelog

(cherry picked from commit c2944dc)

* Update CHANGELOG.md
AlexRuiz7 pushed a commit that referenced this pull request May 29, 2023
…e the request on rendering (#5505)

* Change the search bar to the one that does not make the request on rendering (#5476)

* Add state confirm search

* Change search bar

* Remove unused search bar

* Add changelog

(cherry picked from commit c2944dc)

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wazuh API usage - Management/Logs
3 participants