Fix management of custom rule and decoders files #5734

Desvelao · 2023-07-24T15:23:56Z

Description

This pull request fixes the management of custom rule or decoder file through the relative directory name.

TODO:

Adapt the update and delete endpoints that are blocked Use new default_ruleset parameter when reading rules and decoders file content #5176 (comment)

Patch to apply when the API endpoints are enhanced
wka-issue-5176-add-relative-dirname.txt

Issues Resolved

#5176

Evidence

[Provide screenshots or videos to prove this PR solves the issues]

Test

Wazuh dashboard

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test	Chrome	Firefox	Safari
Rules: Create a new file. The file should be saved on `etc/rules` directory.	⚫	⚫	⚫
Rules: Import a new file with overwrite enabled. The file should be saved on `etc/rules` directory and should overwrite the previous file if it exists.	⚫	⚫	⚫
Rules: Import a new file with overwrite disabled. The file should be saved on `etc/rules` directory and should not overwrite the previous file if it exists.	⚫	⚫	⚫
Rules: Read the file content of a file located in ruleset/rules. Its content should be displayed in the rule viewer.	⚫	⚫	⚫
Rules: Read the file content of a file located in etc/rules/local_rules.xml. Its content should be displayed in the rule viewer.	⚫	⚫	⚫
Rules: Read the file content of a file located in etc/rules/custom_directory/local_rules.xml. Its content should be displayed in the rule viewer. You should have a rule file in that directory, this could require configuration in the manager.	⚫	⚫	⚫
Rules: Update the file content of a file located in etc/rules/local_rules.xml. Its content should be updated.	⚫	⚫	⚫
Rules: Update the file content of a file located in etc/rules/custom_directory/local_rules.xml. Its content should be updated.	⚫	⚫	⚫
Rules: Delete the file content of a file located in etc/rules/local_rules.xml. The file should be deleted.	⚫	⚫	⚫
Rules: Delete the file content of a file located in etc/rules/custom_directory/local_rules.xml. The file should be deleted.	⚫	⚫	⚫
Decoders: Create a new file. The file should be saved on `etc/decoders` directory.	⚫	⚫	⚫
Decoders: Import a new file with overwrite enabled. The file should be saved on `etc/decoders` directory and should overwrite the previous file if it exists.	⚫	⚫	⚫
Decoders: Import a new file with overwrite disabled. The file should be saved on `etc/decoders` directory and should not overwrite the previous file if it exists.	⚫	⚫	⚫
Decoders: Read the file content of a file located in ruleset/decoders. Its content should be displayed in the rule viewer.	⚫	⚫	⚫
Decoders: Read the file content of a file located in etc/decoders/local_decoders.xml. Its content should be displayed in the rule viewer.	⚫	⚫	⚫
Decoders: Read the file content of a file located in etc/decoders/custom_directory/local_decoders.xml. Its content should be displayed in the rule viewer. You should have a rule file in that directory, this could require configuration in the manager.	⚫	⚫	⚫
Decoders: Update the file content of a file located in etc/decoders/local_decoders.xml. Its content should be updated.	⚫	⚫	⚫
Decoders: Update the file content of a file located in etc/decoders/custom_directory/local_decoders.xml. Its content should be updated.	⚫	⚫	⚫
Decoders: Delete the file content of a file located in etc/decoders/local_rules.xml. The file should be deleted.	⚫	⚫	⚫
Decoders: Delete the file content of a file located in etc/decoders/custom_directory/local_decoders.xml. The file should be deleted.	⚫	⚫	⚫

Details

⚫ Rules: Create a new file. The file should be saved on `etc/rules` directory.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Rules: Import a new file with overwrite enabled. The file should be saved on `etc/rules` directory and should overwrite the previous file if it exists.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Rules: Import a new file with overwrite disabled. The file should be saved on `etc/rules` directory and should not overwrite the previous file if it exists.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Rules: Read the file content of a file located in ruleset/rules. Its content should be displayed in the rule viewer.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Rules: Read the file content of a file located in etc/rules/local_rules.xml. Its content should be displayed in the rule viewer.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Rules: Read the file content of a file located in etc/rules/custom_directory/local_rules.xml. Its content should be displayed in the rule viewer. You should have a rule file in that directory, this could require configuration in the manager.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Rules: Update the file content of a file located in etc/rules/local_rules.xml. Its content should be updated.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Rules: Update the file content of a file located in etc/rules/custom_directory/local_rules.xml. Its content should be updated.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Rules: Delete the file content of a file located in etc/rules/local_rules.xml. The file should be deleted.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Rules: Delete the file content of a file located in etc/rules/custom_directory/local_rules.xml. The file should be deleted.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Decoders: Create a new file. The file should be saved on `etc/decoders` directory.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Decoders: Import a new file with overwrite enabled. The file should be saved on `etc/decoders` directory and should overwrite the previous file if it exists.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Decoders: Import a new file with overwrite disabled. The file should be saved on `etc/decoders` directory and should not overwrite the previous file if it exists.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Decoders: Read the file content of a file located in ruleset/decoders. Its content should be displayed in the rule viewer.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Decoders: Read the file content of a file located in etc/decoders/local_decoders.xml. Its content should be displayed in the rule viewer.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Decoders: Read the file content of a file located in etc/decoders/custom_directory/local_decoders.xml. Its content should be displayed in the rule viewer. You should have a rule file in that directory, this could require configuration in the manager.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Decoders: Update the file content of a file located in etc/decoders/local_decoders.xml. Its content should be updated.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Decoders: Update the file content of a file located in etc/decoders/custom_directory/local_decoders.xml. Its content should be updated.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Decoders: Delete the file content of a file located in etc/decoders/local_rules.xml. The file should be deleted.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Decoders: Delete the file content of a file located in etc/decoders/custom_directory/local_decoders.xml. The file should be deleted.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Check List

All tests pass
- yarn test:jest
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

Tostti · 2023-08-10T16:12:43Z

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test	Chrome	Firefox	Safari
Rules: Create a new file. The file should be saved on `etc/rules` directory.	🟢	⚫	⚫
Rules: Import a new file with overwrite enabled. The file should be saved on `etc/rules` directory and should overwrite the previous file if it exists.	🟢	⚫	⚫
Rules: Import a new file with overwrite disabled. The file should be saved on `etc/rules` directory and should not overwrite the previous file if it exists.	🟢	⚫	⚫
Rules: Read the file content of a file located in ruleset/rules. Its content should be displayed in the rule viewer.	🟢	⚫	⚫
Rules: Read the file content of a file located in etc/rules/local_rules.xml. Its content should be displayed in the rule viewer.	🟢	⚫	⚫
Rules: Read the file content of a file located in etc/rules/custom_directory/local_rules.xml. Its content should be displayed in the rule viewer. You should have a rule file in that directory, this could require configuration in the manager.	🟢	⚫	⚫
Rules: Update the file content of a file located in etc/rules/local_rules.xml. Its content should be updated.	🟢	⚫	⚫
Rules: Update the file content of a file located in etc/rules/custom_directory/local_rules.xml. Its content should be updated.	🟢	⚫	⚫
Rules: Delete the file content of a file located in etc/rules/local_rules.xml. The file should be deleted.	🟢	⚫	⚫
Rules: Delete the file content of a file located in etc/rules/custom_directory/local_rules.xml. The file should be deleted.	🟢	⚫	⚫
Decoders: Create a new file. The file should be saved on `etc/decoders` directory.	🟢	⚫	⚫
Decoders: Import a new file with overwrite enabled. The file should be saved on `etc/decoders` directory and should overwrite the previous file if it exists.	🟢	⚫	⚫
Decoders: Import a new file with overwrite disabled. The file should be saved on `etc/decoders` directory and should not overwrite the previous file if it exists.	🟢	⚫	⚫
Decoders: Read the file content of a file located in ruleset/decoders. Its content should be displayed in the rule viewer.	🟢	⚫	⚫
Decoders: Read the file content of a file located in etc/decoders/local_decoders.xml. Its content should be displayed in the rule viewer.	🟢	⚫	⚫
Decoders: Read the file content of a file located in etc/decoders/custom_directory/local_decoders.xml. Its content should be displayed in the rule viewer. You should have a rule file in that directory, this could require configuration in the manager.	🟢	⚫	⚫
Decoders: Update the file content of a file located in etc/decoders/local_decoders.xml. Its content should be updated.	🟢	⚫	⚫
Decoders: Update the file content of a file located in etc/decoders/custom_directory/local_decoders.xml. Its content should be updated.	🟢	⚫	⚫
Decoders: Delete the file content of a file located in etc/decoders/local_rules.xml. The file should be deleted.	🟢	⚫	⚫
Decoders: Delete the file content of a file located in etc/decoders/custom_directory/local_decoders.xml. The file should be deleted.	🟢	⚫	⚫

Details

🟢 Rules: Create a new file. The file should be saved on `etc/rules` directory.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Rules: Import a new file with overwrite enabled. The file should be saved on `etc/rules` directory and should overwrite the previous file if it exists.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Rules: Import a new file with overwrite disabled. The file should be saved on `etc/rules` directory and should not overwrite the previous file if it exists.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Rules: Read the file content of a file located in ruleset/rules. Its content should be displayed in the rule viewer.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Rules: Read the file content of a file located in etc/rules/local_rules.xml. Its content should be displayed in the rule viewer.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Rules: Read the file content of a file located in etc/rules/custom_directory/local_rules.xml. Its content should be displayed in the rule viewer. You should have a rule file in that directory, this could require configuration in the manager.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Rules: Update the file content of a file located in etc/rules/local_rules.xml. Its content should be updated.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Rules: Update the file content of a file located in etc/rules/custom_directory/local_rules.xml. Its content should be updated.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Rules: Delete the file content of a file located in etc/rules/local_rules.xml. The file should be deleted.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Rules: Delete the file content of a file located in etc/rules/custom_directory/local_rules.xml. The file should be deleted.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Decoders: Create a new file. The file should be saved on `etc/decoders` directory.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Decoders: Import a new file with overwrite enabled. The file should be saved on `etc/decoders` directory and should overwrite the previous file if it exists.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Decoders: Import a new file with overwrite disabled. The file should be saved on `etc/decoders` directory and should not overwrite the previous file if it exists.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Decoders: Read the file content of a file located in ruleset/decoders. Its content should be displayed in the rule viewer.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Decoders: Read the file content of a file located in etc/decoders/local_decoders.xml. Its content should be displayed in the rule viewer.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Decoders: Read the file content of a file located in etc/decoders/custom_directory/local_decoders.xml. Its content should be displayed in the rule viewer. You should have a rule file in that directory, this could require configuration in the manager.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Decoders: Update the file content of a file located in etc/decoders/local_decoders.xml. Its content should be updated.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Decoders: Update the file content of a file located in etc/decoders/custom_directory/local_decoders.xml. Its content should be updated.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Decoders: Delete the file content of a file located in etc/decoders/local_rules.xml. The file should be deleted.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Decoders: Delete the file content of a file located in etc/decoders/custom_directory/local_decoders.xml. The file should be deleted.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

lucianogorza · 2023-08-10T18:28:08Z

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test	Chrome	Firefox	Safari
Rules: Create a new file. The file should be saved on `etc/rules` directory.	🟢	🟢	⚫
Rules: Import a new file with overwrite enabled. The file should be saved on `etc/rules` directory and should overwrite the previous file if it exists.	🟢	🟢	⚫
Rules: Import a new file with overwrite disabled. The file should be saved on `etc/rules` directory and should not overwrite the previous file if it exists.	🟢	🟢	⚫
Rules: Read the file content of a file located in ruleset/rules. Its content should be displayed in the rule viewer.	🟢	🟢	⚫
Rules: Read the file content of a file located in etc/rules/local_rules.xml. Its content should be displayed in the rule viewer.	🟢	🟢	⚫
Rules: Read the file content of a file located in etc/rules/custom_directory/local_rules.xml. Its content should be displayed in the rule viewer. You should have a rule file in that directory, this could require configuration in the manager.	🟢	🟢	⚫
Rules: Update the file content of a file located in etc/rules/local_rules.xml. Its content should be updated.	🟢	🟢	⚫
Rules: Update the file content of a file located in etc/rules/custom_directory/local_rules.xml. Its content should be updated.	🟢	🟢	⚫
Rules: Delete the file content of a file located in etc/rules/local_rules.xml. The file should be deleted.	🟢	⚫	⚫
Rules: Delete the file content of a file located in etc/rules/custom_directory/local_rules.xml. The file should be deleted.	⚫	🟢	⚫
Decoders: Create a new file. The file should be saved on `etc/decoders` directory.	🟢	⚫	⚫
Decoders: Import a new file with overwrite enabled. The file should be saved on `etc/decoders` directory and should overwrite the previous file if it exists.	🟢	⚫	⚫
Decoders: Import a new file with overwrite disabled. The file should be saved on `etc/decoders` directory and should not overwrite the previous file if it exists.	🟢	⚫	⚫
Decoders: Read the file content of a file located in ruleset/decoders. Its content should be displayed in the rule viewer.	🟢	⚫	⚫
Decoders: Read the file content of a file located in etc/decoders/local_decoders.xml. Its content should be displayed in the rule viewer.	🟢	⚫	⚫
Decoders: Read the file content of a file located in etc/decoders/custom_directory/local_decoders.xml. Its content should be displayed in the rule viewer. You should have a rule file in that directory, this could require configuration in the manager.	🟢	⚫	⚫
Decoders: Update the file content of a file located in etc/decoders/local_decoders.xml. Its content should be updated.	🟢	⚫	⚫
Decoders: Update the file content of a file located in etc/decoders/custom_directory/local_decoders.xml. Its content should be updated.	🟢	⚫	⚫
Decoders: Delete the file content of a file located in etc/decoders/local_rules.xml. The file should be deleted.	🟢	⚫	⚫
Decoders: Delete the file content of a file located in etc/decoders/custom_directory/local_decoders.xml. The file should be deleted.	🟢	⚫	⚫

Details

🟢 Rules: Create a new file. The file should be saved on `etc/rules` directory.

Chrome - 🟢

Firefox - 🟢

Safari - ⚫

🟢 Rules: Import a new file with overwrite enabled. The file should be saved on `etc/rules` directory and should overwrite the previous file if it exists.

Chrome - 🟢

Firefox - 🟢

Safari - ⚫

🟢 Rules: Import a new file with overwrite disabled. The file should be saved on `etc/rules` directory and should not overwrite the previous file if it exists.

Chrome - 🟢

Firefox - 🟢

Safari - ⚫

🟢 Rules: Read the file content of a file located in ruleset/rules. Its content should be displayed in the rule viewer.

Chrome - 🟢

Firefox - :🟢

Safari - ⚫

🟢 Rules: Read the file content of a file located in etc/rules/local_rules.xml. Its content should be displayed in the rule viewer.

Chrome - 🟢

Firefox - 🟢

Safari - ⚫

🟢 Rules: Read the file content of a file located in etc/rules/custom_directory/local_rules.xml. Its content should be displayed in the rule viewer. You should have a rule file in that directory, this could require configuration in the manager.

Chrome - 🟢

Firefox - 🟢

Safari - ⚫

🟢 Rules: Update the file content of a file located in etc/rules/local_rules.xml. Its content should be updated.

Chrome - 🟢

Firefox - 🟢

Safari - ⚫

🟢 Rules: Update the file content of a file located in etc/rules/custom_directory/local_rules.xml. Its content should be updated.

Chrome - 🟢

Firefox -🟢

Safari - ⚫

🟢 Rules: Delete the file content of a file located in etc/rules/local_rules.xml. The file should be deleted.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Rules: Delete the file content of a file located in etc/rules/custom_directory/local_rules.xml. The file should be deleted.

Chrome - ⚫

Firefox - 🟢

Safari - ⚫

🟢 Decoders: Create a new file. The file should be saved on `etc/decoders` directory.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Decoders: Import a new file with overwrite enabled. The file should be saved on `etc/decoders` directory and should overwrite the previous file if it exists.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Decoders: Import a new file with overwrite disabled. The file should be saved on `etc/decoders` directory and should not overwrite the previous file if it exists.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Decoders: Read the file content of a file located in ruleset/decoders. Its content should be displayed in the rule viewer.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Decoders: Read the file content of a file located in etc/decoders/local_decoders.xml. Its content should be displayed in the rule viewer.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Decoders: Read the file content of a file located in etc/decoders/custom_directory/local_decoders.xml. Its content should be displayed in the rule viewer. You should have a rule file in that directory, this could require configuration in the manager.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Decoders: Update the file content of a file located in etc/decoders/local_decoders.xml. Its content should be updated.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Decoders: Update the file content of a file located in etc/decoders/custom_directory/local_decoders.xml. Its content should be updated.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Decoders: Delete the file content of a file located in etc/decoders/local_rules.xml. The file should be deleted.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Decoders: Delete the file content of a file located in etc/decoders/custom_directory/local_decoders.xml. The file should be deleted.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

Tostti

TEST:✔️
CR:✔️

LGTM

JuanGarriuz · 2023-08-11T10:43:51Z

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test	Chrome	Firefox	Safari
Rules: Create a new file. The file should be saved on `etc/rules` directory.	🟢	⚫	⚫
Rules: Import a new file with overwrite enabled. The file should be saved on `etc/rules` directory and should overwrite the previous file if it exists.	🟢	⚫	⚫
Rules: Import a new file with overwrite disabled. The file should be saved on `etc/rules` directory and should not overwrite the previous file if it exists.	🟢	⚫	⚫
Rules: Read the file content of a file located in ruleset/rules. Its content should be displayed in the rule viewer.	🟢	⚫	⚫
Rules: Read the file content of a file located in etc/rules/local_rules.xml. Its content should be displayed in the rule viewer.	🟢	⚫	⚫
Rules: Read the file content of a file located in etc/rules/custom_directory/local_rules.xml. Its content should be displayed in the rule viewer. You should have a rule file in that directory, this could require configuration in the manager.	🟢	⚫	⚫
Rules: Update the file content of a file located in etc/rules/local_rules.xml. Its content should be updated.	🟢	⚫	⚫
Rules: Update the file content of a file located in etc/rules/custom_directory/local_rules.xml. Its content should be updated.	🟢	⚫	⚫
Rules: Delete the file content of a file located in etc/rules/local_rules.xml. The file should be deleted.	🟢	⚫	⚫
Rules: Delete the file content of a file located in etc/rules/custom_directory/local_rules.xml. The file should be deleted.	🟢	⚫	⚫
Decoders: Create a new file. The file should be saved on `etc/decoders` directory.	🟢	⚫	⚫
Decoders: Import a new file with overwrite enabled. The file should be saved on `etc/decoders` directory and should overwrite the previous file if it exists.	🟢	⚫	⚫
Decoders: Import a new file with overwrite disabled. The file should be saved on `etc/decoders` directory and should not overwrite the previous file if it exists.	🟢	⚫	⚫
Decoders: Read the file content of a file located in ruleset/decoders. Its content should be displayed in the rule viewer.	🟢	⚫	⚫
Decoders: Read the file content of a file located in etc/decoders/local_decoders.xml. Its content should be displayed in the rule viewer.	🟢	⚫	⚫
Decoders: Read the file content of a file located in etc/decoders/custom_directory/local_decoders.xml. Its content should be displayed in the rule viewer. You should have a rule file in that directory, this could require configuration in the manager.	🟢	⚫	⚫
Decoders: Update the file content of a file located in etc/decoders/local_decoders.xml. Its content should be updated.	🟢	⚫	⚫
Decoders: Update the file content of a file located in etc/decoders/custom_directory/local_decoders.xml. Its content should be updated.	🟢	⚫	⚫
Decoders: Delete the file content of a file located in etc/decoders/local_rules.xml. The file should be deleted.	🟢	⚫	⚫
Decoders: Delete the file content of a file located in etc/decoders/custom_directory/local_decoders.xml. The file should be deleted.	🟢	⚫	⚫

Details

🟢 Rules: Create a new file. The file should be saved on `etc/rules` directory.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Rules: Import a new file with overwrite enabled. The file should be saved on `etc/rules` directory and should overwrite the previous file if it exists.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Rules: Import a new file with overwrite disabled. The file should be saved on `etc/rules` directory and should not overwrite the previous file if it exists.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Rules: Read the file content of a file located in ruleset/rules. Its content should be displayed in the rule viewer.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Rules: Read the file content of a file located in etc/rules/local_rules.xml. Its content should be displayed in the rule viewer.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Rules: Read the file content of a file located in etc/rules/custom_directory/local_rules.xml. Its content should be displayed in the rule viewer. You should have a rule file in that directory, this could require configuration in the manager.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Rules: Update the file content of a file located in etc/rules/local_rules.xml. Its content should be updated.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Rules: Update the file content of a file located in etc/rules/custom_directory/local_rules.xml. Its content should be updated.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Rules: Delete the file content of a file located in etc/rules/local_rules.xml. The file should be deleted.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Rules: Delete the file content of a file located in etc/rules/custom_directory/local_rules.xml. The file should be deleted.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Decoders: Create a new file. The file should be saved on `etc/decoders` directory.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Decoders: Import a new file with overwrite enabled. The file should be saved on `etc/decoders` directory and should overwrite the previous file if it exists.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Decoders: Import a new file with overwrite disabled. The file should be saved on `etc/decoders` directory and should not overwrite the previous file if it exists.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Decoders: Read the file content of a file located in ruleset/decoders. Its content should be displayed in the rule viewer.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Decoders: Read the file content of a file located in etc/decoders/local_decoders.xml. Its content should be displayed in the rule viewer.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Decoders: Read the file content of a file located in etc/decoders/custom_directory/local_decoders.xml. Its content should be displayed in the rule viewer. You should have a rule file in that directory, this could require configuration in the manager.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Decoders: Update the file content of a file located in etc/decoders/local_decoders.xml. Its content should be updated.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Decoders: Update the file content of a file located in etc/decoders/custom_directory/local_decoders.xml. Its content should be updated.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Decoders: Delete the file content of a file located in etc/decoders/local_rules.xml. The file should be deleted.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Decoders: Delete the file content of a file located in etc/decoders/custom_directory/local_decoders.xml. The file should be deleted.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

JuanGarriuz

LGTM
Test: #5734 (comment)

lucianogorza

TEST:✔️
CR:✔️

LGTM

…o fix/5176-manage-rules-decoders-file

github-actions · 2023-08-11T14:18:08Z

Code coverage (Jest)	%	values
Statements	11.48%	( 3959 / 34486 )
Branches	7.57%	( 1775 / 23422 )
Functions	10.86%	( 896 / 8246 )
Lines	11.66%	( 3847 / 32977 )

fix: added relative_dirname to endpoints to get the rule or decoder file

5a1fd70

Desvelao requested a review from a team as a code owner July 24, 2023 15:23

Desvelao self-assigned this Jul 24, 2023

Desvelao marked this pull request as draft July 24, 2023 15:24

Desvelao linked an issue Jul 24, 2023 that may be closed by this pull request

Use new default_ruleset parameter when reading rules and decoders file content #5176

Closed

Desvelao added backport 4.6.0-7.10 labels Jul 24, 2023

Desvelao and others added 2 commits August 8, 2023 15:48

fix: update put and delete custom rules and decoders files

1ce1525

Merge branch '4.6.0' into fix/5176-manage-rules-decoders-file

b5df164

asteriscos marked this pull request as ready for review August 10, 2023 14:45

lucianogorza self-requested a review August 10, 2023 18:28

Fix error deleting decoders

19d965c

Tostti previously approved these changes Aug 11, 2023

View reviewed changes

changelog: add entry

e87f342

Desvelao dismissed Tostti’s stale review via e87f342 August 11, 2023 10:51

JuanGarriuz self-requested a review August 11, 2023 11:31

JuanGarriuz previously approved these changes Aug 11, 2023

View reviewed changes

lucianogorza previously approved these changes Aug 11, 2023

View reviewed changes

Desvelao removed backport 4.6.0-7.10 labels Aug 11, 2023

Merge branch '4.6.0' of https://github.com/wazuh/wazuh-kibana-app int…

5d16e9b

…o fix/5176-manage-rules-decoders-file

Desvelao dismissed stale reviews from lucianogorza and JuanGarriuz via 5d16e9b August 11, 2023 14:13

Tostti approved these changes Aug 11, 2023

View reviewed changes

Tostti merged commit 8500a13 into 4.6.0 Aug 11, 2023
2 checks passed

Tostti deleted the fix/5176-manage-rules-decoders-file branch August 11, 2023 14:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix management of custom rule and decoders files #5734

Fix management of custom rule and decoders files #5734

Desvelao commented Jul 24, 2023 •

edited

Tostti commented Aug 10, 2023 •

edited

lucianogorza commented Aug 10, 2023 •

edited

Tostti left a comment

JuanGarriuz commented Aug 11, 2023 •

edited

JuanGarriuz left a comment •

edited

lucianogorza left a comment

github-actions bot commented Aug 11, 2023

Fix management of custom rule and decoders files #5734

Fix management of custom rule and decoders files #5734

Conversation

Desvelao commented Jul 24, 2023 • edited

Description

Issues Resolved

Evidence

Test

Wazuh dashboard

UI

Check List

Tostti commented Aug 10, 2023 • edited

UI

lucianogorza commented Aug 10, 2023 • edited

UI

Tostti left a comment

Choose a reason for hiding this comment

JuanGarriuz commented Aug 11, 2023 • edited

UI

JuanGarriuz left a comment • edited

Choose a reason for hiding this comment

lucianogorza left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 11, 2023

Desvelao commented Jul 24, 2023 •

edited

Tostti commented Aug 10, 2023 •

edited

lucianogorza commented Aug 10, 2023 •

edited

JuanGarriuz commented Aug 11, 2023 •

edited

JuanGarriuz left a comment •

edited