Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed install macOS agent commands #5888

Merged
merged 6 commits into from
Sep 13, 2023
Merged

Fixed install macOS agent commands #5888

merged 6 commits into from
Sep 13, 2023

Conversation

Machi3mfl
Copy link
Member

@Machi3mfl Machi3mfl commented Sep 12, 2023 •
edited
Loading

Description

Fix the macOS installation command

Closes #5886

Evidence

Intel (intel64)

Captura de pantalla 2023-09-12 a la(s) 13 57 12

Captura de pantalla 2023-09-12 a la(s) 13 57 21

curl -so wazuh-agent.pkg https://packages.wazuh.com/4.x/macos/wazuh-agent-4.6.0-1.intel64.pkg && echo "WAZUH_MANAGER='0.0.0.0' && WAZUH_AGENT_NAME='agent-name'" > /tmp/wazuh_envs && sudo installer -pkg ./wazuh-agent.pkg -target /

Command output

Captura de pantalla 2023-09-12 a la(s) 13 50 56

ossec.conf with parameters specified

Captura de pantalla 2023-09-12 a la(s) 13 50 35

Apple silicon (arm64)

Captura de pantalla 2023-09-12 a la(s) 13 57 52

Captura de pantalla 2023-09-12 a la(s) 13 58 11

curl -so wazuh-agent.pkg https://packages.wazuh.com/4.x/macos/wazuh-agent-4.6.0-1.arm64.pkg && echo "WAZUH_MANAGER='0.0.0.0' && WAZUH_AGENT_NAME='agent-name'" > /tmp/wazuh_envs && sudo installer -pkg ./wazuh-agent.pkg -target /

Command output

image

ossec.conf with parameters specified

image

Test

  1. Go to Agents section
  2. Click Deploy new agent button
  3. Select macOS operting system and complete the form
  4. Check the installation and start commands

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Machi3mfl Machi3mfl requested a review from a team as a code owner September 12, 2023 17:01
@Machi3mfl Machi3mfl linked an issue Sep 12, 2023 that may be closed by this pull request
[Register Agent] Wrong macos installation command - 4.6.0 #5886
Closed
jbiset
jbiset previously approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢

TEST UI

🟢 Intel (intel64)

Intel64_OS_Selector

Intel64_Commands

🟢 Apple silicon (arm64)

AppleSilicon_OS_Selector

AppleSilicon_Commands

@Machi3mfl Machi3mfl changed the title Fix macos installation commands Fixed macos installation commands Sep 12, 2023
@Machi3mfl Machi3mfl changed the title Fixed macos installation commands Fixed install macOS agent commands Sep 12, 2023
jbiset
jbiset previously approved these changes Sep 12, 2023
View reviewed changes
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 11.47% ( 3960 / 34497 )
Branches 7.57% ( 1776 / 23432 )
Functions 10.86% ( 896 / 8248 )
Lines 11.65% ( 3849 / 33026 )

Tostti
Tostti approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

Intel 🟢
image

Apple silicon 🟢
image

TEST:✔️
CR:✔️

LGTM

@Tostti Tostti merged commit 03b6350 into 4.6.0 Sep 13, 2023
2 checks passed
@Tostti Tostti deleted the fix/5886-wrong-macos-installation-command branch September 13, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao left review comments

@Tostti Tostti Tostti approved these changes

@jbiset jbiset jbiset approved these changes

Assignees

@Machi3mfl Machi3mfl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Register Agent] Wrong macos installation command - 4.6.0
4 participants
@Machi3mfl @Desvelao @Tostti @jbiset