Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix agent name text in dark mode #6018

Merged
merged 2 commits into from Oct 18, 2023
Merged

Fix agent name text in dark mode #6018

merged 2 commits into from Oct 18, 2023

Conversation

Tostti
Copy link
Member

@Tostti Tostti commented Oct 18, 2023 •
edited

Description

This PR aims to fix an issue detected in #6000 regarding the color of the agent's name text in the group selector while using dark mode

Issues Resolved

#6016

Evidence

image
image

Test

  1. Enable dark mode in Stack Management
  2. Navigate to management/groups
  3. Select a group and go to Manage Agents
  4. Verify that the text is clearly visible

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Tostti Tostti requested a review from a team as a code owner October 18, 2023 15:42
@Tostti Tostti self-assigned this Oct 18, 2023
@Tostti Tostti linked an issue Oct 18, 2023 that may be closed by this pull request
Agent name not visible in dark mode #6016
Closed
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 11.71% ( 4041 / 34486 )
Branches 7.96% ( 1855 / 23291 )
Functions 11.21% ( 925 / 8246 )
Lines 11.89% ( 3929 / 33021 )

@lucianogorza
Copy link
Member

CR 🟢

Test 🟢

dark_mode
light_mode

LGTM!

jbiset
jbiset approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🟢

TEST UI 🟢

Dark mode

Evidence_dark

Light mode

Evidence_light

@Tostti Tostti merged commit a316a98 into 4.7.0 Oct 18, 2023
2 checks passed
@Tostti Tostti deleted the 6016-fix-agent-name-dark-mode branch October 18, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbiset jbiset jbiset approved these changes

@lucianogorza lucianogorza lucianogorza approved these changes

Assignees

@Tostti Tostti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Agent name not visible in dark mode
3 participants
@Tostti @lucianogorza @jbiset