Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove application menu in the IT Hygiene #6176

Merged
merged 5 commits into from
Dec 1, 2023
Merged

Remove application menu in the IT Hygiene #6176

merged 5 commits into from
Dec 1, 2023

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Nov 29, 2023 •
edited
Loading

Description

This pull request removes the application menu in the IT Hygiene and add a button to redirect to Endpoints Summary.

Changes:

  • Remove application menu of IT Hygiene application
  • Add a link to Endpoint Summary to the IT Hygiene application
  • Refactor the responsive of the header buttons using styles instead of controlled by JS
  • Changed the icon of the Endpoint Summary application
  • Removed unused files and styles

Issues Resolved

#6169

Evidence

The side menu is open and locked. Windows size not large.
image

The side menu is open and locked. Windows size large.
image

The side menu is closed. Windows size not large.
image

The side menu is closed. Windows size large.
image

Hot to lock the side menu
image

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
With a large window size and side menu is opened and locked, the header of the IT Hygiene application should display buttons with icon and text ⚫ ⚫ ⚫
With no large window size and side menu is opened and locked, the header of IT Hygiene application should display buttons only icon with a tooltip when hoovering ⚫ ⚫ ⚫
With a large window size and side menu closed, the header of the IT Hygiene application should display buttons with icon and text ⚫ ⚫ ⚫
With no large window size and side menu is closed, the header of the IT Hygiene application should display buttons only icon with a tooltip when hoovering ⚫ ⚫ ⚫
The Endpoint Summary header button in the IT Hygiene application should redirect to Endpoint Summary ⚫ ⚫ ⚫

Details

⚫ With a large window size and side menu is opened and locked, the header of the IT Hygiene application should display buttons with icon and text

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ With no large window size and side menu is opened and locked, the header of IT Hygiene application should display buttons only icon with a tooltip when hoovering

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ With a large window size and side menu closed, the header of the IT Hygiene application should display buttons with icon and text

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ With no large window size and side menu is closed, the header of the IT Hygiene application should display buttons only icon with a tooltip when hoovering

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ The Endpoint Summary header button in the IT Hygiene application should redirect to Endpoint Summary

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Desvelao
feat: remove application menu in IT Hygiene application
57db450 
- Remove application menu
- Add link to Endpoint Summary
- Refactor the responsive of header button using styles instead of
  controlled by JS
- Changed the icon of Endpoint Summary application
@Desvelao
fix: remove unused files and styles
9ce696d
@Desvelao Desvelao requested a review from a team as a code owner November 29, 2023 13:24
@Desvelao Desvelao self-assigned this Nov 29, 2023
@Desvelao Desvelao linked an issue Nov 29, 2023 that may be closed by this pull request
Remove the top-left navigation menu of the IT Hygiene view #6169
Closed
@chantal-kelm chantal-kelm self-requested a review November 30, 2023 14:15
chantal-kelm
chantal-kelm reviewed Nov 30, 2023
View reviewed changes
Copy link
Member

@chantal-kelm chantal-kelm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
TEST: ✅

The side menu is open and locked. Windows size not large:
image

The side menu is open and locked. Windows size large:
image

The side menu is closed. Windows size not large:
image

The side menu is closed. Windows size large:
image

@lucianogorza lucianogorza self-requested a review November 30, 2023 18:00
@lucianogorza
Copy link
Member

lucianogorza commented Nov 30, 2023 •
edited
Loading

UI Test

Test Chrome Firefox Safari
With a large window size and side menu is opened and locked, the header of the IT Hygiene application should display buttons with icon and text 🟢 ⚫ ⚫
With no large window size and side menu is opened and locked, the header of IT Hygiene application should display buttons only icon with a tooltip when hoovering 🟢 ⚫ ⚫
With a large window size and side menu closed, the header of the IT Hygiene application should display buttons with icon and text 🟢 ⚫ ⚫
With no large window size and side menu is closed, the header of the IT Hygiene application should display buttons only icon with a tooltip when hoovering 🟢 ⚫ ⚫
The Endpoint Summary header button in the IT Hygiene application should redirect to Endpoint Summary 🟢 ⚫ ⚫

Details

🟢 With a large window size and side menu is opened and locked, the header of the IT Hygiene application should display buttons with icon and text

Chrome - 🟢
image

🟢 With no large window size and side menu is opened and locked, the header of IT Hygiene application should display buttons only icon with a tooltip when hoovering

Chrome - 🟢
image

🟢 With a large window size and side menu closed, the header of the IT Hygiene application should display buttons with icon and text

Chrome - 🟢
image

🟢 With no large window size and side menu is closed, the header of the IT Hygiene application should display buttons only icon with a tooltip when hoovering

Chrome - 🟢
image

🟢 The Endpoint Summary header button in the IT Hygiene application should redirect to Endpoint Summary

Chrome - 🟢
IT Hygiene

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023

Wazuh Core plugin code coverage (Jest) test % values
Statements 21.38% ( 185 / 865 )
Branches 18.07% ( 79 / 437 )
Functions 14.22% ( 36 / 253 )
Lines 21.61% ( 182 / 842 )

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.68% ( 171 / 223 )
Branches 57.57% ( 57 / 99 )
Functions 61.7% ( 29 / 47 )
Lines 76.68% ( 171 / 223 )

chantal-kelm
chantal-kelm approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
TEST: ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023

Main plugin code coverage (Jest) test % values
Statements 12.04% ( 4137 / 34349 )
Branches 8.16% ( 1883 / 23062 )
Functions 11.46% ( 934 / 8149 )
Lines 12.21% ( 4026 / 32948 )

@asteriscos asteriscos merged commit 2fc0406 into 4.8.0 Dec 1, 2023
4 checks passed
@asteriscos asteriscos deleted the feat/6169-remove-it-hygiene-menu branch December 1, 2023 11:01
@asteriscos asteriscos mentioned this pull request Dec 14, 2023
Closed
1 task
@asteriscos asteriscos mentioned this pull request Jan 15, 2024
Closed
1 task
@lucianogorza lucianogorza mentioned this pull request Feb 6, 2024
Closed
1 task
@asteriscos asteriscos mentioned this pull request Feb 26, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteriscos asteriscos asteriscos approved these changes

@chantal-kelm chantal-kelm chantal-kelm approved these changes

@lucianogorza lucianogorza Awaiting requested review from lucianogorza

Assignees

@Desvelao Desvelao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the top-left navigation menu of the IT Hygiene view
4 participants
@Desvelao @lucianogorza @asteriscos @chantal-kelm