Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error when a column with no value is selected to show in the vulnerabilities inventory table #6179

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Fix error when a column with no value is selected to show in the vulnerabilities inventory table #6179

merged 3 commits into from
Nov 30, 2023

Conversation

Machi3mfl
Copy link
Member

@Machi3mfl Machi3mfl commented Nov 29, 2023 •
edited
Loading

Description

This PR,
solves an error when clicking on the show all button from the inventory columns selector.

The error was triggered when the column didn't have a value (empty value) to show.

Solves #6164

Test

  • Go to the Vulnerabilities Inventory tab
  • Open the columns selector
  • Click on the show all button
  • Check if all the columns are shown and not throw error

### Before

image

After

Screen.Recording.2023-11-29.at.16.59.10.mov

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Machi3mfl Machi3mfl requested a review from a team as a code owner November 29, 2023 20:03
@Desvelao Desvelao linked an issue Nov 30, 2023 that may be closed by this pull request
[Vulnerabilities Inventory] Error when click on show all button in columns selector #6164
Closed
Desvelao
Desvelao previously approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Test evidence:
image

Should we add the pull request entry to the changelog?

@Machi3mfl Machi3mfl changed the title Fix the vulnerabilities inventory table columns selector error Fix error when column with no value is selected to show in the vulnerabilities inventory table Nov 30, 2023
@Machi3mfl Machi3mfl changed the title Fix error when column with no value is selected to show in the vulnerabilities inventory table Fix error when a column with no value is selected to show in the vulnerabilities inventory table Nov 30, 2023
@Machi3mfl
Copy link
Member Author

LGTM!

Test evidence: image

Should we add the pull request entry to the changelog?

Yes, I forgot to update the CHANGELOG. It was updated in e11262b commit

@JuanGarriuz JuanGarriuz self-requested a review November 30, 2023 12:07
JuanGarriuz
JuanGarriuz previously approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!
image

Desvelao
Desvelao approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.68% ( 171 / 223 )
Branches 57.57% ( 57 / 99 )
Functions 61.7% ( 29 / 47 )
Lines 76.68% ( 171 / 223 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 21.38% ( 185 / 865 )
Branches 18.07% ( 79 / 437 )
Functions 14.22% ( 36 / 253 )
Lines 21.61% ( 182 / 842 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.01% ( 4137 / 34443 )
Branches 8.15% ( 1890 / 23164 )
Functions 11.39% ( 934 / 8197 )
Lines 12.18% ( 4026 / 33037 )

JuanGarriuz
JuanGarriuz approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@Desvelao Desvelao merged commit a61d777 into 4.8.0 Nov 30, 2023
4 checks passed
@Desvelao Desvelao deleted the fix/6164-inventory-vuls-toggle-columns-visibility-error branch November 30, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao approved these changes

@JuanGarriuz JuanGarriuz JuanGarriuz approved these changes

Assignees

@Machi3mfl Machi3mfl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Vulnerabilities Inventory] Error when click on show all button in columns selector
3 participants
@Machi3mfl @Desvelao @JuanGarriuz