Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the endpoint to get Wazuh manager auth configuration #6206

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

asteriscos
Copy link
Member

Description

This pull request aims to use a manager or cluster endpoint to get the authentication configuration of the Wazuh server. Previously it used the agent endpoint filtered by the manager ID 000, which may cause RBAC issues.

It also fixes the order of the RBAC options in the create/edit policies view, so they appear in alphabetical order.

Issues Resolved

Closes #6203

Evidence

GET auth request

image

Ascending order of the RBAC options

image

Test

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos self-assigned this Dec 12, 2023
@asteriscos asteriscos requested a review from a team as a code owner December 12, 2023 18:00
Copy link
Contributor

Code coverage (Jest) % values
Statements 11.73% ( 4048 / 34502 )
Branches 7.96% ( 1855 / 23297 )
Functions 11.26% ( 930 / 8256 )
Lines 11.91% ( 3937 / 33042 )

@asteriscos asteriscos linked an issue Dec 12, 2023 that may be closed by this pull request
@lucianogorza lucianogorza self-requested a review December 12, 2023 18:14
@lucianogorza
Copy link
Member

lucianogorza commented Dec 12, 2023

CR ✅

Test ✅

GET auth request

image

Configure a password in the manager and check the register agent wizard sets the password properly in the script

image

Check the actions SuperSelect options are in alphabetical order

image

LGTM

Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

  • Check the manager auth configuration request uses either the manager or cluster endpoint:
    image
    image

  • Configure a password in the manager and check the register agent wizard sets the password properly in the script:
    image

  • Check the actions SuperSelect options are in alphabetical order:
    image

Test ✅
CR ✅

LGTM

@asteriscos asteriscos merged commit bc56ba9 into 4.7.2 Dec 13, 2023
2 checks passed
@asteriscos asteriscos deleted the fix/change-cluster-auth-request-6203 branch December 13, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the endpoint to get Wazuh manager auth configuration
3 participants