Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize titles and subtitles in the register agent wizard #6208

Merged
merged 4 commits into from Dec 13, 2023
Merged

Standardize titles and subtitles in the register agent wizard #6208

merged 4 commits into from Dec 13, 2023

Conversation

JuanGarriuz
Copy link
Member

Description

  • Add colons : at the end of wizard titles
  • Add colons : to input labels
  • Add an info callout specifying if the script is in Powershell (Windows) or shell bash (Linux). It should also mention when administrator permissions are needed.
  • Change the description of the optional setting
  • Remove the word Wazuh each time an agent is mentioned

Issues Resolved

#6202

Evidence

image
image
image

Test

  • Try all cases shown in evidence

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@JuanGarriuz JuanGarriuz requested a review from a team as a code owner December 13, 2023 11:58
@JuanGarriuz JuanGarriuz changed the title Feat/6202 standardize titles and subtitles in the register agent wizard Standardize titles and subtitles in the register agent wizard Dec 13, 2023
@JuanGarriuz JuanGarriuz changed the base branch from master to 4.7.2 December 13, 2023 11:59
@JuanGarriuz JuanGarriuz self-assigned this Dec 13, 2023
@JuanGarriuz JuanGarriuz linked an issue Dec 13, 2023 that may be closed by this pull request
Standardize titles and subtitles in the register agent wizard #6202
Closed
5 tasks
yenienserrano
yenienserrano previously approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

image
image

image

image

@github-actions GitHub Actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 11.73% ( 4048 / 34504 )
Branches 7.96% ( 1855 / 23299 )
Functions 11.26% ( 930 / 8257 )
Lines 11.91% ( 3937 / 33044 )

@asteriscos asteriscos merged commit f871ede into 4.7.2 Dec 13, 2023
2 checks passed
@asteriscos asteriscos deleted the feat/6202-standardize-titles-and-subtitles-in-the-register-agent-wizard branch December 13, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Machi3mfl Machi3mfl Machi3mfl approved these changes

@yenienserrano yenienserrano yenienserrano left review comments

Assignees

@JuanGarriuz JuanGarriuz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standardize titles and subtitles in the register agent wizard
4 participants
@JuanGarriuz @Machi3mfl @yenienserrano @asteriscos