Replace discover Office 365 #6290

yenienserrano · 2024-01-09T17:11:03Z

Description

This PR, replaces the events tab on the Office 365 module

Issues Resolved

[Remove discover] Replace discover on Office 365 module #6282

Evidence

Tests

Search bar

Test	Chrome	Firefox	Safari
Apply filters using search bar input	⚫	⚫	⚫
Apply filters using the search bar `add filter` feature	⚫	⚫	⚫
Apply filters using the date picker	⚫	⚫	⚫
Apply filters with no results (Check the `No results match your search criteria` message)	⚫	⚫	⚫
Use the `saved queries` feature (Check saved queries CRUD)	⚫	⚫	⚫

Apply filters using search bar input

Apply filters using the search bar add filter feature

Apply filters using the date picker

Apply filters with no results (Check the No results match your search criteria message)

Use the saved queries feature (Check saved queries CRUD)

Histogram chart

Test	Chrome	Firefox	Safari
Check histogram chart hits consistency	⚫	⚫	⚫
Use chart options (three points: maximize, minimize, inspect)	⚫	⚫	⚫

Check histogram chart hits consistency

Use chart options (three points: maximize, minimize, inspect)

Data grid

Test	Chrome	Firefox	Safari
Check all table header features (sort, show/hide columns, density, etc)	⚫	⚫	⚫
Check table pagination and rows per page	⚫	⚫	⚫
Check document detail flyout	⚫	⚫	⚫

Check all table header features (sort, show/hide columns, density, etc)

Check table pagination and rows per page

Check document detail flyout

Check List

All tests pass
- yarn test:jest
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

Machi3mfl

Tests

Search bar

Test	Chrome	Firefox	Safari
Apply filters using search bar input	🟢	⚫	⚫
Apply filters using the search bar `add filter` feature	🟢	⚫	⚫
Apply filters using the date picker	🟢	⚫	⚫
Apply filters with no results (Check the `No results match your search criteria` message)	🟢	⚫	⚫
Use the `saved queries` feature (Check saved queries CRUD)	⚫	🟢	⚫

Apply filters using search bar input

Screen.Recording.2024-01-10.at.15.03.40.mov

Apply filters using the search bar add filter feature

Screen.Recording.2024-01-10.at.15.06.32.mov

Apply filters using the date picker

Screen.Recording.2024-01-10.at.15.07.28.mov

Apply filters with no results (Check the No results match your search criteria message)

Screen.Recording.2024-01-10.at.15.08.00.mov

Use the saved queries feature (Check saved queries CRUD)

Screen.Recording.2024-01-10.at.15.11.35.mov

Histogram chart

Test	Chrome	Firefox	Safari
Check histogram chart hits consistency	🟢	⚫	⚫
Use chart options (three points: maximize, minimize, inspect)	🟢	⚫	⚫

Check histogram chart hits consistency

Screen.Recording.2024-01-10.at.15.08.35.mov

Use chart options (three points: maximize, minimize, inspect)

Screen.Recording.2024-01-10.at.15.09.18.mov

Data grid

Test	Chrome	Firefox	Safari
Check all table header features (sort, show/hide columns, density, etc)	🔴	⚫	⚫
Check table pagination and rows per page	🟢	⚫	⚫
Check document detail flyout	🟢	⚫	⚫

Check all table header features (sort, show/hide columns, density, etc)

Error when clicked on Show all columns

Screen.Recording.2024-01-10.at.15.10.00.mov

Check table pagination and rows per page

Screen.Recording.2024-01-10.at.15.13.17.mov

Check document detail flyout

Screen.Recording.2024-01-10.at.15.13.43.mov

JuanGarriuz · 2024-02-05T09:10:03Z

Tests

Search bar

Test	Chrome	Firefox	Safari
Apply filters using search bar input	🟢	⚫	⚫
Apply filters using the search bar `add filter` feature	🟢	⚫	⚫
Apply filters using the date picker	🟢	⚫	⚫
Apply filters with no results (Check the `No results match your search criteria` message)	🟢	⚫	⚫
Use the `saved queries` feature (Check saved queries CRUD)	🟡	⚫	⚫

🟢Apply filters using search bar input

🟢Apply filters using the search bar `add filter` feature

🟢Apply filters using the date picker

🟢Apply filters with no results (Check the `No results match your search criteria` message)

🟡 Use the `saved queries` feature (Check saved queries CRUD)

When using the clear of the save query, filters that perhaps should be maintained are removed.

Histogram chart

Test	Chrome	Firefox	Safari
Check histogram chart hits consistency	🟢	⚫	⚫
Use chart options (three points: maximize, minimize, inspect)	🟡	⚫	⚫

🟢Check histogram chart hits consistency

🟡Use chart options (three points: maximize, minimize, inspect)

It's more of a visual bug, but the data is marked as if it's in a continuous hover state, giving the impression that you are on that tab.

Data grid

Test	Chrome	Firefox	Safari
Check all table header features (sort, show/hide columns, density, etc)	🟢	⚫	⚫
Check table pagination and rows per page	🟢	⚫	⚫
Check document detail flyout	🟢	⚫	⚫

🟢Check all table header features (sort, show/hide columns, density, etc)

🟢Check table pagination and rows per page

🟢Check document detail flyout

JuanGarriuz

LGTM!!

github-actions · 2024-02-08T11:20:08Z

Wazuh Core plugin code coverage (Jest) test	%	values
Statements	21.38%	( 176 / 823 )
Branches	19.45%	( 79 / 406 )
Functions	14.17%	( 36 / 254 )
Lines	21.57%	( 173 / 802 )

github-actions · 2024-02-08T11:20:44Z

Wazuh Check Updates plugin code coverage (Jest) test	%	values
Statements	76.44%	( 172 / 225 )
Branches	58.65%	( 61 / 104 )
Functions	61.7%	( 29 / 47 )
Lines	76.44%	( 172 / 225 )

github-actions · 2024-02-08T11:24:10Z

Main plugin code coverage (Jest) test	%	values
Statements	11.62%	( 4009 / 34498 )
Branches	7.7%	( 1753 / 22760 )
Functions	11.19%	( 925 / 8261 )
Lines	11.79%	( 3897 / 33038 )

lucianogorza · 2024-02-09T14:27:41Z

CR 🟢

Test 🟢

Test	Chrome	Firefox	Safari
Apply filters using search bar input	🟢	⚫	⚫
Apply filters using the search bar `add filter` feature	🟢	⚫	⚫
Apply filters using the date picker	🟢	⚫	⚫
Apply filters with no results (Check the `No results match your search criteria` message)	🟢	⚫	⚫
Use the `saved queries` feature (Check saved queries CRUD)	🟡	⚫	⚫

Apply filters using search bar input 🟢

Apply filters using the search bar add filter feature 🟢

Apply filters using the date picker 🟢

Apply filters with no results (Check the No results match your search criteria message) 🟢

Use the saved queries feature (Check saved queries CRUD) 🟡

Clear saved query 🟡

On clear saved query implicit filters are deleted

Histogram chart

Test	Chrome	Firefox	Safari
Check histogram chart hits consistency	🟢	⚫	⚫
Use chart options (three points: maximize, minimize, inspect)	🟢	⚫	⚫

Check histogram chart hits consistency 🟢

Use chart options (three points: maximize, minimize, inspect) 🟢

Maximize

Inspect

Download CSV

Filter by value

Data grid

Test	Chrome	Firefox	Safari
Check all table header features (sort, show/hide columns, density, etc)	🟡	⚫	⚫
Check table pagination and rows per page	🟢	⚫	⚫
Check document detail flyout	🟢	⚫	⚫

Check all table header features (sort, show/hide columns, density, etc) 🟡

Sort 🟡

When drag field inside sort popup the background becomes red

Column selector 🟢

Density 🟢

Full screen 🟢

Export 🟢

Check table pagination and rows per page 🟢

15 rows per page

50 rows per page

Check document detail flyout 🟢

lucianogorza

LGTM

Replace discover

b2d1aa9

yenienserrano requested a review from a team as a code owner January 9, 2024 17:11

yenienserrano self-assigned this Jan 9, 2024

yenienserrano linked an issue Jan 9, 2024 that may be closed by this pull request

[Remove discover] Replace discover on Office 365 module #6282

Closed

1 task

yenienserrano and others added 2 commits January 9, 2024 18:11

Add changelog

ce5beb1

Merge branch 'master' into feat/6282-replace-discover-office

a8ae67a

Machi3mfl self-requested a review January 10, 2024 18:01

Machi3mfl requested changes Jan 10, 2024

View reviewed changes

jbiset and others added 2 commits January 10, 2024 17:21

Merge branch 'master' into feat/6282-replace-discover-office

08e3ec7

Stringify geo_point type field

3d6b79f

yenienserrano requested a review from Machi3mfl February 2, 2024 14:59

yenienserrano mentioned this pull request Feb 5, 2024

Replace discover Google cloud #6289

Merged

6 tasks

JuanGarriuz approved these changes Feb 5, 2024

View reviewed changes

Merge branch 'master' into feat/6282-replace-discover-office

76ffcac

lucianogorza approved these changes Feb 9, 2024

View reviewed changes

asteriscos merged commit 3de2cc0 into master Feb 9, 2024
4 checks passed

asteriscos deleted the feat/6282-replace-discover-office branch February 9, 2024 17:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace discover Office 365 #6290

Replace discover Office 365 #6290

yenienserrano commented Jan 9, 2024

Machi3mfl left a comment

JuanGarriuz commented Feb 5, 2024 •

edited

Loading

JuanGarriuz left a comment

github-actions bot commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

lucianogorza commented Feb 9, 2024 •

edited

Loading

Clear saved query 🟡

Maximize

Inspect

Download CSV

Filter by value

Sort 🟡

Column selector 🟢

Density 🟢

Full screen 🟢

Export 🟢

15 rows per page

50 rows per page

lucianogorza left a comment

Replace discover Office 365 #6290

Replace discover Office 365 #6290

Conversation

yenienserrano commented Jan 9, 2024

Description

Issues Resolved

Evidence

Tests

Search bar

Histogram chart

Data grid

Check List

Machi3mfl left a comment

Choose a reason for hiding this comment

Tests

Search bar

Histogram chart

Data grid

JuanGarriuz commented Feb 5, 2024 • edited Loading

Tests

Search bar

Histogram chart

Data grid

JuanGarriuz left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

lucianogorza commented Feb 9, 2024 • edited Loading

CR 🟢

Test 🟢

Clear saved query 🟡

Histogram chart

Maximize

Inspect

Download CSV

Filter by value

Data grid

Sort 🟡

Column selector 🟢

Density 🟢

Full screen 🟢

Export 🟢

15 rows per page

50 rows per page

lucianogorza left a comment

Choose a reason for hiding this comment

JuanGarriuz commented Feb 5, 2024 •

edited

Loading

lucianogorza commented Feb 9, 2024 •

edited

Loading