Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace discover PCI DSS, GDPR, HIPAA, TSC and NIST 800-53 modules #6297

Merged
merged 8 commits into from Feb 19, 2024

Conversation

JuanGarriuz
Copy link
Member

@JuanGarriuz JuanGarriuz commented Jan 10, 2024

Description

This PR, replaces the events tab on the PCI DSS, GDPR, HIPAA, TSC and NIST 800-53 modules

Issues Resolved

PCI DSS module
GDPR module
HIPAA module
TSC module
NIST 800-53 module

Evidence

PCI DSS

image

GDPR

image

HIPAA

image

NIST 800-53

image

TSC

image

Tests

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input
Apply filters using the search bar add filter feature
Apply filters using the date picker
Apply filters with no results (Check the No results match your search criteria message)
Use the saved queries feature (Check saved queries CRUD)
Apply filters using search bar input
Apply filters using the search bar `add filter` feature
Apply filters using the date picker
Apply filters with no results (Check the `No results match your search criteria` message)
Use the `saved queries` feature (Check saved queries CRUD)

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency
Use chart options (three points: maximize, minimize, inspect)
Check histogram chart hits consistency
Use chart options (three points: maximize, minimize, inspect)

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc)
Check table pagination and rows per page
Check document detail flyout
Check all table header features (sort, show/hide columns, density, etc)
Check table pagination and rows per page
Check document detail flyout

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@JuanGarriuz JuanGarriuz linked an issue Jan 10, 2024 that may be closed by this pull request
1 task
@JuanGarriuz JuanGarriuz self-assigned this Jan 10, 2024
@JuanGarriuz JuanGarriuz changed the title Replace discover PCI Replace discover PCI DSS, GDPR, HIPAA, TSC and NIST 800-53 modules Jan 10, 2024
@JuanGarriuz JuanGarriuz marked this pull request as ready for review January 10, 2024 14:49
@JuanGarriuz JuanGarriuz requested a review from a team as a code owner January 10, 2024 14:49
@yenienserrano
Copy link
Member

yenienserrano commented Feb 5, 2024

PCI DSS

Test Chrome Firefox Safari
Apply filters using search bar input 🟢
Apply filters using the search bar add filter feature 🟢
Apply filters using the date picker 🟢
Apply filters with no results (Check the No results match your search criteria message) 🟢
Use the saved queries feature (Check saved queries CRUD) 🟢
Apply filters using search bar input

image

Apply filters using the search bar `add filter` feature

image

Apply filters using the date picker

image

Apply filters with no results (Check the `No results match your search criteria` message)

image

Use the `saved queries` feature (Check saved queries CRUD)

image

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency 🟢
Use chart options (three points: maximize, minimize, inspect) 🟢
Check histogram chart hits consistency

image

Use chart options (three points: maximize, minimize, inspect)

image

image

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc) 🟢
Check table pagination and rows per page 🟢
Check document detail flyout 🟢
Check all table header features (sort, show/hide columns, density, etc)

image

image

image

image

image

image

Check table pagination and rows per page

image

image

Check document detail flyout

image

@yenienserrano yenienserrano self-requested a review February 5, 2024 11:00
@yenienserrano
Copy link
Member

GDPR

Test Chrome Firefox Safari
Apply filters using search bar input 🟢
Apply filters using the search bar add filter feature 🟢
Apply filters using the date picker 🟢
Apply filters with no results (Check the No results match your search criteria message) 🟢
Use the saved queries feature (Check saved queries CRUD) 🟢
Apply filters using search bar input

image

Apply filters using the search bar `add filter` feature

image

Apply filters using the date picker

image

Apply filters with no results (Check the `No results match your search criteria` message)

image

Use the `saved queries` feature (Check saved queries CRUD)

image

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency 🟢
Use chart options (three points: maximize, minimize, inspect) 🟢
Check histogram chart hits consistency

image

Use chart options (three points: maximize, minimize, inspect)

image

image

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc) 🟢
Check table pagination and rows per page 🟢
Check document detail flyout 🟢
Check all table header features (sort, show/hide columns, density, etc)

image

image

image

image

image

Check table pagination and rows per page

image

Check document detail flyout

image

@yenienserrano
Copy link
Member

HIPAA

Test Chrome Firefox Safari
Apply filters using search bar input 🟢
Apply filters using the search bar add filter feature 🟢
Apply filters using the date picker 🟢
Apply filters with no results (Check the No results match your search criteria message) 🟢
Use the saved queries feature (Check saved queries CRUD) 🟢
Apply filters using search bar input

image

Apply filters using the search bar `add filter` feature

image

Apply filters using the date picker

image

Apply filters with no results (Check the `No results match your search criteria` message)

image

Use the `saved queries` feature (Check saved queries CRUD)

image

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency 🟢
Use chart options (three points: maximize, minimize, inspect) 🟢
Check histogram chart hits consistency

image

Use chart options (three points: maximize, minimize, inspect)

image

image

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc) 🟢
Check table pagination and rows per page 🟢
Check document detail flyout 🟢
Check all table header features (sort, show/hide columns, density, etc)

image

image

image

image

image

Check table pagination and rows per page

image

Check document detail flyout

image

@yenienserrano
Copy link
Member

NIST 800-53

Test Chrome Firefox Safari
Apply filters using search bar input 🟢
Apply filters using the search bar add filter feature 🟢
Apply filters using the date picker 🟢
Apply filters with no results (Check the No results match your search criteria message) 🟢
Use the saved queries feature (Check saved queries CRUD) 🟢
Apply filters using search bar input

image

Apply filters using the search bar `add filter` feature

image

Apply filters using the date picker

image

Apply filters with no results (Check the `No results match your search criteria` message)

image

Use the `saved queries` feature (Check saved queries CRUD)

image

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency 🟢
Use chart options (three points: maximize, minimize, inspect) 🟢
Check histogram chart hits consistency

image

Use chart options (three points: maximize, minimize, inspect)

image
image

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc) 🟢
Check table pagination and rows per page 🟢
Check document detail flyout 🟢
Check all table header features (sort, show/hide columns, density, etc)

image
image
image
image
image

Check table pagination and rows per page

image

Check document detail flyout

image

@yenienserrano
Copy link
Member

TSC

Test Chrome Firefox Safari
Apply filters using search bar input 🟢
Apply filters using the search bar add filter feature 🟢
Apply filters using the date picker 🟢
Apply filters with no results (Check the No results match your search criteria message) 🟢
Use the saved queries feature (Check saved queries CRUD) 🟢
Apply filters using search bar input

image

Apply filters using the search bar `add filter` feature

image

Apply filters using the date picker

image

Apply filters with no results (Check the `No results match your search criteria` message)

image

Use the `saved queries` feature (Check saved queries CRUD)

image

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency 🟢
Use chart options (three points: maximize, minimize, inspect) 🟢
Check histogram chart hits consistency

image

Use chart options (three points: maximize, minimize, inspect)

image
image

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc) 🟢
Check table pagination and rows per page 🟢
Check document detail flyout 🟢
Check all table header features (sort, show/hide columns, density, etc)

image
image
image
image
image

Check table pagination and rows per page

image

Check document detail flyout

image

yenienserrano
yenienserrano previously approved these changes Feb 5, 2024
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JuanGarriuz JuanGarriuz changed the base branch from master to 4.9.0 February 13, 2024 09:27
@JuanGarriuz JuanGarriuz dismissed yenienserrano’s stale review February 13, 2024 09:27

The base branch was changed.

@Machi3mfl
Copy link
Member

Machi3mfl commented Feb 19, 2024

PCI DSS - Tests

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input 🟢
Apply filters using the search bar add filter feature 🟢
Apply filters using the date picker 🟢
Apply filters with no results (Check the No results match your search criteria message) 🟢
Use the saved queries feature (Check saved queries CRUD) 🟢
Apply filters using search bar input Screenshot 2024-02-19 at 12 11 07
Apply filters using the search bar `add filter` feature Screenshot 2024-02-19 at 12 13 04
Apply filters using the date picker Screenshot 2024-02-19 at 12 14 51
Apply filters with no results (Check the `No results match your search criteria` message) Screenshot 2024-02-19 at 12 15 44
Use the `saved queries` feature (Check saved queries CRUD)
Screen.Recording.2024-02-19.at.12.16.31.mov

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency 🟢
Use chart options (three points: maximize, minimize, inspect) 🟢
Check histogram chart hits consistency Screenshot 2024-02-19 at 13 37 05
Use chart options (three points: maximize, minimize, inspect) Screenshot 2024-02-19 at 13 37 45

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc) 🟢
Check table pagination and rows per page 🟢
Check document detail flyout 🟢
Check all table header features (sort, show/hide columns, density, etc)
Screen.Recording.2024-02-19.at.13.42.34.mov
Check table pagination and rows per page Screenshot 2024-02-19 at 13 44 28
Check document detail flyout Screenshot 2024-02-19 at 13 45 05

@Machi3mfl
Copy link
Member

Machi3mfl commented Feb 19, 2024

DGPR - Tests

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input 🟢
Apply filters using the search bar add filter feature 🟢
Apply filters using the date picker 🟢
Apply filters with no results (Check the No results match your search criteria message) 🟢
Use the saved queries feature (Check saved queries CRUD) 🟢
Apply filters using search bar input
Screen.Recording.2024-02-19.at.15.24.09.mov
Apply filters using the search bar `add filter` feature
Screen.Recording.2024-02-19.at.15.24.33.mov
Apply filters using the date picker
Screen.Recording.2024-02-19.at.15.26.55.mov
Apply filters with no results (Check the `No results match your search criteria` message) Screenshot 2024-02-19 at 15 28 07
Use the `saved queries` feature (Check saved queries CRUD)
Screen.Recording.2024-02-19.at.15.28.51.mov

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency 🟢
Use chart options (three points: maximize, minimize, inspect) 🟢
Check histogram chart hits consistency
Screen.Recording.2024-02-19.at.15.29.45.mov
Use chart options (three points: maximize, minimize, inspect)
Screen.Recording.2024-02-19.at.15.30.20.mov

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc) 🟢
Check table pagination and rows per page 🟢
Check document detail flyout 🟢
Check all table header features (sort, show/hide columns, density, etc)
Screen.Recording.2024-02-19.at.15.31.15.mov
Check table pagination and rows per page
Screen.Recording.2024-02-19.at.15.37.42.mov
Check document detail flyout Screenshot 2024-02-19 at 15 38 11

@Machi3mfl
Copy link
Member

Machi3mfl commented Feb 19, 2024

HIPAA - Tests

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input 🟢
Apply filters using the search bar add filter feature 🟢
Apply filters using the date picker 🟢
Apply filters with no results (Check the No results match your search criteria message) 🟢
Use the saved queries feature (Check saved queries CRUD) 🟢
Apply filters using search bar input
Apply filters using the search bar `add filter` feature
Apply filters using the date picker
Apply filters with no results (Check the `No results match your search criteria` message)
Use the `saved queries` feature (Check saved queries CRUD)

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency 🟢
Use chart options (three points: maximize, minimize, inspect) 🟢
Check histogram chart hits consistency
Use chart options (three points: maximize, minimize, inspect)

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc) 🟢
Check table pagination and rows per page 🟢
Check document detail flyout 🟢
Check all table header features (sort, show/hide columns, density, etc)
Check table pagination and rows per page
Check document detail flyout
Screen.Recording.2024-02-19.at.15.40.40.mov

@Machi3mfl
Copy link
Member

Machi3mfl commented Feb 19, 2024

TSC - Tests

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input 🟢
Apply filters using the search bar add filter feature 🟢
Apply filters using the date picker 🟢
Apply filters with no results (Check the No results match your search criteria message) 🟢
Use the saved queries feature (Check saved queries CRUD) 🟢
Apply filters using search bar input
Apply filters using the search bar `add filter` feature
Apply filters using the date picker
Apply filters with no results (Check the `No results match your search criteria` message)
Use the `saved queries` feature (Check saved queries CRUD)
Screen.Recording.2024-02-19.at.15.56.25.mov

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency 🟢
Use chart options (three points: maximize, minimize, inspect) 🟢
Check histogram chart hits consistency
Use chart options (three points: maximize, minimize, inspect)
Screen.Recording.2024-02-19.at.15.58.33.mov

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc) 🟢
Check table pagination and rows per page 🟢
Check document detail flyout 🟢
Check all table header features (sort, show/hide columns, density, etc)
Check table pagination and rows per page
Check document detail flyout
Screen.Recording.2024-02-19.at.16.02.02.mov

@Machi3mfl
Copy link
Member

Machi3mfl commented Feb 19, 2024

NIST 800-53 - Tests

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input 🟢
Apply filters using the search bar add filter feature 🟢
Apply filters using the date picker 🟢
Apply filters with no results (Check the No results match your search criteria message) 🟢
Use the saved queries feature (Check saved queries CRUD) 🟢
Apply filters using search bar input
Apply filters using the search bar `add filter` feature
Apply filters using the date picker
Apply filters with no results (Check the `No results match your search criteria` message)
Use the `saved queries` feature (Check saved queries CRUD)
Screen.Recording.2024-02-19.at.16.04.14.mov

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency 🟢
Use chart options (three points: maximize, minimize, inspect) 🟢
Check histogram chart hits consistency
Use chart options (three points: maximize, minimize, inspect)
Screen.Recording.2024-02-19.at.16.06.06.mov

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc) 🟢
Check table pagination and rows per page 🟢
Check document detail flyout 🟢
Check all table header features (sort, show/hide columns, density, etc)
Check table pagination and rows per page
Check document detail flyout
Screen.Recording.2024-02-19.at.16.06.50.mov

Machi3mfl
Machi3mfl previously approved these changes Feb 19, 2024
yenienserrano
yenienserrano previously approved these changes Feb 19, 2024
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 21.38% ( 176 / 823 )
Branches 19.45% ( 79 / 406 )
Functions 14.17% ( 36 / 254 )
Lines 21.57% ( 173 / 802 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 11.61% ( 4008 / 34499 )
Branches 7.7% ( 1753 / 22760 )
Functions 11.2% ( 925 / 8258 )
Lines 11.79% ( 3896 / 33038 )

@Machi3mfl Machi3mfl merged commit e70033f into 4.9.0 Feb 19, 2024
4 checks passed
@Machi3mfl Machi3mfl deleted the feat/6295-replace-discover-pci branch February 19, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants