Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide discover deprecation notice #6341

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Hide discover deprecation notice #6341

merged 3 commits into from
Jan 18, 2024

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Jan 18, 2024 •
edited
Loading

Description

The Discover deprecation warning is hidden.

Issues Resolved

Evidence

image

Test

  1. Navigate to the Discover plugin
  2. The Discover deprecation warning should not appear.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano requested a review from a team as a code owner January 18, 2024 09:34
@yenienserrano yenienserrano self-assigned this Jan 18, 2024
@yenienserrano yenienserrano linked an issue Jan 18, 2024 that may be closed by this pull request
Disable the discover legacy callout warning by default #6314
Closed
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 21.42% ( 186 / 868 )
Branches 17.99% ( 79 / 439 )
Functions 14.22% ( 36 / 253 )
Lines 21.65% ( 183 / 845 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.68% ( 171 / 223 )
Branches 57.57% ( 57 / 99 )
Functions 61.7% ( 29 / 47 )
Lines 76.68% ( 171 / 223 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.2% ( 4202 / 34418 )
Branches 8.26% ( 1911 / 23121 )
Functions 11.71% ( 958 / 8176 )
Lines 12.38% ( 4087 / 33009 )

asteriscos
asteriscos approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

image

@jbiset jbiset self-requested a review January 18, 2024 11:18
jbiset
jbiset approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢

Test UI 🟢

Evidence

image

@asteriscos asteriscos merged commit 21fa7f7 into 4.8.0 Jan 18, 2024
4 checks passed
@asteriscos asteriscos deleted the 6314-disable-the-discover-legacy-callout-warning-by-default branch January 18, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteriscos asteriscos asteriscos approved these changes

@jbiset jbiset jbiset approved these changes

Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable the discover legacy callout warning by default
3 participants
@yenienserrano @asteriscos @jbiset