Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove WAZUH_REGISTRATION_SERVER from the windows command #6361

Merged
merged 3 commits into from Jan 24, 2024
Merged

Remove WAZUH_REGISTRATION_SERVER from the windows command #6361

merged 3 commits into from Jan 24, 2024

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Jan 23, 2024 •
edited

Description

This PR removes WAZUH_REGISTRATION_SERVER from the windows agent installation command. This is because the address in this variable is the same as the WAZUH_MANAGER therefore it's redundant.

Issues Resolved

#6348

Screenshot

image

Test

Verify the installation script for windows doesn't include WAZUH_REGISTRATION_SERVER:

Eg.

Invoke-WebRequest -Uri https://packages.wazuh.com/4.x/windows/wazuh-agent-4.8.0-1.msi -OutFile ${env.tmp}\wazuh-agent; msiexec.exe /i ${env.tmp}\wazuh-agent /q WAZUH_MANAGER='server.com' WAZUH_AGENT_GROUP='windows' WAZUH_AGENT_NAME='new-agent'

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos self-assigned this Jan 23, 2024
@asteriscos asteriscos requested a review from a team as a code owner January 23, 2024 11:38
@asteriscos asteriscos linked an issue Jan 23, 2024 that may be closed by this pull request
Remove WAZUH_REGISTRATION_SERVER from Windows deploy cmd #6348
Closed
yenienserrano
yenienserrano approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

image

@lucianogorza lucianogorza self-requested a review January 23, 2024 14:57
lucianogorza
lucianogorza approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@lucianogorza lucianogorza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🟢

Test 🟢

image

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 21.18% ( 186 / 878 )
Branches 17.99% ( 79 / 439 )
Functions 14% ( 36 / 257 )
Lines 21.4% ( 183 / 855 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.78% ( 172 / 224 )
Branches 57.42% ( 58 / 101 )
Functions 61.7% ( 29 / 47 )
Lines 76.78% ( 172 / 224 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.2% ( 4202 / 34418 )
Branches 8.25% ( 1908 / 23118 )
Functions 11.71% ( 958 / 8176 )
Lines 12.38% ( 4087 / 33010 )

@asteriscos asteriscos merged commit dc59dd3 into 4.8.0 Jan 24, 2024
4 checks passed
@asteriscos asteriscos deleted the fix/remove-WAZUH_REGISTRATION_SERVER-from-windows-deploy-cmd branch January 24, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano approved these changes

@lucianogorza lucianogorza lucianogorza approved these changes

Assignees

@asteriscos asteriscos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove WAZUH_REGISTRATION_SERVER from Windows deploy cmd
3 participants
@asteriscos @yenienserrano @lucianogorza