Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed filebeat in development environments #6433

Merged
merged 1 commit into from Feb 20, 2024
Merged

Fixed filebeat in development environments #6433

merged 1 commit into from Feb 20, 2024

Conversation

yenienserrano
Copy link
Member

Description

Filebeat correction in development environments

Issues Resolved

Evidence

image
image

Test

  • Run the environment without any real manager, only the imposter, filebeat should continue to run and the healtcheck should pass.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano self-assigned this Feb 20, 2024
@yenienserrano yenienserrano linked an issue Feb 20, 2024 that may be closed by this pull request
Fix filebeat in development environments #6432
Closed
1 task
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 20.89% ( 186 / 890 )
Branches 17.91% ( 79 / 441 )
Functions 13.89% ( 36 / 259 )
Lines 21.1% ( 183 / 867 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.78% ( 172 / 224 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.78% ( 172 / 224 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.13% ( 4209 / 34686 )
Branches 8.2% ( 1907 / 23247 )
Functions 11.57% ( 956 / 8261 )
Lines 12.3% ( 4097 / 33287 )

JuanGarriuz
JuanGarriuz approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🟢

Test 🟢

image

image

Tostti
Tostti approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

image
image

Test ✅
CR ✅

:LGTM

@Tostti Tostti merged commit 270bd84 into 4.8.0 Feb 20, 2024
4 checks passed
@Tostti Tostti deleted the fix/6432-fix-filebeat-in-development-environments branch February 20, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tostti Tostti Tostti approved these changes

@JuanGarriuz JuanGarriuz JuanGarriuz approved these changes

Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix filebeat in development environments
3 participants
@yenienserrano @Tostti @JuanGarriuz