Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove discover implement embeddable dashboard on aws module #6494

Merged

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Mar 8, 2024

Description

implement the embeddable dashboard on AWS -> dashboard tab and deprecate any use of kibana-integrations components.

Issues Resolved

Evidence

image image

Test

Global

Test Chrome Firefox Safari
Check data results consistency between events and dashboard tab
Check the filters persist between the events and dashboard tab
Check the filters are cleaned when throwing in the events tab
Check cluster-manager filter on tabs. Must be applied when the tab is shown (all tabs)
Check pinned agent filter on tabs
Check the request with hidden filters applied (allow agents, hide manager alerts)
Check the fixer filter cannot be removed from the filter bar (the remove icon is hidden)
  • Check data results consistency between events and dashboard tab
  • Check the filters persist between the events and dashboard tab
  • Check the filters are cleaned when throwing in the events tab
  • Check cluster-manager filter on tabs. Must be applied when the tab is shown (all tabs)
  • Check pinned agent filter on tabs
  • Check the request with hidden filters applied (allow agents, hide manager alerts)

Enable/disable the hideManagerAlerts settings on App Settings

Screenshot 2024-03-31 at 12 29 47
  • Check the fixed filter cannot be removed from the filter bar

Dashboard tab

Test Chrome Firefox Safari
Use search bar input to filter any word and check if the dashboard shows the corresponding results
Select an option from one of the recommended filters and check that the corresponding filter is added and the dashboard changes according to the applied filter
Add a filter through interaction with a visualization and check that the dashboard updates
Use the input and type an incorrect word to check if the no results message is shown
  • Use search bar input to filter any word and check if the dashboard shows the corresponding results
  • Select an option from one of the recommended filters and check that the corresponding filter is added and the dashboard changes according to the applied filter
  • Add a filter through interaction with a visualization and check that the dashboard updates
  • Use the input and type an incorrect word to check if the no results message is shown

Events tab (Discover)

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input
Apply filters using the search bar add filter feature
Apply filters using the date picker
Apply filters with no results (Check the No results match your search criteria message)
Use the saved queries feature (Check saved queries CRUD)
  • Apply filters using search bar input
  • Apply filters using the search bar add filter feature
  • Apply filters using the date picker
  • Apply filters with no results (Check the No results match your search criteria message)
  • Use the saved queries feature (Check saved queries CRUD)

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency
Use chart options (three points: maximize, minimize, inspect)
  • Check histogram chart hits consistency
  • Use chart options (three points: maximize, minimize, inspect)

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc)
Check table pagination and rows per page
Check document detail flyout
  • Check all table header features (sort, show/hide columns, density, etc)
  • Check table pagination and rows per page
  • Check document detail flyout

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano self-assigned this Mar 8, 2024
@yenienserrano yenienserrano marked this pull request as draft March 8, 2024 21:11
@yenienserrano yenienserrano linked an issue Mar 8, 2024 that may be closed by this pull request
2 tasks
@yenienserrano yenienserrano changed the title 6493 remove discover implement embeddable dashboard on aws module Remove discover implement embeddable dashboard on aws module Mar 11, 2024
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.37% ( 397 / 875 )
Branches 41.31% ( 157 / 380 )
Functions 43.83% ( 135 / 308 )
Lines 45.61% ( 395 / 866 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 10.81% ( 3754 / 34725 )
Branches 7.27% ( 1653 / 22731 )
Functions 10.51% ( 871 / 8286 )
Lines 10.95% ( 3647 / 33281 )

@yenienserrano yenienserrano marked this pull request as ready for review April 19, 2024 12:55
@JuanGarriuz JuanGarriuz self-requested a review April 22, 2024 11:33
@JuanGarriuz
Copy link
Member

JuanGarriuz commented Apr 22, 2024

Test

Global

Test Chrome Firefox Safari
Check data results consistency between events and dashboard tab 🟢
Check the filters persist between the events and dashboard tab 🟢
Check the filters are cleaned when throwing in the events tab 🟢
Check pinned agent filter on tabs 🟢
Check the request with hidden filters applied (allow agents, hide manager alerts) 🟢
Check the fixer filter cannot be removed from the filter bar (the remove icon is hidden) 🟢
🟢 Check data results consistency between inventory and dashboard tab

image
image

🟢 Check the filters persist between the events and dashboard tab

image
image

🟢 Check the filters are cleaned when throwing in the events tab

image

image

🟢 Check pinned agent filter on tabs

image
image

🟢 Check the request with hidden filters applied (allow agents, hide manager alerts) `Enable/disable the hideManagerAlerts settings on App Settings`

image
image

🟢 Check the fixed filter cannot be removed from the filter bar

image
image

Dashboard tab

Test Chrome Firefox Safari
Use search bar input to filter any word and check if the dashboard shows the corresponding results 🟢
Select an option from one of the recommended filters and check that the corresponding filter is added and the dashboard changes according to the applied filter 🟢
Add a filter through interaction with a visualization and check that the dashboard updates 🟢
Use the input and type an incorrect word to check if the no results message is shown 🟢
🟢 Use search bar input to filter any word and check if the dashboard shows the corresponding results

image

🟢 Select an option from one of the recommended filters and check that the corresponding filter is added and the dashboard changes according to the applied filter

image

🟢 Add a filter through interaction with a visualization and check that the dashboard updates

image

🟢 Use the input and type an incorrect word to check if the no results message is shown

image

Events tab (Discover)

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input 🟢
Apply filters using the search bar add filter feature 🟢
Apply filters using the date picker 🟢
Apply filters with no results (Check the No results match your search criteria message) 🟢
Use the saved queries feature (Check saved queries CRUD) 🟢
🟢 Apply filters using search bar input

image

🟢 Apply filters using the search bar `add filter` feature

image

🟢 Apply filters using the date picker

image

🟢 Apply filters with no results (Check the `No results match your search criteria` message)

image

🟢 Use the `saved queries` feature (Check saved queries CRUD)

image

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency 🟢
Use chart options (three points: maximize, minimize, inspect) 🟢
🟢 Check histogram chart hits consistency

image

🟢 Use chart options (three points: maximize, minimize, inspect)

image

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc) 🟢
Check table pagination and rows per page 🟢
Check document detail flyout 🟢
🟢 Check all table header features (sort, show/hide columns, density, etc)

image
image
image
image

🟢 Check table pagination and rows per page

image
image

🟢 Check document detail flyout

image

JuanGarriuz
JuanGarriuz previously approved these changes Apr 22, 2024
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!

JuanGarriuz
JuanGarriuz previously approved these changes Apr 25, 2024
@jbiset
Copy link
Member

jbiset commented Apr 25, 2024

CR: 🟢

Test UI: 🟢

Global

Test Chrome Firefox Safari
Check data results consistency between events and dashboard tab 🟢 🟢
Check the filters persist between the events and dashboard tab 🟢 🟢
Check cluster-manager filter on tabs. Must be applied when the tab is shown (all tabs) 🟢 🟢
Check pinned agent filter on tabs 🟢 🟢
Check the request with hidden filters applied (allow agents, hide manager alerts) 🟢 🟢
Check the fixer filter cannot be removed from the filter bar (the remove icon is hidden) 🟢 🟢
  • Check data results consistency between events and dashboard tab 🟢

Chrome 🟢

image

image

Firefox 🟢

image

image

  • Check the filters persist between the events and dashboard tab 🟢

Chrome 🟢

Global_1_Chrome.webm

Firefox 🟢

Global_1_Firefox.webm
  • Check cluster-manager filter on tabs. Must be applied when the tab is shown (all tabs) 🟢

Chrome 🟢

image

image

Firefox 🟢

image

image

  • Check pinned agent filter on tabs 🟢

Chrome 🟢

Global_2_Chrome.webm

Firefox 🟢

Global_2_Firefox.webm
  • Check the request with hidden filters applied (allow agents, hide manager alerts) 🟢

Enable/disable the hideManagerAlerts settings on App Settings

image

Chrome 🟢

image

Firefox 🟢

image

  • Check the fixed filter cannot be removed from the filter bar 🟢

Chrome 🟢

image

Firefox 🟢

image

Dashboard tab

Test Chrome Firefox Safari
Use search bar input to filter any word and check if the dashboard shows the corresponding results 🟢 🟢
Select an option from one of the recommended filters and check that the corresponding filter is added and the dashboard changes according to the applied filter 🟢 🟢
Add a filter through interaction with a visualization and check that the dashboard updates 🟢 🟢
Use the input and type an incorrect word to check if the no results message is shown 🟢 🟢
  • Use search bar input to filter any word and check if the dashboard shows the corresponding results 🟢

Chrome 🟢

Dashboard_1_Chrome.webm

Firefox 🟢

Dashboard_1_Firefox.webm
  • Select an option from one of the recommended filters and check that the corresponding filter is added and the dashboard changes according to the applied filter 🟢

Chrome 🟢

Dashboard_2_Chrome.webm

Firefox 🟢

Dashboard_2_Firefox.webm
  • Add a filter through interaction with a visualization and check that the dashboard updates 🟢

Chrome 🟢

Dashboard_3_Chrome.webm

Firefox 🟢

Dashboard_3_Firefox.webm
  • Use the input and type an incorrect word to check if the no results message is shown 🟢

Chrome 🟢

image

Firefox 🟢

image

Events tab (Discover)

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input 🟢 🟢
Apply filters using the search bar add filter feature 🟢 🟢
Apply filters using the date picker 🟢 🟢
Apply filters with no results (Check the No results match your search criteria message) 🟢 🟢
Use the saved queries feature (Check saved queries CRUD) 🟢 🟢
  • Apply filters using search bar input 🟢

Chrome 🟢

Events_1_Chrome.webm

Firefox 🟢

Events_1_Firefox.webm
  • Apply filters using the search bar add filter feature 🟢

Chrome 🟢

Events_2_Chrome.webm

Firefox 🟢

Events_2_Firefox.webm
  • Apply filters using the date picker 🟢

Chrome 🟢

Events_3_Chrome.webm

Firefox 🟢

Events_3_Firefox.webm
  • Apply filters with no results (Check the No results match your search criteria message) 🟢

Chrome 🟢

image

Firefox 🟢

image

  • Use the saved queries feature (Check saved queries CRUD) 🟢

Chrome 🟢

Events_4_Chrome.webm

Firefox 🟢

Events_4_Firefox.webm

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency 🟢 🟢
Use chart options (three points: maximize, minimize, inspect) 🟢 🟢
  • Check histogram chart hits consistency 🟢

Chrome 🟢

image

Firefox 🟢

image

  • Use chart options (three points: maximize, minimize, inspect) 🟢

Chrome 🟢

Histogram_1_Chrome.webm

Firefox 🟢

Histogram_1_Firefox.webm

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc) 🟡 🟡
Check table pagination and rows per page 🟢 🟢
Check document detail flyout 🟢 🟢
  • Check all table header features (sort, show/hide columns, density, etc) 🟡

The behavior of moving columns is not correct

Chrome 🟡

DataGrid_1_Chrome.webm

Firefox 🟡

DataGrid_1_Firefox.webm
  • Check table pagination and rows per page 🟢

Chrome 🟢

DataGrid_2_Chrome.webm

Firefox 🟢

DataGrid_2_Firefox.webm
  • Check document detail flyout 🟢

Chrome 🟢

image

Firefox 🟢

image

jbiset
jbiset previously approved these changes Apr 26, 2024
Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

JuanGarriuz
JuanGarriuz previously approved these changes Apr 26, 2024
@yenienserrano yenienserrano dismissed stale reviews from JuanGarriuz and jbiset via ec02b1c April 26, 2024 17:08
@Tostti Tostti merged commit a9ff851 into 4.9.0 Apr 26, 2024
1 check passed
@Tostti Tostti deleted the 6493-remove-discover-implement-embeddable-dashboard-on-aws-module branch April 26, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Remove discover] Implement embeddable dashboard on AWS module
4 participants