Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valid IP addresses and file hashes in alerts generator #6667

Merged
merged 4 commits into from
May 14, 2024
Merged

Valid IP addresses and file hashes in alerts generator #6667

merged 4 commits into from
May 14, 2024

Conversation

JuanGarriuz
Copy link
Member

@JuanGarriuz JuanGarriuz commented May 14, 2024 •
edited by asteriscos
Loading

Description

Changes wazuh-alerts-generator SHA-256 hashes (64 hex. characters instead of 60).

Issues Resolved

Evidence

Sample data agent.id: 007 has valid IP
image

syscheck.sha256_after has a length of 64 characters
image

Test

  • Generate sample alerts
  • Check sample data agent.id: 007 has valid IP.
  • Verify the length of the property syscheck.sha256_after has a length of 64 characters.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@JuanGarriuz JuanGarriuz linked an issue May 14, 2024 that may be closed by this pull request
Generate valid IP addresses and file hashes in wazuh-alerts-generator #6621
Closed
@JuanGarriuz JuanGarriuz changed the title Valid ip addresses in alerts generator Valid ip addresses and file hashes in alerts generator May 14, 2024
@asteriscos asteriscos marked this pull request as ready for review May 14, 2024 16:17
@lucianogorza lucianogorza self-requested a review May 14, 2024 16:52
@yenienserrano yenienserrano self-requested a review May 14, 2024 17:16
yenienserrano
yenienserrano approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image image

@asteriscos asteriscos changed the title Valid ip addresses and file hashes in alerts generator Valid IP addresses and file hashes in alerts generator May 14, 2024
lucianogorza
lucianogorza approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@lucianogorza lucianogorza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🟢

Test 🟢

Sample data agent.id 007 has valid IP

image

syscheck.sha256_after has a length of 64 characters

image

ddc75fdf080fb00c09c2bf40d730faf3a25c9ceb09baa349234ae7322833af64

@asteriscos asteriscos merged commit 16d03fb into 4.9.0 May 14, 2024
1 check passed
@asteriscos asteriscos deleted the feat/6621-valid-ip-addresses-in-alerts-generator branch May 14, 2024 17:40
@misje misje mentioned this pull request Jun 24, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano approved these changes

@lucianogorza lucianogorza lucianogorza approved these changes

Assignees

@JuanGarriuz JuanGarriuz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate valid IP addresses and file hashes in wazuh-alerts-generator
4 participants
@JuanGarriuz @yenienserrano @lucianogorza @asteriscos