Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logger fix #667

Merged
merged 3 commits into from Jul 9, 2018
Merged

Logger fix #667

merged 3 commits into from Jul 9, 2018

Conversation

jesusgn90
Copy link
Contributor

Hello team, this PR fixes #618

Brief summary:

  • Wait until logs directory is created before try to write a new log entry
  • Wait until log rotation finishes before try to write a new log entry
  • Updated Winston library from 3.0.0-rc1 to 3.0.0 stable

Regards,
Jesús

@jesusgn90 jesusgn90 self-assigned this Jul 9, 2018
@jesusgn90 jesusgn90 added this to Pending in Revision 400 via automation Jul 9, 2018
@jesusgn90 jesusgn90 mentioned this pull request Jul 9, 2018
Closed
@jesusgn90 jesusgn90 merged commit fa1faae into 3.3-6.3 Jul 9, 2018
Revision 400 automation moved this from Pending to Testing Jul 9, 2018
This was referenced Jul 9, 2018
Closed
Merged
@jesusgn90 jesusgn90 moved this from Testing to Done in Revision 400 Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jesusgn90 jesusgn90

Labels
None yet
Projects
No open projects
Revision 400
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jesusgn90