Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code quality enhancement #892

Merged
merged 5 commits into from
Sep 14, 2018
Merged

Code quality enhancement #892

merged 5 commits into from
Sep 14, 2018

Conversation

jesusgn90
Copy link
Contributor

Hello team, this PR gives the App a better code structure, it passes all the eslint rules, lot of modules are now exporting named methods/classes, the code now follows the recommended styleguide for Javascript a few other enhancements.

Regards!

@jesusgn90 jesusgn90 added the type/enhancement Enhancement issue label Sep 12, 2018
@jesusgn90 jesusgn90 self-assigned this Sep 12, 2018
@jesusgn90 jesusgn90 added this to Pending feature in Revision 415 via automation Sep 12, 2018
@jesusgn90 jesusgn90 merged commit 2fc3716 into 3.6-6.4 Sep 14, 2018
Revision 415 automation moved this from Pending feature to Feature testing Sep 14, 2018
@jesusgn90 jesusgn90 deleted the eslint-dev branch September 14, 2018 05:05
@JuanjiJG JuanjiJG moved this from Feature testing to Done in Revision 415 Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Enhancement issue
Projects
No open projects
Revision 415
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant